From: Marc Zyngier <maz@kernel.org>
To: Dmitry Rokosov <DDRokosov@sberdevices.ru>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"linux@rasmusvillemoes.dk>" <linux@rasmusvillemoes.dk>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] regmap: introduce value tracing for regmap bulk operations
Date: Thu, 18 Aug 2022 14:49:20 +0100 [thread overview]
Message-ID: <87mtc1wtjz.wl-maz@kernel.org> (raw)
In-Reply-To: <20220818121515.6azkxyqetnunwsc6@CAB-WSD-L081021.sigma.sbrf.ru>
On Thu, 18 Aug 2022 13:15:00 +0100,
Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:
>
> +Thomas, Rasmus and Marc
>
> On Tue, Aug 16, 2022 at 06:14:48PM +0000, Dmitry Rokosov wrote:
> > Currently, only one-register io operations support tracepoints with
> > value logging. For the regmap bulk operations developer can view
> > hw_start/hw_done tracepoints with starting reg number and registers
> > count to be reading or writing. This patch injects tracepoints with
> > dumping registers values in the hex format to regmap bulk reading
> > and writing.
I don't care much about regmap as a MMIO backend, but it strikes me as
odd that you end up with multiple ways of logging the same stuff (with
a memcpy in the middle of it).
Why can't this be done with a small amount of trace post-processing?
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-08-18 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 18:14 [PATCH v1] regmap: introduce value tracing for regmap bulk operations Dmitry Rokosov
2022-08-18 12:15 ` Dmitry Rokosov
2022-08-18 13:49 ` Marc Zyngier [this message]
2022-08-18 15:43 ` Mark Brown
2022-08-18 17:44 ` Dmitry Rokosov
2022-08-19 12:07 ` Mark Brown
2022-08-19 13:31 ` Dmitry Rokosov
2022-08-19 14:44 ` Mark Brown
2022-08-19 15:22 ` Dmitry Rokosov
2022-08-19 14:25 ` Marc Zyngier
2022-08-19 14:38 ` Mark Brown
2022-08-19 15:31 ` Dmitry Rokosov
2022-08-18 17:02 ` Dmitry Rokosov
2022-08-23 16:47 ` Mark Brown
2022-08-23 21:39 ` Andy Shevchenko
2022-08-31 0:45 ` Dmitry Rokosov
2022-09-01 13:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtc1wtjz.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=DDRokosov@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.