From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] regmap: introduce value tracing for regmap bulk operations
Date: Thu, 1 Sep 2022 16:16:34 +0300 [thread overview]
Message-ID: <YxCwstzaKm7qhCWV@smile.fi.intel.com> (raw)
In-Reply-To: <20220831004530.zhvd7ehndqwmqgve@Rockosov-MBP>
On Wed, Aug 31, 2022 at 03:45:30AM +0300, Dmitry Rokosov wrote:
...
> > > + if (val)
> > > + memcpy(__get_dynamic_array(buf), val, val_len);
> >
> > I'm probably missing something, but what this condition prevents from?
>
> In general, this condition prevents memcpy from being executed when
> tracepoint is called with a null pointed buffer.
If we got a NULL pointer here, we already in a lot of troubles.
I believe the check is not needed.
Otherwise the function prints garbage.
I will send a series to remove that and clean up the file.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-09-01 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 18:14 [PATCH v1] regmap: introduce value tracing for regmap bulk operations Dmitry Rokosov
2022-08-18 12:15 ` Dmitry Rokosov
2022-08-18 13:49 ` Marc Zyngier
2022-08-18 15:43 ` Mark Brown
2022-08-18 17:44 ` Dmitry Rokosov
2022-08-19 12:07 ` Mark Brown
2022-08-19 13:31 ` Dmitry Rokosov
2022-08-19 14:44 ` Mark Brown
2022-08-19 15:22 ` Dmitry Rokosov
2022-08-19 14:25 ` Marc Zyngier
2022-08-19 14:38 ` Mark Brown
2022-08-19 15:31 ` Dmitry Rokosov
2022-08-18 17:02 ` Dmitry Rokosov
2022-08-23 16:47 ` Mark Brown
2022-08-23 21:39 ` Andy Shevchenko
2022-08-31 0:45 ` Dmitry Rokosov
2022-09-01 13:16 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxCwstzaKm7qhCWV@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=ddrokosov@sberdevices.ru \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.