From: Peter Korsgaard <peter@korsgaard.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Srinivas Neeli <srinivas.neeli@xilinx.com>,
a.zummo@towertech.it, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com,
sgoud@xilinx.com, shubhraj@xilinx.com, srinivas.neeli@amd.com,
neelisrinivas18@gmail.com, devicetree@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@xilinx.com
Subject: Re: [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support
Date: Thu, 09 Jun 2022 16:59:45 +0200 [thread overview]
Message-ID: <87mtel287y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <YqIJektBvAwOqNkA@mail.local> (Alexandre Belloni's message of "Thu, 9 Jun 2022 16:53:46 +0200")
>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@bootlin.com> writes:
> On 09/06/2022 16:50:03+0200, Peter Korsgaard wrote:
>> >>>>> "Srinivas" == Srinivas Neeli <srinivas.neeli@xilinx.com> writes:
>>
>> > Zynqmp RTC controller has a calibration feature to compensate
>> > time deviation due to input clock inaccuracy.
>> > Set and get calibration API's are used for setting and getting
>> > calibration value from the controller calibration register.
>> > As per RTC spec default calibration value is 0x7FFF.
>>
>> Where do you see that? ug1085 rev2.2 still lists:
>>
>> Programming Sequences
>> init rtc
>> 1. Write the value 0019_8231h into the calibration register, CALIB_WRITE.
>>
> This is a very weird value. Last time I had a look, I couldn't find an
> explanation for it.
Agreed. I am not arguing that it is sensible, I just wondered where this
new value comes from?
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <peter@korsgaard.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Srinivas Neeli <srinivas.neeli@xilinx.com>,
a.zummo@towertech.it, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com,
sgoud@xilinx.com, shubhraj@xilinx.com, srinivas.neeli@amd.com,
neelisrinivas18@gmail.com, devicetree@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@xilinx.com
Subject: Re: [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support
Date: Thu, 09 Jun 2022 16:59:45 +0200 [thread overview]
Message-ID: <87mtel287y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <YqIJektBvAwOqNkA@mail.local> (Alexandre Belloni's message of "Thu, 9 Jun 2022 16:53:46 +0200")
>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@bootlin.com> writes:
> On 09/06/2022 16:50:03+0200, Peter Korsgaard wrote:
>> >>>>> "Srinivas" == Srinivas Neeli <srinivas.neeli@xilinx.com> writes:
>>
>> > Zynqmp RTC controller has a calibration feature to compensate
>> > time deviation due to input clock inaccuracy.
>> > Set and get calibration API's are used for setting and getting
>> > calibration value from the controller calibration register.
>> > As per RTC spec default calibration value is 0x7FFF.
>>
>> Where do you see that? ug1085 rev2.2 still lists:
>>
>> Programming Sequences
>> init rtc
>> 1. Write the value 0019_8231h into the calibration register, CALIB_WRITE.
>>
> This is a very weird value. Last time I had a look, I couldn't find an
> explanation for it.
Agreed. I am not arguing that it is sensible, I just wondered where this
new value comes from?
--
Bye, Peter Korsgaard
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-09 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 14:08 [PATCH V6 1/2] dt-bindings: rtc: zynqmp: Add clock information Srinivas Neeli
2022-06-09 14:08 ` Srinivas Neeli
2022-06-09 14:08 ` [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support Srinivas Neeli
2022-06-09 14:08 ` Srinivas Neeli
2022-06-09 14:50 ` Peter Korsgaard
2022-06-09 14:50 ` Peter Korsgaard
2022-06-09 14:53 ` Alexandre Belloni
2022-06-09 14:53 ` Alexandre Belloni
2022-06-09 14:59 ` Peter Korsgaard [this message]
2022-06-09 14:59 ` Peter Korsgaard
2022-06-10 10:02 ` Neeli, Srinivas
2022-06-10 10:02 ` Neeli, Srinivas
2022-06-10 10:12 ` Peter Korsgaard
2022-06-10 10:12 ` Peter Korsgaard
2022-06-10 10:40 ` Alexandre Belloni
2022-06-10 10:40 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtel287y.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=neelisrinivas18@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
--cc=shubhraj@xilinx.com \
--cc=srinivas.neeli@amd.com \
--cc=srinivas.neeli@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.