From: Kalle Valo <kvalo@kernel.org>
To: Sriram R <quic_srirrama@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath11k: update missing mumimo and ofdma stats
Date: Tue, 10 May 2022 19:45:22 +0300 [thread overview]
Message-ID: <87mtfp72vx.fsf@kernel.org> (raw)
In-Reply-To: <1652152236-12038-1-git-send-email-quic_srirrama@quicinc.com> (Sriram R.'s message of "Tue, 10 May 2022 08:40:36 +0530")
Sriram R <quic_srirrama@quicinc.com> writes:
> Update the missing MU-MIMO/OFDMA info in PDEV RX,
> trigger and schedule stats. i.e HTT stats type 10, 12 and 17
> respectively.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4-01209-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
[...]
> @@ -734,6 +738,21 @@ struct htt_tx_pdev_mu_mimo_sch_stats_tlv {
> u32 ac_mu_mimo_sch_nusers[HTT_TX_PDEV_STATS_NUM_AC_MUMIMO_USER_STATS];
> u32 ax_mu_mimo_sch_nusers[HTT_TX_PDEV_STATS_NUM_AX_MUMIMO_USER_STATS];
> u32 ax_ofdma_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_basic_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_bsr_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_bar_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_brp_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + /* UL MUMIMO */
> + /* ax_ul_mumimo_basic_sch_nusers[i] is the number of basic triggers sent
> + * for (i+1) users
> + */
> + u32 ax_ul_mumimo_basic_sch_nusers[HTT_TX_PDEV_STATS_NUM_UL_MUMIMO_USER_STATS];
> + /* ax_ul_mumimo_brp_sch_nusers[i] is the number of brp triggers sent
> + * for (i+1) users
> + */
> + u32 ax_ul_mumimo_brp_sch_nusers[HTT_TX_PDEV_STATS_NUM_UL_MUMIMO_USER_STATS];
> + u32 ac_mu_mimo_sch_posted_per_grp_sz[HTT_TX_PDEV_STATS_NUM_AC_MUMIMO_USER_STATS];
> + u32 ax_mu_mimo_sch_posted_per_grp_sz[HTT_TX_PDEV_STATS_NUM_AX_MUMIMO_USER_STATS];
> };
In the pending branch I added some newlines to make this more readable.
> @@ -1297,6 +1316,8 @@ struct htt_tx_pdev_rate_stats_tlv {
> #define HTT_RX_PDEV_STATS_NUM_PREAMBLE_TYPES HTT_STATS_PREAM_COUNT
> #define HTT_RX_PDEV_MAX_OFDMA_NUM_USER 8
> #define HTT_RX_PDEV_STATS_RXEVM_MAX_PILOTS_PER_NSS 16
> +#define HTT_RX_PDEV_STATS_NUM_RU_SIZE_COUNTERS 6
> +#define HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER 8
>
> struct htt_rx_pdev_rate_stats_tlv {
> u32 mac_id__word;
> @@ -1375,6 +1396,21 @@ struct htt_rx_pdev_rate_stats_tlv {
> u32 per_chain_rssi_pkt_type;
> s8 rx_per_chain_rssi_in_dbm[HTT_RX_PDEV_STATS_NUM_SPATIAL_STREAMS]
> [HTT_RX_PDEV_STATS_NUM_BW_COUNTERS];
> +
> + u32 rx_su_ndpa;
> + u32 rx_11ax_su_txbf_mcs[HTT_RX_PDEV_STATS_NUM_MCS_COUNTERS];
> + u32 rx_mu_ndpa;
> + u32 rx_11ax_mu_txbf_mcs[HTT_RX_PDEV_STATS_NUM_MCS_COUNTERS];
> + u32 rx_br_poll;
> + u32 rx_11ax_dl_ofdma_mcs[HTT_RX_PDEV_STATS_NUM_MCS_COUNTERS];
> + u32 rx_11ax_dl_ofdma_ru[HTT_RX_PDEV_STATS_NUM_RU_SIZE_COUNTERS];
> +
> + u32 rx_ulmumimo_non_data_ppdu[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* ppdu level */
> + u32 rx_ulmumimo_data_ppdu[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* ppdu level */
> + u32 rx_ulmumimo_mpdu_ok[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* mpdu level */
> + u32 rx_ulmumimo_mpdu_fail[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* mpdu level */
> + u32 rx_ulofdma_non_data_nusers[HTT_RX_PDEV_MAX_OFDMA_NUM_USER];
> + u32 rx_ulofdma_data_nusers[HTT_RX_PDEV_MAX_OFDMA_NUM_USER];
> };
The comments didn't provide any extra information so I removed them.
There were also new warnings, fixed in the pending branch:
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:2978: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:2983: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3051: line length of 95 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3054: line length of 91 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3057: line length of 93 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3060: line length of 96 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3063: line length of 97 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3066: line length of 93 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3069: line length of 91 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3072: line length of 93 exceeds 90 columns
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Sriram R <quic_srirrama@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath11k: update missing mumimo and ofdma stats
Date: Tue, 10 May 2022 19:45:22 +0300 [thread overview]
Message-ID: <87mtfp72vx.fsf@kernel.org> (raw)
In-Reply-To: <1652152236-12038-1-git-send-email-quic_srirrama@quicinc.com> (Sriram R.'s message of "Tue, 10 May 2022 08:40:36 +0530")
Sriram R <quic_srirrama@quicinc.com> writes:
> Update the missing MU-MIMO/OFDMA info in PDEV RX,
> trigger and schedule stats. i.e HTT stats type 10, 12 and 17
> respectively.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4-01209-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
[...]
> @@ -734,6 +738,21 @@ struct htt_tx_pdev_mu_mimo_sch_stats_tlv {
> u32 ac_mu_mimo_sch_nusers[HTT_TX_PDEV_STATS_NUM_AC_MUMIMO_USER_STATS];
> u32 ax_mu_mimo_sch_nusers[HTT_TX_PDEV_STATS_NUM_AX_MUMIMO_USER_STATS];
> u32 ax_ofdma_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_basic_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_bsr_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_bar_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + u32 ax_ul_ofdma_brp_sch_nusers[HTT_TX_PDEV_STATS_NUM_OFDMA_USER_STATS];
> + /* UL MUMIMO */
> + /* ax_ul_mumimo_basic_sch_nusers[i] is the number of basic triggers sent
> + * for (i+1) users
> + */
> + u32 ax_ul_mumimo_basic_sch_nusers[HTT_TX_PDEV_STATS_NUM_UL_MUMIMO_USER_STATS];
> + /* ax_ul_mumimo_brp_sch_nusers[i] is the number of brp triggers sent
> + * for (i+1) users
> + */
> + u32 ax_ul_mumimo_brp_sch_nusers[HTT_TX_PDEV_STATS_NUM_UL_MUMIMO_USER_STATS];
> + u32 ac_mu_mimo_sch_posted_per_grp_sz[HTT_TX_PDEV_STATS_NUM_AC_MUMIMO_USER_STATS];
> + u32 ax_mu_mimo_sch_posted_per_grp_sz[HTT_TX_PDEV_STATS_NUM_AX_MUMIMO_USER_STATS];
> };
In the pending branch I added some newlines to make this more readable.
> @@ -1297,6 +1316,8 @@ struct htt_tx_pdev_rate_stats_tlv {
> #define HTT_RX_PDEV_STATS_NUM_PREAMBLE_TYPES HTT_STATS_PREAM_COUNT
> #define HTT_RX_PDEV_MAX_OFDMA_NUM_USER 8
> #define HTT_RX_PDEV_STATS_RXEVM_MAX_PILOTS_PER_NSS 16
> +#define HTT_RX_PDEV_STATS_NUM_RU_SIZE_COUNTERS 6
> +#define HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER 8
>
> struct htt_rx_pdev_rate_stats_tlv {
> u32 mac_id__word;
> @@ -1375,6 +1396,21 @@ struct htt_rx_pdev_rate_stats_tlv {
> u32 per_chain_rssi_pkt_type;
> s8 rx_per_chain_rssi_in_dbm[HTT_RX_PDEV_STATS_NUM_SPATIAL_STREAMS]
> [HTT_RX_PDEV_STATS_NUM_BW_COUNTERS];
> +
> + u32 rx_su_ndpa;
> + u32 rx_11ax_su_txbf_mcs[HTT_RX_PDEV_STATS_NUM_MCS_COUNTERS];
> + u32 rx_mu_ndpa;
> + u32 rx_11ax_mu_txbf_mcs[HTT_RX_PDEV_STATS_NUM_MCS_COUNTERS];
> + u32 rx_br_poll;
> + u32 rx_11ax_dl_ofdma_mcs[HTT_RX_PDEV_STATS_NUM_MCS_COUNTERS];
> + u32 rx_11ax_dl_ofdma_ru[HTT_RX_PDEV_STATS_NUM_RU_SIZE_COUNTERS];
> +
> + u32 rx_ulmumimo_non_data_ppdu[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* ppdu level */
> + u32 rx_ulmumimo_data_ppdu[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* ppdu level */
> + u32 rx_ulmumimo_mpdu_ok[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* mpdu level */
> + u32 rx_ulmumimo_mpdu_fail[HTT_RX_PDEV_MAX_ULMUMIMO_NUM_USER]; /* mpdu level */
> + u32 rx_ulofdma_non_data_nusers[HTT_RX_PDEV_MAX_OFDMA_NUM_USER];
> + u32 rx_ulofdma_data_nusers[HTT_RX_PDEV_MAX_OFDMA_NUM_USER];
> };
The comments didn't provide any extra information so I removed them.
There were also new warnings, fixed in the pending branch:
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:2978: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:2983: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3051: line length of 95 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3054: line length of 91 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3057: line length of 93 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3060: line length of 96 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3063: line length of 97 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3066: line length of 93 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3069: line length of 91 exceeds 90 columns
drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c:3072: line length of 93 exceeds 90 columns
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-10 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:10 [PATCH] ath11k: update missing mumimo and ofdma stats Sriram R
2022-05-10 3:10 ` Sriram R
2022-05-10 15:54 ` Jeff Johnson
2022-05-10 15:54 ` Jeff Johnson
2022-05-10 16:02 ` Kalle Valo
2022-05-10 16:02 ` Kalle Valo
2022-05-10 16:45 ` Kalle Valo [this message]
2022-05-10 16:45 ` Kalle Valo
2022-05-18 7:12 ` Kalle Valo
2022-05-18 7:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtfp72vx.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_srirrama@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.