From: Joachim Wiberg <troglobit@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
Roopa Prabhu <roopa@nvidia.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [Bridge] [PATCH RFC net-next 03/13] net: bridge: minor refactor of br_setlink() for readability
Date: Wed, 13 Apr 2022 11:22:23 +0200 [thread overview]
Message-ID: <87mtgp9w34.fsf@gmail.com> (raw)
In-Reply-To: <76490693-ea6d-7174-0546-b9361ab5088c@blackwall.org>
On Tue, Apr 12, 2022 at 21:36, Nikolay Aleksandrov <razor@blackwall.org> wrote:
> On 11/04/2022 16:38, Joachim Wiberg wrote:
>> The br_setlink() function extracts the struct net_bridge pointer a bit
>> sloppy. It's easy to interpret the code wrong. This patch attempts to
>> clear things up a bit.
> I think you can make it more straight-forward, remove the first br = netdev_priv
> and do something like (completely untested):
> ...
> struct net_bridge_port *p = NULL;
> ...
> if (netif_is_bridge_master(dev)) {
> br = netdev_priv(dev);
> } else {
> p = br_port_get_rtnl(dev);
> if (WARN_ON(!p))
> return -EINVAL;
> br = p->br;
> }
>
> So br is always and only set in this block.
Yes, this is much better, thank you! I took the misguided approach of
minmizing my change. I'll update and include in the non-RFC patch
series I send next.
WARNING: multiple messages have this Message-ID (diff)
From: Joachim Wiberg <troglobit@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
Roopa Prabhu <roopa@nvidia.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tobias Waldekranz <tobias@waldekranz.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH RFC net-next 03/13] net: bridge: minor refactor of br_setlink() for readability
Date: Wed, 13 Apr 2022 11:22:23 +0200 [thread overview]
Message-ID: <87mtgp9w34.fsf@gmail.com> (raw)
In-Reply-To: <76490693-ea6d-7174-0546-b9361ab5088c@blackwall.org>
On Tue, Apr 12, 2022 at 21:36, Nikolay Aleksandrov <razor@blackwall.org> wrote:
> On 11/04/2022 16:38, Joachim Wiberg wrote:
>> The br_setlink() function extracts the struct net_bridge pointer a bit
>> sloppy. It's easy to interpret the code wrong. This patch attempts to
>> clear things up a bit.
> I think you can make it more straight-forward, remove the first br = netdev_priv
> and do something like (completely untested):
> ...
> struct net_bridge_port *p = NULL;
> ...
> if (netif_is_bridge_master(dev)) {
> br = netdev_priv(dev);
> } else {
> p = br_port_get_rtnl(dev);
> if (WARN_ON(!p))
> return -EINVAL;
> br = p->br;
> }
>
> So br is always and only set in this block.
Yes, this is much better, thank you! I took the misguided approach of
minmizing my change. I'll update and include in the non-RFC patch
series I send next.
next prev parent reply other threads:[~2022-04-13 9:22 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 13:38 [Bridge] [PATCH RFC net-next 00/13] net: bridge: forwarding of unknown IPv4/IPv6/MAC BUM traffic Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 01/13] net: bridge: add control of bum flooding to bridge itself Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-12 18:27 ` [Bridge] " Nikolay Aleksandrov
2022-04-12 18:27 ` Nikolay Aleksandrov
2022-04-12 20:29 ` [Bridge] " Nikolay Aleksandrov
2022-04-12 20:29 ` Nikolay Aleksandrov
2022-04-13 9:51 ` [Bridge] " Joachim Wiberg
2022-04-13 9:51 ` Joachim Wiberg
2022-04-13 9:58 ` [Bridge] " Nikolay Aleksandrov
2022-04-13 9:58 ` Nikolay Aleksandrov
2022-04-13 10:09 ` [Bridge] " Joachim Wiberg
2022-04-13 10:09 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 02/13] net: bridge: rename br_switchdev_set_port_flag() to .._dev_flag() Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 03/13] net: bridge: minor refactor of br_setlink() for readability Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-12 18:36 ` [Bridge] " Nikolay Aleksandrov
2022-04-12 18:36 ` Nikolay Aleksandrov
2022-04-13 9:22 ` Joachim Wiberg [this message]
2022-04-13 9:22 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 04/13] net: bridge: netlink support for controlling BUM flooding to bridge Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-12 18:24 ` [Bridge] " Nikolay Aleksandrov
2022-04-12 18:24 ` Nikolay Aleksandrov
2022-04-13 10:04 ` [Bridge] " Joachim Wiberg
2022-04-13 10:04 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 05/13] selftests: forwarding: add TCPDUMP_EXTRA_FLAGS to lib.sh Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 17:20 ` [Bridge] " Vladimir Oltean
2022-04-11 17:20 ` Vladimir Oltean
2022-04-12 7:39 ` [Bridge] " Joachim Wiberg
2022-04-12 7:39 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 06/13] selftests: forwarding: multiple instances in tcpdump helper Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 17:26 ` [Bridge] " Vladimir Oltean
2022-04-11 17:26 ` Vladimir Oltean
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 07/13] selftests: forwarding: new test, verify bridge flood flags Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 20:21 ` [Bridge] " Vladimir Oltean
2022-04-11 20:21 ` Vladimir Oltean
2022-04-12 7:55 ` [Bridge] " Joachim Wiberg
2022-04-12 7:55 ` Joachim Wiberg
2022-04-12 13:40 ` [Bridge] " Vladimir Oltean
2022-04-12 13:40 ` Vladimir Oltean
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 08/13] net: bridge: avoid classifying unknown multicast as mrouters_only Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-12 13:59 ` [Bridge] " Nikolay Aleksandrov
2022-04-12 13:59 ` Nikolay Aleksandrov
2022-04-12 17:27 ` [Bridge] " Joachim Wiberg
2022-04-12 17:27 ` Joachim Wiberg
2022-04-12 17:37 ` [Bridge] " Nikolay Aleksandrov
2022-04-12 17:37 ` Nikolay Aleksandrov
2022-04-13 8:51 ` [Bridge] " Joachim Wiberg
2022-04-13 8:51 ` Joachim Wiberg
2022-04-13 8:55 ` [Bridge] " Nikolay Aleksandrov
2022-04-13 8:55 ` Nikolay Aleksandrov
2022-04-13 9:00 ` [Bridge] " Nikolay Aleksandrov
2022-04-13 9:00 ` Nikolay Aleksandrov
2022-04-13 10:12 ` [Bridge] " Joachim Wiberg
2022-04-13 10:12 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 09/13] selftests: forwarding: rename test groups for next bridge mdb tests Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 20:23 ` [Bridge] " Vladimir Oltean
2022-04-11 20:23 ` Vladimir Oltean
2022-04-12 7:57 ` [Bridge] " Joachim Wiberg
2022-04-12 7:57 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 10/13] selftests: forwarding: verify flooding of unknown multicast Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 11/13] selftests: forwarding: verify strict mdb fwd of known multicast Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 12/13] selftests: forwarding: verify strict filtering doesn't leak Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
2022-04-11 13:38 ` [Bridge] [PATCH RFC net-next 13/13] selftests: forwarding: verify flood of known mc on mcast_router port Joachim Wiberg
2022-04-11 13:38 ` Joachim Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtgp9w34.fsf@gmail.com \
--to=troglobit@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=tobias@waldekranz.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.