All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-db845c: add wifi variant property
Date: Mon, 04 Apr 2022 10:34:04 +0300	[thread overview]
Message-ID: <87mth1s3o3.fsf@kernel.org> (raw)
In-Reply-To: <87r16ds4ge.fsf@kernel.org> (Kalle Valo's message of "Mon, 04 Apr 2022 10:17:05 +0300")

Kalle Valo <kvalo@kernel.org> writes:

> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
>
>> Dragonboard845c doesn't have board-specific board-id programmed, it uses
>> generic 0xff. Thus add the property with the 'variant' of the
>> calibration data.
>>
>> Note: the driver will check for the calibration data for the following
>> IDs, so older board-2.bin files that were distributed as a part of
>> Linaro releases will continue to work.
>>
>> - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=Thundercomm_DB845C'
>> - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214'
>> - 'bus=snoc,qmi-board-id=ff'
>>
>> For the reference, the board is identified by the driver in the
>> following way:
>>
>> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
>> ath10k_snoc 18800000.wifi: qmi fw_version 0x2009856b fw_build_timestamp 2018-07-19 12:28 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1
>>
>> Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> index 13f80a0b6faa..f49de3913dd5 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1047,6 +1047,7 @@ &wifi {
>>  	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>>  
>>  	qcom,snoc-host-cap-8bit-quirk;
>> +	qcom,ath10k-calibration-variant = "Thundercomm_DB845C";
>
> I don't think I have documented it anywhere, but to keep things simple I
> would prefer to have the variant all lower case.

But, after thinking more, I guess that's water under the bridge now. So
please ignore my comment.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-db845c: add wifi variant property
Date: Mon, 04 Apr 2022 10:34:04 +0300	[thread overview]
Message-ID: <87mth1s3o3.fsf@kernel.org> (raw)
In-Reply-To: <87r16ds4ge.fsf@kernel.org> (Kalle Valo's message of "Mon, 04 Apr 2022 10:17:05 +0300")

Kalle Valo <kvalo@kernel.org> writes:

> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
>
>> Dragonboard845c doesn't have board-specific board-id programmed, it uses
>> generic 0xff. Thus add the property with the 'variant' of the
>> calibration data.
>>
>> Note: the driver will check for the calibration data for the following
>> IDs, so older board-2.bin files that were distributed as a part of
>> Linaro releases will continue to work.
>>
>> - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=Thundercomm_DB845C'
>> - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214'
>> - 'bus=snoc,qmi-board-id=ff'
>>
>> For the reference, the board is identified by the driver in the
>> following way:
>>
>> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
>> ath10k_snoc 18800000.wifi: qmi fw_version 0x2009856b fw_build_timestamp 2018-07-19 12:28 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1
>>
>> Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> index 13f80a0b6faa..f49de3913dd5 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1047,6 +1047,7 @@ &wifi {
>>  	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>>  
>>  	qcom,snoc-host-cap-8bit-quirk;
>> +	qcom,ath10k-calibration-variant = "Thundercomm_DB845C";
>
> I don't think I have documented it anywhere, but to keep things simple I
> would prefer to have the variant all lower case.

But, after thinking more, I guess that's water under the bridge now. So
please ignore my comment.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-04-04  7:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 10:57 [PATCH] arm64: dts: qcom: sdm845-db845c: add wifi variant property Dmitry Baryshkov
2022-04-03 10:57 ` Dmitry Baryshkov
2022-04-04  7:17 ` Kalle Valo
2022-04-04  7:17   ` Kalle Valo
2022-04-04  7:34   ` Kalle Valo [this message]
2022-04-04  7:34     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mth1s3o3.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=agross@kernel.org \
    --cc=ath10k@lists.infradead.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.