From: Philippe Gerum <rpm@xenomai.org>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [PATCH 1/4] sched: dovetail: pass thread-info bits to arch_dovetail_switch_finish()
Date: Sun, 03 Apr 2022 16:40:03 +0200 [thread overview]
Message-ID: <87mth2ns7l.fsf@xenomai.org> (raw)
In-Reply-To: <CAFLxGvx7v5PyoxW0SaFaNLh6eO9i0k0Wo7nu+1Tjz1QU5LzbcQ@mail.gmail.com>
Richard Weinberger <richard.weinberger@gmail.com> writes:
> On Sat, Apr 2, 2022 at 4:23 PM Philippe Gerum via Xenomai
> <xenomai@xenomai.org> wrote:
>
>> - arch_dovetail_switch_finish(leave_inband);
>> + ti_work = READ_ONCE(current_thread_info()->flags);
>> + arch_dovetail_switch_finish(leave_inband, ti_work);
>
> Why are you passing ti_work as parameter? AFAIU you can
> use current_thread_info()->flags directly in arch_dovetail_switch_finish().
Agreed, this affects the signature of arch_dovetail_switch_finish() for
no good reason. Besides, this patch is missing a case (task resuming
after oob -> inband transition). v2 follows (tested ok here).
--
Philippe.
prev parent reply other threads:[~2022-04-03 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 14:21 [PATCH 1/4] sched: dovetail: pass thread-info bits to arch_dovetail_switch_finish() Philippe Gerum
2022-04-02 14:21 ` [PATCH 2/4] ARM: dovetail: fix up arch_dovetail_switch_finish() signature Philippe Gerum
2022-04-02 14:21 ` [PATCH 3/4] arm64: " Philippe Gerum
2022-04-02 14:21 ` [PATCH 4/4] x86: dovetail: reinstate I/O bitmap on out-of-band user entry Philippe Gerum
2022-04-02 19:18 ` [PATCH 1/4] sched: dovetail: pass thread-info bits to arch_dovetail_switch_finish() Richard Weinberger
2022-04-03 14:40 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mth2ns7l.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=richard.weinberger@gmail.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.