From: Jani Nikula <jani.nikula@linux.intel.com>
To: cgel.zte@gmail.com
Cc: yao.jing2@zte.com.cn, thomas.hellstrom@linux.intel.com,
airlied@linux.ie, gregkh@linuxfoundation.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk,
matthew.auld@intel.com, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmabuf: remove duplicate include in i915_gem_dmabuf.c
Date: Wed, 24 Nov 2021 11:18:59 +0200 [thread overview]
Message-ID: <87mtltnc70.fsf@intel.com> (raw)
In-Reply-To: <20211124030607.34914-1-yao.jing2@zte.com.cn>
On Wed, 24 Nov 2021, cgel.zte@gmail.com wrote:
> From: Yao Jing <yao.jing2@zte.com.cn>
>
> 'asm/smp.h' included in 'drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c' is
> duplicated. It is clearly included on the 12 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yao Jing <yao.jing2@zte.com.cn>
The correct fix is [1].
If you keep sending patches from cgel.zte@gmail.com, you need to add
your Signed-off-by too.
BR,
Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211122135758.85444-1-tvrtko.ursulin@linux.intel.com
> ---
> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> index f291cf4c3886..5712b6b5f285 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> @@ -17,9 +17,7 @@
>
> MODULE_IMPORT_NS(DMA_BUF);
>
> -#if defined(CONFIG_X86)
> -#include <asm/smp.h>
> -#else
> +#if !defined(CONFIG_X86)
> #define wbinvd_on_all_cpus() \
> pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
> #endif
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: cgel.zte@gmail.com
Cc: tvrtko.ursulin@linux.intel.com, jason@jlekstrand.net,
yao.jing2@zte.com.cn, thomas.hellstrom@linux.intel.com,
airlied@linux.ie, gregkh@linuxfoundation.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk,
matthew.auld@intel.com, rodrigo.vivi@intel.com,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drm/i915/dmabuf: remove duplicate include in i915_gem_dmabuf.c
Date: Wed, 24 Nov 2021 11:18:59 +0200 [thread overview]
Message-ID: <87mtltnc70.fsf@intel.com> (raw)
In-Reply-To: <20211124030607.34914-1-yao.jing2@zte.com.cn>
On Wed, 24 Nov 2021, cgel.zte@gmail.com wrote:
> From: Yao Jing <yao.jing2@zte.com.cn>
>
> 'asm/smp.h' included in 'drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c' is
> duplicated. It is clearly included on the 12 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yao Jing <yao.jing2@zte.com.cn>
The correct fix is [1].
If you keep sending patches from cgel.zte@gmail.com, you need to add
your Signed-off-by too.
BR,
Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211122135758.85444-1-tvrtko.ursulin@linux.intel.com
> ---
> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> index f291cf4c3886..5712b6b5f285 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> @@ -17,9 +17,7 @@
>
> MODULE_IMPORT_NS(DMA_BUF);
>
> -#if defined(CONFIG_X86)
> -#include <asm/smp.h>
> -#else
> +#if !defined(CONFIG_X86)
> #define wbinvd_on_all_cpus() \
> pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
> #endif
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: cgel.zte@gmail.com
Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
tvrtko.ursulin@linux.intel.com, airlied@linux.ie,
daniel@ffwll.ch, matthew.auld@intel.com,
thomas.hellstrom@linux.intel.com, jason@jlekstrand.net,
chris@chris-wilson.co.uk, maarten.lankhorst@linux.intel.com,
yao.jing2@zte.com.cn, gregkh@linuxfoundation.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drm/i915/dmabuf: remove duplicate include in i915_gem_dmabuf.c
Date: Wed, 24 Nov 2021 11:18:59 +0200 [thread overview]
Message-ID: <87mtltnc70.fsf@intel.com> (raw)
In-Reply-To: <20211124030607.34914-1-yao.jing2@zte.com.cn>
On Wed, 24 Nov 2021, cgel.zte@gmail.com wrote:
> From: Yao Jing <yao.jing2@zte.com.cn>
>
> 'asm/smp.h' included in 'drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c' is
> duplicated. It is clearly included on the 12 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yao Jing <yao.jing2@zte.com.cn>
The correct fix is [1].
If you keep sending patches from cgel.zte@gmail.com, you need to add
your Signed-off-by too.
BR,
Jani.
[1] https://patchwork.freedesktop.org/patch/msgid/20211122135758.85444-1-tvrtko.ursulin@linux.intel.com
> ---
> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> index f291cf4c3886..5712b6b5f285 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> @@ -17,9 +17,7 @@
>
> MODULE_IMPORT_NS(DMA_BUF);
>
> -#if defined(CONFIG_X86)
> -#include <asm/smp.h>
> -#else
> +#if !defined(CONFIG_X86)
> #define wbinvd_on_all_cpus() \
> pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
> #endif
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-11-24 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 3:06 [Intel-gfx] [PATCH] drm/i915/dmabuf: remove duplicate include in i915_gem_dmabuf.c cgel.zte
2021-11-24 3:06 ` cgel.zte
2021-11-24 3:06 ` cgel.zte
2021-11-24 9:18 ` Jani Nikula [this message]
2021-11-24 9:18 ` Jani Nikula
2021-11-24 9:18 ` Jani Nikula
2021-11-24 13:58 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtltnc70.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=cgel.zte@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=yao.jing2@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.