From: Juan Quintela <quintela@redhat.com>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2] meson: Propagate gnutls dependency to migration
Date: Tue, 23 Mar 2021 16:04:48 +0100 [thread overview]
Message-ID: <87mtutewrz.fsf@secure.mitica> (raw)
In-Reply-To: <20210320171221.37437-1-jrtc27@jrtc27.com> (Jessica Clarke's message of "Sat, 20 Mar 2021 17:12:21 +0000")
Jessica Clarke <jrtc27@jrtc27.com> wrote:
> Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this
> for softmmu configs, which pull in migration's use of gnutls.
>
> This fixes the following compilation failure on Arm-based Macs:
>
> In file included from migration/multifd.c:23:
> In file included from migration/tls.h:25:
> In file included from include/io/channel-tls.h:26:
> In file included from include/crypto/tlssession.h:24:
> include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not found
> #include <gnutls/gnutls.h>
> ^~~~~~~~~~~~~~~~~
> 1 error generated.
>
> (as well as for channel.c and tls.c)
>
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
I would preffer to be the other way around, i.e. modularize tls out of
migration, but a fast look at it shows it as a big job. As said on the
commint message, channel.c & tls.c both use tls not conditionally.
Once there, multifd.c also requires tls compiled in.
Can we realistically build qemu without tls nowadays?
Later, Juan.
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2] meson: Propagate gnutls dependency to migration
Date: Tue, 23 Mar 2021 16:04:48 +0100 [thread overview]
Message-ID: <87mtutewrz.fsf@secure.mitica> (raw)
In-Reply-To: <20210320171221.37437-1-jrtc27@jrtc27.com> (Jessica Clarke's message of "Sat, 20 Mar 2021 17:12:21 +0000")
Jessica Clarke <jrtc27@jrtc27.com> wrote:
> Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this
> for softmmu configs, which pull in migration's use of gnutls.
>
> This fixes the following compilation failure on Arm-based Macs:
>
> In file included from migration/multifd.c:23:
> In file included from migration/tls.h:25:
> In file included from include/io/channel-tls.h:26:
> In file included from include/crypto/tlssession.h:24:
> include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not found
> #include <gnutls/gnutls.h>
> ^~~~~~~~~~~~~~~~~
> 1 error generated.
>
> (as well as for channel.c and tls.c)
>
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
I would preffer to be the other way around, i.e. modularize tls out of
migration, but a fast look at it shows it as a big job. As said on the
commint message, channel.c & tls.c both use tls not conditionally.
Once there, multifd.c also requires tls compiled in.
Can we realistically build qemu without tls nowadays?
Later, Juan.
next prev parent reply other threads:[~2021-03-23 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 16:47 [PATCH] meson: Propagate gnutls dependency to migration Jessica Clarke
2021-03-20 16:47 ` Jessica Clarke
2021-03-20 17:06 ` Paolo Bonzini
2021-03-20 17:07 ` Paolo Bonzini
2021-03-20 17:12 ` [PATCH v2] " Jessica Clarke
2021-03-20 17:12 ` Jessica Clarke
2021-03-23 15:04 ` Juan Quintela [this message]
2021-03-23 15:04 ` Juan Quintela
2021-03-23 15:13 ` Daniel P. Berrangé
2021-03-23 15:13 ` Daniel P. Berrangé
2021-03-24 13:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtutewrz.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jrtc27@jrtc27.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.