All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Povlsen <lars.povlsen@microchip.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	<UNGLinuxDriver@microchip.com>, <linux-gpio@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mips@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII
Date: Wed, 10 Feb 2021 14:45:31 +0100	[thread overview]
Message-ID: <87mtwcujd0.fsf@microchip.com> (raw)
In-Reply-To: <20210210132751.1422386-1-geert+renesas@glider.be>


Geert Uytterhoeven writes:

> the Microsemi/Microchip Serial GPIO device is present only Microsemi
> VCore III and Microchip Sparx5 SoCs.  Hence add a dependency on
> ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this
> driver when configuring a kernel without support for these SoCs.
>
> Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/pinctrl/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -353,8 +353,8 @@ config PINCTRL_OCELOT
>
>  config PINCTRL_MICROCHIP_SGPIO
>         bool "Pinctrl driver for Microsemi/Microchip Serial GPIO"
> -       depends on OF
> -       depends on HAS_IOMEM
> +       depends on OF && HAS_IOMEM
> +       depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST
>         select GPIOLIB
>         select GPIOLIB_IRQCHIP
>         select GENERIC_PINCONF

Geert,

Thank you for your patch. Unfortunately, it makes it impossible to use
the driver across PCIe - which is a specifically desired configuration.

Could you add CONFIG_PCI to the || chain?

Cheers,

-- 
Lars Povlsen,
Microchip

WARNING: multiple messages have this Message-ID (diff)
From: Lars Povlsen <lars.povlsen@microchip.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-mips@vger.kernel.org, UNGLinuxDriver@microchip.com,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII
Date: Wed, 10 Feb 2021 14:45:31 +0100	[thread overview]
Message-ID: <87mtwcujd0.fsf@microchip.com> (raw)
In-Reply-To: <20210210132751.1422386-1-geert+renesas@glider.be>


Geert Uytterhoeven writes:

> the Microsemi/Microchip Serial GPIO device is present only Microsemi
> VCore III and Microchip Sparx5 SoCs.  Hence add a dependency on
> ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this
> driver when configuring a kernel without support for these SoCs.
>
> Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/pinctrl/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -353,8 +353,8 @@ config PINCTRL_OCELOT
>
>  config PINCTRL_MICROCHIP_SGPIO
>         bool "Pinctrl driver for Microsemi/Microchip Serial GPIO"
> -       depends on OF
> -       depends on HAS_IOMEM
> +       depends on OF && HAS_IOMEM
> +       depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST
>         select GPIOLIB
>         select GPIOLIB_IRQCHIP
>         select GENERIC_PINCONF

Geert,

Thank you for your patch. Unfortunately, it makes it impossible to use
the driver across PCIe - which is a specifically desired configuration.

Could you add CONFIG_PCI to the || chain?

Cheers,

-- 
Lars Povlsen,
Microchip

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-10 13:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 13:27 [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII Geert Uytterhoeven
2021-02-10 13:27 ` Geert Uytterhoeven
2021-02-10 13:45 ` Lars Povlsen [this message]
2021-02-10 13:45   ` Lars Povlsen
2021-02-10 13:53   ` Geert Uytterhoeven
2021-02-10 13:53     ` Geert Uytterhoeven
2021-02-10 14:17     ` Alexandre Belloni
2021-02-10 14:17       ` Alexandre Belloni
2021-02-10 14:21       ` Geert Uytterhoeven
2021-02-10 14:21         ` Geert Uytterhoeven
2021-02-10 14:24         ` Lars Povlsen
2021-02-10 14:24           ` Lars Povlsen
2021-02-10 14:28           ` Geert Uytterhoeven
2021-02-10 14:28             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtwcujd0.fsf@microchip.com \
    --to=lars.povlsen@microchip.com \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.