From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: armada-38x: use the new thermal binding
Date: Wed, 04 Jul 2018 15:29:37 +0200 [thread overview]
Message-ID: <87muv72kou.fsf@bootlin.com> (raw)
In-Reply-To: <fa45caea9ab04a515805e80b8c02a74a00a908e0.1530588260.git.baruch@tkos.co.il> (Baruch Siach's message of "Tue, 3 Jul 2018 06:24:20 +0300")
Hi Baruch,
On mar., juil. 03 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 2f28e4c24b10e (thermal: armada: Clarify control registers
> accesses) introduced the new thermal binding. The new binding extends
> the second registers field size to 8. Switch to the new binding to fix
> thermal reading values. Without this change the fix for errata #132698
> introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim
> default value) has no effect.
>
> Cc: stable at vger.kernel.org # v4.16+
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied on mvebu/fixes
Thanks,
Gregory
> ---
> v2:
> * Typo fixes (Andreas F?rber)
> * Add Miquel's review tag
> * Minor wording changes
> * Cc stable
> ---
> arch/arm/boot/dts/armada-38x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index 18edc9bc7927..929459c42760 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -547,7 +547,7 @@
>
> thermal: thermal at e8078 {
> compatible = "marvell,armada380-thermal";
> - reg = <0xe4078 0x4>, <0xe4074 0x4>;
> + reg = <0xe4078 0x4>, <0xe4070 0x8>;
> status = "okay";
> };
>
> --
> 2.18.0
>
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Andreas Färber" <afaerber@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: armada-38x: use the new thermal binding
Date: Wed, 04 Jul 2018 15:29:37 +0200 [thread overview]
Message-ID: <87muv72kou.fsf@bootlin.com> (raw)
In-Reply-To: <fa45caea9ab04a515805e80b8c02a74a00a908e0.1530588260.git.baruch@tkos.co.il> (Baruch Siach's message of "Tue, 3 Jul 2018 06:24:20 +0300")
Hi Baruch,
On mar., juil. 03 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 2f28e4c24b10e (thermal: armada: Clarify control registers
> accesses) introduced the new thermal binding. The new binding extends
> the second registers field size to 8. Switch to the new binding to fix
> thermal reading values. Without this change the fix for errata #132698
> introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim
> default value) has no effect.
>
> Cc: stable@vger.kernel.org # v4.16+
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied on mvebu/fixes
Thanks,
Gregory
> ---
> v2:
> * Typo fixes (Andreas Färber)
> * Add Miquel's review tag
> * Minor wording changes
> * Cc stable
> ---
> arch/arm/boot/dts/armada-38x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index 18edc9bc7927..929459c42760 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -547,7 +547,7 @@
>
> thermal: thermal@e8078 {
> compatible = "marvell,armada380-thermal";
> - reg = <0xe4078 0x4>, <0xe4074 0x4>;
> + reg = <0xe4078 0x4>, <0xe4070 0x8>;
> status = "okay";
> };
>
> --
> 2.18.0
>
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-07-04 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 3:24 [PATCH v2] ARM: dts: armada-38x: use the new thermal binding Baruch Siach
2018-07-03 3:24 ` Baruch Siach
2018-07-04 13:29 ` Gregory CLEMENT [this message]
2018-07-04 13:29 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muv72kou.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.