From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Daniel Borkmann <daniel@iogearbox.net>, Jakub Kicinski <kubakici@wp.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example
Date: Tue, 05 Jun 2018 11:20:54 +0200 [thread overview]
Message-ID: <87muw9fv2h.fsf@toke.dk> (raw)
In-Reply-To: <1ef5fdfd-3225-89e2-c6b5-d3fe2573d655@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> writes:
> On 06/05/2018 12:32 AM, Jakub Kicinski wrote:
>> On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote:
>>> + if (load_bpf_file(filename)) {
>>
>> Would you mind using libbpf instead of bpf_load.o? I converted some
>> samples in be5bca44aa6b ("samples: bpf: convert some XDP samples from
>> bpf_load to libbpf"), it's pretty straight forward. Maybe we can kill
>> bpf_load.o one day :)
>
> Agreed, we should only be using libbpf going forward.
Right, I'll rework to load using libbpf instead.
next prev parent reply other threads:[~2018-06-05 9:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 16:33 [PATCH bpf-next v2 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events Toke Høiland-Jørgensen
2018-06-04 16:33 ` [PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example Toke Høiland-Jørgensen
2018-06-04 22:32 ` Jakub Kicinski
2018-06-04 23:43 ` Daniel Borkmann
2018-06-05 9:20 ` Toke Høiland-Jørgensen [this message]
2018-06-06 11:40 ` David Beckett
2018-06-06 12:28 ` Toke Høiland-Jørgensen
2018-06-04 22:26 ` [PATCH bpf-next v2 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events Jakub Kicinski
2018-06-04 23:42 ` Daniel Borkmann
2018-06-05 9:22 ` Toke Høiland-Jørgensen
2018-06-05 9:27 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muw9fv2h.fsf@toke.dk \
--to=toke@toke.dk \
--cc=daniel@iogearbox.net \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.