All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v6 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Thu, 12 Oct 2017 10:50:07 -0700	[thread overview]
Message-ID: <87mv4wmf1s.fsf@intel.com> (raw)
In-Reply-To: <1507771972.31614.41.camel@edumazet-glaptop3.roam.corp.google.com>

Hi,

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On Wed, 2017-10-11 at 17:54 -0700, Vinicius Costa Gomes wrote:
>> This queueing discipline implements the shaper algorithm defined by
>> the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L.
>
> ...
>
>> +static s64 delay_from_credits(s64 credits, s32 slope)
>> +{
>> +	s64 rate = slope * BYTES_PER_KBIT;
>> +
>> +	if (unlikely(rate == 0))
>> +		return S64_MAX;
>> +
>> +	return ((-credits * NSEC_PER_SEC) / rate);
>> +}
>
> Have you tried to compile this on 32bit arch ?
>
> make ARCH=i386

Will be fixed on v7.


Cheers,
--
Vinicius

WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	andre.guedes@intel.com, ivan.briano@intel.com,
	jesus.sanchez-palencia@intel.com, boon.leong.ong@intel.com,
	richardcochran@gmail.com, henrik@austad.us,
	levipearson@gmail.com, rodney.cummings@ni.com
Subject: Re: [next-queue PATCH v6 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Thu, 12 Oct 2017 10:50:07 -0700	[thread overview]
Message-ID: <87mv4wmf1s.fsf@intel.com> (raw)
In-Reply-To: <1507771972.31614.41.camel@edumazet-glaptop3.roam.corp.google.com>

Hi,

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On Wed, 2017-10-11 at 17:54 -0700, Vinicius Costa Gomes wrote:
>> This queueing discipline implements the shaper algorithm defined by
>> the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L.
>
> ...
>
>> +static s64 delay_from_credits(s64 credits, s32 slope)
>> +{
>> +	s64 rate = slope * BYTES_PER_KBIT;
>> +
>> +	if (unlikely(rate == 0))
>> +		return S64_MAX;
>> +
>> +	return ((-credits * NSEC_PER_SEC) / rate);
>> +}
>
> Have you tried to compile this on 32bit arch ?
>
> make ARCH=i386

Will be fixed on v7.


Cheers,

  reply	other threads:[~2017-10-12 17:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12  0:54 [Intel-wired-lan] [next-queue PATCH v6 0/5] TSN: Add qdisc based config interface for CBS Vinicius Costa Gomes
2017-10-12  0:54 ` Vinicius Costa Gomes
2017-10-12  0:54 ` [Intel-wired-lan] [next-queue PATCH v6 1/5] net/sched: Check for null dev_queue on create flow Vinicius Costa Gomes
2017-10-12  0:54   ` Vinicius Costa Gomes
2017-10-12  0:54 ` [Intel-wired-lan] [next-queue PATCH v6 2/5] mqprio: Implement select_queue class_ops Vinicius Costa Gomes
2017-10-12  0:54   ` Vinicius Costa Gomes
2017-10-12 15:21   ` [Intel-wired-lan] " Alexander Duyck
2017-10-12 15:21     ` Alexander Duyck
2017-10-12 15:59     ` Jesus Sanchez-Palencia
2017-10-12 15:59       ` Jesus Sanchez-Palencia
2017-10-12 16:09       ` Alexander Duyck
2017-10-12 16:09         ` Alexander Duyck
2017-10-12 16:16         ` Jesus Sanchez-Palencia
2017-10-12 16:16           ` Jesus Sanchez-Palencia
2017-10-12  0:54 ` [Intel-wired-lan] [next-queue PATCH v6 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-10-12  0:54   ` Vinicius Costa Gomes
2017-10-12  1:32   ` [Intel-wired-lan] " Eric Dumazet
2017-10-12  1:32     ` Eric Dumazet
2017-10-12 17:50     ` Vinicius Costa Gomes [this message]
2017-10-12 17:50       ` Vinicius Costa Gomes
2017-10-12  7:58   ` [Intel-wired-lan] " Henrik Austad
2017-10-12  7:58     ` Henrik Austad
2017-10-12 15:45     ` [Intel-wired-lan] " Jesus Sanchez-Palencia
2017-10-12 15:45       ` Jesus Sanchez-Palencia
2017-10-12  0:54 ` [Intel-wired-lan] [next-queue PATCH v6 4/5] net/sched: Add support for HW offloading for CBS Vinicius Costa Gomes
2017-10-12  0:54   ` Vinicius Costa Gomes
2017-10-12  8:04   ` [Intel-wired-lan] " Henrik Austad
2017-10-12  8:04     ` Henrik Austad
2017-10-12  0:54 ` [Intel-wired-lan] [next-queue PATCH v6 5/5] igb: Add support for CBS offload Vinicius Costa Gomes
2017-10-12  0:54   ` Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv4wmf1s.fsf@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.