Re: [PATCH] powerpc/perf/hv-24x7: Delete an error message for a failed memory allocation in create_e

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/perf/hv-24x7: Delete an error message for a failed memory allocation in create_e
Date: Thu, 05 Oct 2017 19:05:53 +0000	[thread overview]
Message-ID: <87mv555sa6.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <427d4a01-e0ec-9a52-46cb-685c43962a96@users.sourceforge.net>


Thanks, Markus.

SF Markus Elfring <elfring@users.sourceforge.net> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 5 Oct 2017 18:02:05 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/powerpc/perf/hv-24x7.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
> index 9c88b82f6229..f21f30aaf9bd 100644
> --- a/arch/powerpc/perf/hv-24x7.c
> +++ b/arch/powerpc/perf/hv-24x7.c
> @@ -766,7 +766,6 @@ static int create_events_from_catalog(struct attribute ***events_,
>  	 */
>  	event_data = vmalloc(event_data_bytes);
>  	if (!event_data) {
> -		pr_err("could not allocate event data\n");
>  		ret = -ENOMEM;
>  		goto e_free;
>  	}

Reviewed-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> 

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

WARNING: multiple messages have this Message-ID (diff)

From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/perf/hv-24x7: Delete an error message for a failed memory allocation in create_events_from_catalog()
Date: Thu, 05 Oct 2017 16:05:53 -0300	[thread overview]
Message-ID: <87mv555sa6.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <427d4a01-e0ec-9a52-46cb-685c43962a96@users.sourceforge.net>


Thanks, Markus.

SF Markus Elfring <elfring@users.sourceforge.net> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 5 Oct 2017 18:02:05 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/powerpc/perf/hv-24x7.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
> index 9c88b82f6229..f21f30aaf9bd 100644
> --- a/arch/powerpc/perf/hv-24x7.c
> +++ b/arch/powerpc/perf/hv-24x7.c
> @@ -766,7 +766,6 @@ static int create_events_from_catalog(struct attribute ***events_,
>  	 */
>  	event_data = vmalloc(event_data_bytes);
>  	if (!event_data) {
> -		pr_err("could not allocate event data\n");
>  		ret = -ENOMEM;
>  		goto e_free;
>  	}

Reviewed-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> 

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

next prev parent reply	other threads:[~2017-10-05 19:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 16:08 [PATCH] powerpc/perf/hv-24x7: Delete an error message for a failed memory allocation in create_event SF Markus Elfring
2017-10-05 16:08 ` [PATCH] powerpc/perf/hv-24x7: Delete an error message for a failed memory allocation in create_events_from_catalog() SF Markus Elfring
2017-10-05 19:05 ` Thiago Jung Bauermann [this message]
2017-10-05 19:05   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv555sa6.fsf@linux.vnet.ibm.com \
    --to=bauerman@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.