* [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message"
@ 2017-05-17 13:15 Daniel Vetter
2017-05-17 13:22 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-05-17 13:15 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Daniel Vetter, Gabriel Krisman Bertazi, Jani Nikula, Chris Wilson,
# v4 . 11+, Daniel Vetter
This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
Gabriel put this back into generic code with
commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
Author: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Date: Wed Dec 28 12:32:11 2016 -0200
drm: Deduplicate driver initialization message
but somehow he missed Chris' patch to add the message meanwhile.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101025
Fixes: 75f6dfe3e652 ("drm: Deduplicate driver initialization message")
Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: <stable@vger.kernel.org> # v4.11+
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index b0c003498b6b..6052798bb626 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1286,10 +1286,6 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
dev_priv->ipc_enabled = false;
- /* Everything is in place, we can now relax! */
- DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
- driver.name, driver.major, driver.minor, driver.patchlevel,
- driver.date, pci_name(pdev), dev_priv->drm.primary->index);
if (IS_ENABLED(CONFIG_DRM_I915_DEBUG))
DRM_INFO("DRM_I915_DEBUG enabled\n");
if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message"
2017-05-17 13:15 [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message" Daniel Vetter
@ 2017-05-17 13:22 ` Chris Wilson
2017-05-17 14:12 ` Gabriel Krisman Bertazi
2017-05-17 14:54 ` ✓ Fi.CI.BAT: success for " Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2017-05-17 13:22 UTC (permalink / raw)
To: Daniel Vetter; +Cc: # v4 . 11+, Intel Graphics Development, Daniel Vetter
On Wed, May 17, 2017 at 03:15:57PM +0200, Daniel Vetter wrote:
> This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
>
> Gabriel put this back into generic code with
>
> commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
> Author: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Date: Wed Dec 28 12:32:11 2016 -0200
>
> drm: Deduplicate driver initialization message
>
> but somehow he missed Chris' patch to add the message meanwhile.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101025
> Fixes: 75f6dfe3e652 ("drm: Deduplicate driver initialization message")
> Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: <stable@vger.kernel.org> # v4.11+
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
/me waves goodbye to amusing comment.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message"
@ 2017-05-17 13:22 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2017-05-17 13:22 UTC (permalink / raw)
To: Daniel Vetter
Cc: Intel Graphics Development, Gabriel Krisman Bertazi, Jani Nikula,
# v4 . 11+, Daniel Vetter
On Wed, May 17, 2017 at 03:15:57PM +0200, Daniel Vetter wrote:
> This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
>
> Gabriel put this back into generic code with
>
> commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
> Author: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Date: Wed Dec 28 12:32:11 2016 -0200
>
> drm: Deduplicate driver initialization message
>
> but somehow he missed Chris' patch to add the message meanwhile.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101025
> Fixes: 75f6dfe3e652 ("drm: Deduplicate driver initialization message")
> Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: <stable@vger.kernel.org> # v4.11+
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
/me waves goodbye to amusing comment.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message"
2017-05-17 13:15 [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message" Daniel Vetter
@ 2017-05-17 14:12 ` Gabriel Krisman Bertazi
2017-05-17 14:12 ` Gabriel Krisman Bertazi
2017-05-17 14:54 ` ✓ Fi.CI.BAT: success for " Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Gabriel Krisman Bertazi @ 2017-05-17 14:12 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development, # v4 . 11+
Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
>
> Gabriel put this back into generic code with
>
> commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
> Author: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Date: Wed Dec 28 12:32:11 2016 -0200
>
> drm: Deduplicate driver initialization message
>
> but somehow he missed Chris' patch to add the message meanwhile.
Hmmm. In the commit message, I even mentioned that i915 was an exception because it
used its own registration handle, so I'm pretty sure I didn't miss that
commit. Not that this is supposed to make it any better... what the
heck happened back then?? :(
This is
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
--
Gabriel Krisman Bertazi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message"
@ 2017-05-17 14:12 ` Gabriel Krisman Bertazi
0 siblings, 0 replies; 7+ messages in thread
From: Gabriel Krisman Bertazi @ 2017-05-17 14:12 UTC (permalink / raw)
To: Daniel Vetter
Cc: Intel Graphics Development, Jani Nikula, Chris Wilson, # v4 . 11+,
Daniel Vetter
Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
>
> Gabriel put this back into generic code with
>
> commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
> Author: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Date: Wed Dec 28 12:32:11 2016 -0200
>
> drm: Deduplicate driver initialization message
>
> but somehow he missed Chris' patch to add the message meanwhile.
Hmmm. In the commit message, I even mentioned that i915 was an exception because it
used its own registration handle, so I'm pretty sure I didn't miss that
commit. Not that this is supposed to make it any better... what the
heck happened back then?? :(
This is
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for Revert "drm/i915: Restore lost "Initialized i915" welcome message"
2017-05-17 13:15 [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message" Daniel Vetter
2017-05-17 13:22 ` Chris Wilson
2017-05-17 14:12 ` Gabriel Krisman Bertazi
@ 2017-05-17 14:54 ` Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-05-17 14:54 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: Revert "drm/i915: Restore lost "Initialized i915" welcome message"
URL : https://patchwork.freedesktop.org/series/24563/
State : success
== Summary ==
Series 24563v1 Revert "drm/i915: Restore lost "Initialized i915" welcome message"
https://patchwork.freedesktop.org/api/1.0/series/24563/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-snb-2600) fdo#100125
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:445s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:590s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:513s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:497s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:491s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:419s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:416s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:499s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:469s
fi-kbl-7500u total:278 pass:255 dwarn:5 dfail:0 fail:0 skip:18 time:462s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:462s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time:584s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:467s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:498s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:541s
fi-snb-2600 total:278 pass:247 dwarn:1 dfail:0 fail:1 skip:29 time:404s
eb3549d312620118dec3a69200894ac8a8fff358 drm-tip: 2017y-05m-17d-13h-53m-40s UTC integration manifest
372b5ed Revert "drm/i915: Restore lost "Initialized i915" welcome message"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4725/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message"
2017-05-17 14:12 ` Gabriel Krisman Bertazi
(?)
@ 2017-05-22 8:56 ` Daniel Vetter
-1 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-05-22 8:56 UTC (permalink / raw)
To: Gabriel Krisman Bertazi
Cc: Daniel Vetter, Intel Graphics Development, Jani Nikula,
Chris Wilson, # v4 . 11+, Daniel Vetter
On Wed, May 17, 2017 at 11:12:28AM -0300, Gabriel Krisman Bertazi wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
>
> > This reverts commit bc5ca47c0af4f949ba889e666b7da65569e36093.
> >
> > Gabriel put this back into generic code with
> >
> > commit 75f6dfe3e652e1adef8cc1b073c89f3e22103a8f
> > Author: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> > Date: Wed Dec 28 12:32:11 2016 -0200
> >
> > drm: Deduplicate driver initialization message
> >
> > but somehow he missed Chris' patch to add the message meanwhile.
>
> Hmmm. In the commit message, I even mentioned that i915 was an exception because it
> used its own registration handle, so I'm pretty sure I didn't miss that
> commit. Not that this is supposed to make it any better... what the
> heck happened back then?? :(
>
> This is
>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Applied, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-05-22 8:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-17 13:15 [PATCH] Revert "drm/i915: Restore lost "Initialized i915" welcome message" Daniel Vetter
2017-05-17 13:22 ` Chris Wilson
2017-05-17 13:22 ` Chris Wilson
2017-05-17 14:12 ` Gabriel Krisman Bertazi
2017-05-17 14:12 ` Gabriel Krisman Bertazi
2017-05-22 8:56 ` Daniel Vetter
2017-05-17 14:54 ` ✓ Fi.CI.BAT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.