From: "Alex Bennée" <alex.bennee@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Igor Mitsyanko <i.mitsyanko@gmail.com>
Subject: Re: [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue
Date: Tue, 14 Mar 2017 16:55:34 +0000 [thread overview]
Message-ID: <87mvcnpzll.fsf@linaro.org> (raw)
In-Reply-To: <20170313180432.7067-1-krzk@kernel.org>
Krzysztof Kozlowski <krzk@kernel.org> writes:
> Hi,
>
<snip>
>
> Overview of the problem
> =======================
> On Exynos4210, by default Linux kernel uses cpuidle driver which tries
> to enter low power mode, called AFTR (Arm Off, Top Running). On real
> hardware this brings some power savings. This AFTR mode requires second
> CPU to be off, so the driver (coupled cpuidle driver) when system is idle:
> 1. Turns off second CPU,
> 2. Enters AFTR on CPU0.
>
> However the QEMU system is then totally unresponsive (e.g. on serial console)
> and RCU stalls appear from time to time. I spent some time on it and did not
> find the real cause behind the lag. Maybe it is because the second CPU
> does not really power down itself and system just burns the cycles under spin
> locks?
Was this tested post the MTTCG merge? Maybe there is an interaction
between power saving/halting the vCPU?
I mention this because I already made some minor tweaks for handing the
WFI instruction in MTTCG. See commit c22edfebff. You can test this by
forcing the original behaviour by adding:
-accel tcg,thread=single
to your command line.
>
> Looking at recent stable kernels:
> - 3.10, 3.16 - works fine with two CPUs (no CPUIDLE driver),
> - 4.1 and newer - stalls and are unresponsive due to CPUIDLE being enabled.
>
> The cpuidle driver is not relying on DTS. It is just enabled in exynos_defconfig
> and works.
>
> Workarounds
> ===========
> 1. Boot with only 1 cpu
> 2. Build a kernel with disabled CONFIG_CPU_IDLE
>
>
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (5):
> hw/intc/exynos4210_gic: Fix GIC memory mappings for secondary CPU
> hw/intc/exynos4210_gic: Use more meaningful name for local variable
> hw/timer/exynos4210_mct: Fix checkpatch style errors
> hw/timer/exynos4210_mct: Cleanup indentation and empty new lines
> hw/timer/exynos4210_mct: Remove unused defines
>
> hw/intc/exynos4210_gic.c | 33 +++++++++++++++++++------------
> hw/timer/exynos4210_mct.c | 50 ++++++++++++++++++++---------------------------
> 2 files changed, 41 insertions(+), 42 deletions(-)
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Igor Mitsyanko <i.mitsyanko@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue
Date: Tue, 14 Mar 2017 16:55:34 +0000 [thread overview]
Message-ID: <87mvcnpzll.fsf@linaro.org> (raw)
In-Reply-To: <20170313180432.7067-1-krzk@kernel.org>
Krzysztof Kozlowski <krzk@kernel.org> writes:
> Hi,
>
<snip>
>
> Overview of the problem
> =======================
> On Exynos4210, by default Linux kernel uses cpuidle driver which tries
> to enter low power mode, called AFTR (Arm Off, Top Running). On real
> hardware this brings some power savings. This AFTR mode requires second
> CPU to be off, so the driver (coupled cpuidle driver) when system is idle:
> 1. Turns off second CPU,
> 2. Enters AFTR on CPU0.
>
> However the QEMU system is then totally unresponsive (e.g. on serial console)
> and RCU stalls appear from time to time. I spent some time on it and did not
> find the real cause behind the lag. Maybe it is because the second CPU
> does not really power down itself and system just burns the cycles under spin
> locks?
Was this tested post the MTTCG merge? Maybe there is an interaction
between power saving/halting the vCPU?
I mention this because I already made some minor tweaks for handing the
WFI instruction in MTTCG. See commit c22edfebff. You can test this by
forcing the original behaviour by adding:
-accel tcg,thread=single
to your command line.
>
> Looking at recent stable kernels:
> - 3.10, 3.16 - works fine with two CPUs (no CPUIDLE driver),
> - 4.1 and newer - stalls and are unresponsive due to CPUIDLE being enabled.
>
> The cpuidle driver is not relying on DTS. It is just enabled in exynos_defconfig
> and works.
>
> Workarounds
> ===========
> 1. Boot with only 1 cpu
> 2. Build a kernel with disabled CONFIG_CPU_IDLE
>
>
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (5):
> hw/intc/exynos4210_gic: Fix GIC memory mappings for secondary CPU
> hw/intc/exynos4210_gic: Use more meaningful name for local variable
> hw/timer/exynos4210_mct: Fix checkpatch style errors
> hw/timer/exynos4210_mct: Cleanup indentation and empty new lines
> hw/timer/exynos4210_mct: Remove unused defines
>
> hw/intc/exynos4210_gic.c | 33 +++++++++++++++++++------------
> hw/timer/exynos4210_mct.c | 50 ++++++++++++++++++++---------------------------
> 2 files changed, 41 insertions(+), 42 deletions(-)
--
Alex Bennée
next prev parent reply other threads:[~2017-03-14 16:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 18:04 [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-arm] [PATCH v2 1/5] hw/intc/exynos4210_gic: Fix GIC memory mappings for secondary CPU Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-13 19:32 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-03-13 19:32 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-05-07 10:55 ` Krzysztof Kozlowski
2017-05-07 10:55 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-arm] [PATCH v2 2/5] hw/intc/exynos4210_gic: Use more meaningful name for local variable Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-13 19:30 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-03-13 19:30 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-03-13 18:04 ` [Qemu-arm] [PATCH v2 3/5] hw/timer/exynos4210_mct: Fix checkpatch style errors Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-13 19:31 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-03-13 19:31 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-03-13 18:04 ` [Qemu-arm] [PATCH v2 4/5] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-13 19:32 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-03-13 18:04 ` [Qemu-arm] [PATCH v2 5/5] hw/timer/exynos4210_mct: Remove unused defines Krzysztof Kozlowski
2017-03-13 18:04 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-14 16:55 ` Alex Bennée [this message]
2017-03-14 16:55 ` [Qemu-devel] [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue Alex Bennée
2017-03-14 17:35 ` Krzysztof Kozlowski
2017-03-14 17:35 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-14 18:24 ` Alex Bennée
2017-03-14 18:24 ` [Qemu-devel] " Alex Bennée
2017-03-14 18:56 ` Krzysztof Kozlowski
2017-03-14 18:56 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-15 8:05 ` Alex Bennée
2017-03-15 8:05 ` [Qemu-devel] " Alex Bennée
2017-03-15 16:47 ` Krzysztof Kozlowski
2017-03-15 16:47 ` [Qemu-devel] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvcnpzll.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=i.mitsyanko@gmail.com \
--cc=krzk@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.