* [PATCH] drm/i915: Fix eDP low vswing for Broadwell
@ 2016-03-16 8:32 Mika Kahola
2016-03-16 9:49 ` Jani Nikula
2016-03-16 12:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Mika Kahola @ 2016-03-16 8:32 UTC (permalink / raw)
To: intel-gfx
It was noticed on bug #94087 that module parameter
i915.edp_vswing=2 that should override the VBT setting
to use default voltage swing (400 mV) was not applied
for Broadwell.
This patch provides a fix for this by checking if default
i.e. higher voltage swing is requested to be used and
applies the DDI translations table for DP instead of eDP
(low vswing) table.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index ab025a5..e30adcd 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -443,9 +443,19 @@ void intel_prepare_ddi_buffer(struct intel_encoder *encoder)
} else if (IS_BROADWELL(dev_priv)) {
ddi_translations_fdi = bdw_ddi_translations_fdi;
ddi_translations_dp = bdw_ddi_translations_dp;
- ddi_translations_edp = bdw_ddi_translations_edp;
+
+ if (dev_priv->edp_low_vswing)
+ ddi_translations_edp = bdw_ddi_translations_edp;
+ else
+ ddi_translations_edp = bdw_ddi_translations_dp;
+
ddi_translations_hdmi = bdw_ddi_translations_hdmi;
- n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
+
+ if (dev_priv->edp_low_vswing)
+ n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
+ else
+ n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
+
n_dp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
n_hdmi_entries = ARRAY_SIZE(bdw_ddi_translations_hdmi);
hdmi_default_entry = 7;
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Fix eDP low vswing for Broadwell
2016-03-16 8:32 [PATCH] drm/i915: Fix eDP low vswing for Broadwell Mika Kahola
@ 2016-03-16 9:49 ` Jani Nikula
2016-03-16 10:47 ` Mika Kahola
2016-03-16 12:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2016-03-16 9:49 UTC (permalink / raw)
To: Mika Kahola, intel-gfx
On Wed, 16 Mar 2016, Mika Kahola <mika.kahola@intel.com> wrote:
> [ text/plain ]
> It was noticed on bug #94087 that module parameter
> i915.edp_vswing=2 that should override the VBT setting
> to use default voltage swing (400 mV) was not applied
> for Broadwell.
>
> This patch provides a fix for this by checking if default
> i.e. higher voltage swing is requested to be used and
> applies the DDI translations table for DP instead of eDP
> (low vswing) table.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
cc: stable?
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index ab025a5..e30adcd 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -443,9 +443,19 @@ void intel_prepare_ddi_buffer(struct intel_encoder *encoder)
> } else if (IS_BROADWELL(dev_priv)) {
> ddi_translations_fdi = bdw_ddi_translations_fdi;
> ddi_translations_dp = bdw_ddi_translations_dp;
> - ddi_translations_edp = bdw_ddi_translations_edp;
> +
> + if (dev_priv->edp_low_vswing)
> + ddi_translations_edp = bdw_ddi_translations_edp;
> + else
> + ddi_translations_edp = bdw_ddi_translations_dp;
> +
> ddi_translations_hdmi = bdw_ddi_translations_hdmi;
> - n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
> +
> + if (dev_priv->edp_low_vswing)
> + n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
> + else
> + n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
> +
Please just put these in one if statement above, instead of having two.
BR,
Jani.
> n_dp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
> n_hdmi_entries = ARRAY_SIZE(bdw_ddi_translations_hdmi);
> hdmi_default_entry = 7;
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Fix eDP low vswing for Broadwell
2016-03-16 9:49 ` Jani Nikula
@ 2016-03-16 10:47 ` Mika Kahola
0 siblings, 0 replies; 4+ messages in thread
From: Mika Kahola @ 2016-03-16 10:47 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, 2016-03-16 at 11:49 +0200, Jani Nikula wrote:
> On Wed, 16 Mar 2016, Mika Kahola <mika.kahola@intel.com> wrote:
> > [ text/plain ]
> > It was noticed on bug #94087 that module parameter
> > i915.edp_vswing=2 that should override the VBT setting
> > to use default voltage swing (400 mV) was not applied
> > for Broadwell.
> >
> > This patch provides a fix for this by checking if default
> > i.e. higher voltage swing is requested to be used and
> > applies the DDI translations table for DP instead of eDP
> > (low vswing) table.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>
> cc: stable?
>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index ab025a5..e30adcd 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -443,9 +443,19 @@ void intel_prepare_ddi_buffer(struct intel_encoder *encoder)
> > } else if (IS_BROADWELL(dev_priv)) {
> > ddi_translations_fdi = bdw_ddi_translations_fdi;
> > ddi_translations_dp = bdw_ddi_translations_dp;
> > - ddi_translations_edp = bdw_ddi_translations_edp;
> > +
> > + if (dev_priv->edp_low_vswing)
> > + ddi_translations_edp = bdw_ddi_translations_edp;
> > + else
> > + ddi_translations_edp = bdw_ddi_translations_dp;
> > +
> > ddi_translations_hdmi = bdw_ddi_translations_hdmi;
> > - n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
> > +
> > + if (dev_priv->edp_low_vswing)
> > + n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
> > + else
> > + n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
> > +
>
> Please just put these in one if statement above, instead of having two.
>
Ok, I'll fix those if statements. I'll throw a second version for a
review.
Cheers,
Mika
> BR,
> Jani.
>
> > n_dp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
> > n_hdmi_entries = ARRAY_SIZE(bdw_ddi_translations_hdmi);
> > hdmi_default_entry = 7;
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Fix eDP low vswing for Broadwell
2016-03-16 8:32 [PATCH] drm/i915: Fix eDP low vswing for Broadwell Mika Kahola
2016-03-16 9:49 ` Jani Nikula
@ 2016-03-16 12:23 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-03-16 12:23 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix eDP low vswing for Broadwell
URL : https://patchwork.freedesktop.org/series/4499/
State : failure
== Summary ==
Series 4499v1 drm/i915: Fix eDP low vswing for Broadwell
http://patchwork.freedesktop.org/api/1.0/series/4499/revisions/1/mbox/
Test drv_module_reload_basic:
pass -> SKIP (bdw-ultra)
Test gem_mmap_gtt:
Subgroup basic-small-copy:
dmesg-warn -> PASS (bsw-nuc-2)
Test gem_ringfill:
Subgroup basic-default-s3:
dmesg-warn -> PASS (skl-i5k-2)
pass -> DMESG-WARN (bsw-nuc-2)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
pass -> DMESG-WARN (hsw-gt2)
dmesg-warn -> PASS (hsw-brixbox)
Test kms_force_connector_basic:
Subgroup force-connector-state:
pass -> SKIP (ivb-t430s)
Subgroup force-edid:
pass -> SKIP (ivb-t430s)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-a:
dmesg-warn -> PASS (bdw-nuci7)
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (hsw-gt2)
Test pm_rpm:
Subgroup basic-pci-d3-state:
fail -> DMESG-FAIL (snb-x220t)
pass -> DMESG-WARN (hsw-brixbox)
dmesg-warn -> PASS (bsw-nuc-2)
bdw-nuci7 total:194 pass:182 dwarn:0 dfail:0 fail:0 skip:12
bdw-ultra total:194 pass:172 dwarn:0 dfail:0 fail:0 skip:22
bsw-nuc-2 total:194 pass:156 dwarn:1 dfail:0 fail:0 skip:37
byt-nuc total:194 pass:155 dwarn:4 dfail:0 fail:0 skip:35
hsw-brixbox total:194 pass:171 dwarn:1 dfail:0 fail:0 skip:22
hsw-gt2 total:74 pass:66 dwarn:1 dfail:0 fail:0 skip:6
ivb-t430s total:194 pass:167 dwarn:0 dfail:0 fail:0 skip:27
skl-i5k-2 total:194 pass:171 dwarn:0 dfail:0 fail:0 skip:23
skl-i7k-2 total:194 pass:171 dwarn:0 dfail:0 fail:0 skip:23
skl-nuci5 total:194 pass:183 dwarn:0 dfail:0 fail:0 skip:11
snb-x220t total:194 pass:159 dwarn:1 dfail:1 fail:0 skip:33
Results at /archive/results/CI_IGT_test/Patchwork_1612/
9f8709ffd099e85e5e116ed7d09f1b8009f40847 drm-intel-nightly: 2016y-03m-16d-10h-30m-26s UTC integration manifest
e141f3750e10c3e21c12ba3649cd5c64f696e9ce drm/i915: Fix eDP low vswing for Broadwell
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-16 12:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 8:32 [PATCH] drm/i915: Fix eDP low vswing for Broadwell Mika Kahola
2016-03-16 9:49 ` Jani Nikula
2016-03-16 10:47 ` Mika Kahola
2016-03-16 12:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.