From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.
Date: Fri, 04 Mar 2016 11:39:06 -0800 [thread overview]
Message-ID: <87mvqeowx1.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20160304185923.GC5033@leverpostej>
Mark Rutland <mark.rutland@arm.com> writes:
> On Fri, Mar 04, 2016 at 10:55:03AM -0800, Eric Anholt wrote:
>> Mark Rutland <mark.rutland@arm.com> writes:
>>
>> > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote:
>> >> For now this doesn't support the new hardware present on the Pi 3 (BT,
>> >> wifi, GPIO expander). Since the GPIO expander isn't supported, we
>> >> also don't have the LEDs like the other board files do.
>> >>
>> >> Signed-off-by: Eric Anholt <eric@anholt.net>
>> >> ---
>> >> arch/arm/boot/dts/Makefile | 3 +-
>> >> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 22 ++++++++++++
>> >> arch/arm/boot/dts/bcm2837.dtsi | 68 +++++++++++++++++++++++++++++++++++
>> >> 3 files changed, 92 insertions(+), 1 deletion(-)
>> >> create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> >> create mode 100644 arch/arm/boot/dts/bcm2837.dtsi
>> >
>> >> + timer {
>> >> + compatible = "arm,armv7-timer";
>> >> + interrupt-parent = <&local_intc>;
>> >> + interrupts = <0>, // PHYS_SECURE_PPI
>> >> + <1>, // PHYS_NONSECURE_PPI
>> >> + <3>, // VIRT_PPI
>> >> + <2>; // HYP_PPI
>> >> + always-on;
>> >> + };
>> >
>> > Are the CPUs in an always-on power domain? Or is it jsut that the kernel
>> > doesn't perform power management of CPUs?
>> >
>> > The always-on proeprty is only intended for the former.
>>
>> The kernel doesn't get to do power management of CPUs. We only have
>> control of power domains through the firmware, and the firmware's
>> keeping the CPU domain on.
>
> So there is no way that the CPUs could request for the firmare to place
> them in a state where the timer would lose context (but other events
> coukd wake them up), even if they don't do that today?
I don't see any mechanism in the RPi firmware for the ARM to request
suspend or anything like that. Enabling something like that would
definitely require an updated DT, to enable a driver that talks to the
firmware to make requests like that.
(Note that this is the same timer setup we have in bcm2836.dtsi)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160304/5187fc94/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.
Date: Fri, 04 Mar 2016 11:39:06 -0800 [thread overview]
Message-ID: <87mvqeowx1.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20160304185923.GC5033@leverpostej>
[-- Attachment #1: Type: text/plain, Size: 2105 bytes --]
Mark Rutland <mark.rutland@arm.com> writes:
> On Fri, Mar 04, 2016 at 10:55:03AM -0800, Eric Anholt wrote:
>> Mark Rutland <mark.rutland@arm.com> writes:
>>
>> > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote:
>> >> For now this doesn't support the new hardware present on the Pi 3 (BT,
>> >> wifi, GPIO expander). Since the GPIO expander isn't supported, we
>> >> also don't have the LEDs like the other board files do.
>> >>
>> >> Signed-off-by: Eric Anholt <eric@anholt.net>
>> >> ---
>> >> arch/arm/boot/dts/Makefile | 3 +-
>> >> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 22 ++++++++++++
>> >> arch/arm/boot/dts/bcm2837.dtsi | 68 +++++++++++++++++++++++++++++++++++
>> >> 3 files changed, 92 insertions(+), 1 deletion(-)
>> >> create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> >> create mode 100644 arch/arm/boot/dts/bcm2837.dtsi
>> >
>> >> + timer {
>> >> + compatible = "arm,armv7-timer";
>> >> + interrupt-parent = <&local_intc>;
>> >> + interrupts = <0>, // PHYS_SECURE_PPI
>> >> + <1>, // PHYS_NONSECURE_PPI
>> >> + <3>, // VIRT_PPI
>> >> + <2>; // HYP_PPI
>> >> + always-on;
>> >> + };
>> >
>> > Are the CPUs in an always-on power domain? Or is it jsut that the kernel
>> > doesn't perform power management of CPUs?
>> >
>> > The always-on proeprty is only intended for the former.
>>
>> The kernel doesn't get to do power management of CPUs. We only have
>> control of power domains through the firmware, and the firmware's
>> keeping the CPU domain on.
>
> So there is no way that the CPUs could request for the firmare to place
> them in a state where the timer would lose context (but other events
> coukd wake them up), even if they don't do that today?
I don't see any mechanism in the RPi firmware for the ARM to request
suspend or anything like that. Enabling something like that would
definitely require an updated DT, to enable a driver that talks to the
firmware to make requests like that.
(Note that this is the same timer setup we have in bcm2836.dtsi)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-03-04 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 18:39 [PATCH 1/2] dt-bindings: Add root properties for Raspberry Pi 3 Eric Anholt
2016-03-04 18:39 ` Eric Anholt
2016-03-04 18:39 ` Eric Anholt
2016-03-04 18:39 ` [PATCH 2/2] ARM: bcm2835: Add devicetree for the " Eric Anholt
2016-03-04 18:39 ` Eric Anholt
2016-03-04 18:39 ` Eric Anholt
2016-03-04 18:41 ` Mark Rutland
2016-03-04 18:41 ` Mark Rutland
2016-03-04 18:55 ` Eric Anholt
2016-03-04 18:55 ` Eric Anholt
2016-03-04 18:55 ` Eric Anholt
2016-03-04 18:59 ` Mark Rutland
2016-03-04 18:59 ` Mark Rutland
2016-03-04 18:59 ` Mark Rutland
2016-03-04 19:39 ` Eric Anholt [this message]
2016-03-04 19:39 ` Eric Anholt
2016-03-08 5:54 ` Stephen Warren
2016-03-08 5:54 ` Stephen Warren
2016-03-17 11:53 ` [PATCH 1/2] dt-bindings: Add root properties for " Rob Herring
2016-03-17 11:53 ` Rob Herring
2016-03-17 11:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvqeowx1.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.