From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Joe Perches <joe@perches.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] mtd: docg3: drop dead code
Date: Mon, 02 Mar 2015 21:39:42 +0000 [thread overview]
Message-ID: <87mw3v13kx.fsf@free.fr> (raw)
In-Reply-To: <20150302091050.GC5386@mwanda> (Dan Carpenter's message of "Mon, 2 Mar 2015 12:10:50 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Sat, Feb 28, 2015 at 02:02:24AM -0800, Brian Norris wrote:
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 448ce42f951e..01eddea1f0d9 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -2079,8 +2079,6 @@ static int __init docg3_probe(struct platform_device *pdev)
>> ret = doc_register_sysfs(pdev, cascade);
>> if (ret)
>> goto err_probe;
>> - if (!found)
>> - goto notfound;
>
> Just delete the "found" variable because there are no other uses.
Yes, and yes.
For both changes (condition killing, found++ eradication and found variable
declaration) :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Joe Perches <joe@perches.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] mtd: docg3: drop dead code
Date: Mon, 02 Mar 2015 22:39:42 +0100 [thread overview]
Message-ID: <87mw3v13kx.fsf@free.fr> (raw)
In-Reply-To: <20150302091050.GC5386@mwanda> (Dan Carpenter's message of "Mon, 2 Mar 2015 12:10:50 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Sat, Feb 28, 2015 at 02:02:24AM -0800, Brian Norris wrote:
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 448ce42f951e..01eddea1f0d9 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -2079,8 +2079,6 @@ static int __init docg3_probe(struct platform_device *pdev)
>> ret = doc_register_sysfs(pdev, cascade);
>> if (ret)
>> goto err_probe;
>> - if (!found)
>> - goto notfound;
>
> Just delete the "found" variable because there are no other uses.
Yes, and yes.
For both changes (condition killing, found++ eradication and found variable
declaration) :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] mtd: docg3: drop dead code
Date: Mon, 02 Mar 2015 22:39:42 +0100 [thread overview]
Message-ID: <87mw3v13kx.fsf@free.fr> (raw)
In-Reply-To: <20150302091050.GC5386@mwanda> (Dan Carpenter's message of "Mon, 2 Mar 2015 12:10:50 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Sat, Feb 28, 2015 at 02:02:24AM -0800, Brian Norris wrote:
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 448ce42f951e..01eddea1f0d9 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -2079,8 +2079,6 @@ static int __init docg3_probe(struct platform_device *pdev)
>> ret = doc_register_sysfs(pdev, cascade);
>> if (ret)
>> goto err_probe;
>> - if (!found)
>> - goto notfound;
>
> Just delete the "found" variable because there are no other uses.
Yes, and yes.
For both changes (condition killing, found++ eradication and found variable
declaration) :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
next prev parent reply other threads:[~2015-03-02 21:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 10:02 [PATCH 0/7] mtd: various fixes caught by Coverity Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` [PATCH 1/7] mtd: docg3: drop dead code Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-03-02 9:10 ` Dan Carpenter
2015-03-02 9:10 ` Dan Carpenter
2015-03-02 9:10 ` Dan Carpenter
2015-03-02 21:39 ` Robert Jarzmik [this message]
2015-03-02 21:39 ` Robert Jarzmik
2015-03-02 21:39 ` Robert Jarzmik
2015-03-09 17:18 ` [PATCH v2 " Brian Norris
2015-03-09 17:18 ` Brian Norris
2015-03-09 17:18 ` Brian Norris
2015-02-28 10:02 ` [PATCH 2/7] mtd: onenand: " Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` [PATCH 3/7] mtd: tests: fix more potential integer overflows Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` [PATCH 4/7] mtd: nand: fixup bounds checks for nand_{lock,unlock}() Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` [PATCH 5/7] mtd: nand: denali: drop dead code Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` [PATCH 6/7] mtd: blkdevs: remove " Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` [PATCH 7/7] mtd: nand: fully initialize mtd_oob_ops Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-02-28 10:02 ` Brian Norris
2015-03-11 23:46 ` [PATCH 0/7] mtd: various fixes caught by Coverity Brian Norris
2015-03-11 23:46 ` Brian Norris
2015-03-11 23:46 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw3v13kx.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=computersforpeace@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.