Re: [PATCH] add --bsopts flag, pass to bs_init()

[Hitoshi Mitake <mitake.hitoshi@gmail.com>]

At Thu, 17 Oct 2013 19:00:59 -0700,
Dan Mick wrote:
> 
> ping

I'd like to +1 this patch. It will be benefit of all backing stores.

Thanks,
Hitoshi

> 
> On 10/11/2013 05:54 PM, Dan Mick wrote:
> > This patch implements the generic mechanism of passing backing-store-
> > specific options to the backing store module's bs_init entry point.
> > Each backing-store module gets a new parameter, char *bsopts,
> > added to its bs_init.
> >
> > No semantics or even syntax are imposed on the option string, other
> > than that commas are not permitted, because tgtadm communicates to
> > tgtd using a block of key=val,key=val,key=val options, and there's
> > no provision for escaping commas.
> >
> > tgtadm.8 is updated as well
> >
> > Dan Mick (1):
> >    Add bsopts flag
> >
> >   doc/tgtadm.8.xml  |   20 +++++++++++++++++---
> >   scripts/tgt-admin |   13 ++++++++++++-
> >   usr/bs_aio.c      |    2 +-
> >   usr/bs_rbd.c      |    3 ++-
> >   usr/bs_rdwr.c     |    2 +-
> >   usr/bs_sg.c       |    2 +-
> >   usr/bs_sheepdog.c |    2 +-
> >   usr/bs_ssc.c      |    2 +-
> >   usr/spc.c         |    3 ++-
> >   usr/target.c      |   12 +++++++++---
> >   usr/tgtadm.c      |   18 +++++++++++++-----
> >   usr/tgtd.h        |    2 +-
> >   12 files changed, 61 insertions(+), 20 deletions(-)
> >
> --
> To unsubscribe from this list: send the line "unsubscribe stgt" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html