[Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012

[Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012

[Stefan Hajnoczi]

The last pull request for QEMU 1.2!

The following changes since commit 03834e22abafbc8dc4052d46a5ccd6dd135a54a3:

  Merge remote-tracking branch 'origin/master' into staging (2012-08-14 15:19:50 -0500)

are available in the git repository at:

  git://github.com/stefanha/qemu.git trivial-patches

for you to fetch changes up to c3594ed73e0a7e7feae309be79f0eb6bafcc02ab:

  ivshmem, qdev-monitor: fix order of qerror parameters (2012-08-15 15:37:08 +0100)

----------------------------------------------------------------
Alberto Garcia (1):
      ivshmem, qdev-monitor: fix order of qerror parameters

Alejandro Martinez Ruiz (1):
      ehci: fix assertion typo

Peter Maydell (3):
      Makefile: Avoid explicit list of directories in clean target
      cputlb.c: Fix out of date comment
      iov_send_recv(): Handle zero bytes case even if OS does not

Stefan Weil (4):
      trace: Fix "Qemu" -> "QEMU"
      docs: Fix spelling (propery -> property)
      Spelling fix in comment (peripherans -> peripherals)
      framebuffer: Fix spelling in comment (leight -> height)

 Makefile               |    7 ++-----
 cputlb.c               |    4 +++-
 docs/bootindex.txt     |    2 +-
 hw/framebuffer.c       |    2 +-
 hw/ivshmem.c           |    3 ++-
 hw/qdev-monitor.c      |    2 +-
 hw/usb/hcd-ehci.c      |    2 +-
 hw/versatilepb.c       |    2 +-
 iov.c                  |    7 +++++++
 scripts/simpletrace.py |    2 +-
 10 files changed, 20 insertions(+), 13 deletions(-)

-- 
1.7.10.4

[Qemu-devel] [PATCH 1/9] Makefile: Avoid explicit list of directories in clean target

[Stefan Hajnoczi]

From: Peter Maydell <peter.maydell@linaro.org>

Avoid having an explicit list of directories in the 'clean'
target by using 'find' to remove all .o and .d files instead.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 Makefile |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index d736ea5..2964d5c 100644
--- a/Makefile
+++ b/Makefile
@@ -214,13 +214,10 @@ clean:
 # avoid old build problems by removing potentially incorrect old files
 	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
 	rm -f qemu-options.def
-	rm -f *.o *.d *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
+	find . -name '*.[od]' -exec rm -f {} +
+	rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
 	rm -Rf .libs
-	rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d qga/*.o qga/*.d
-	rm -f qom/*.o qom/*.d libuser/qom/*.o libuser/qom/*.d
-	rm -f hw/usb/*.o hw/usb/*.d hw/*.o hw/*.d
 	rm -f qemu-img-cmds.h
-	rm -f trace/*.o trace/*.d
 	rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
 	@# May not be present in GENERATED_HEADERS
 	rm -f trace-dtrace.h trace-dtrace.h-timestamp
-- 
1.7.10.4

[Qemu-devel] [PATCH 2/9] ehci: fix assertion typo

[Stefan Hajnoczi]

From: Alejandro Martinez Ruiz <alex@securiforest.com>

Signed-off-by: Alejandro Martinez Ruiz <alex@securiforest.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/usb/hcd-ehci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index b043e7c..104c21d 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2010,7 +2010,7 @@ static void ehci_fill_queue(EHCIPacket *p)
         p->qtdaddr = qtdaddr;
         p->qtd = qtd;
         p->usb_status = ehci_execute(p, "queue");
-        assert(p->usb_status = USB_RET_ASYNC);
+        assert(p->usb_status == USB_RET_ASYNC);
         p->async = EHCI_ASYNC_INFLIGHT;
     }
 }
-- 
1.7.10.4

[Qemu-devel] [PATCH 3/9] cputlb.c: Fix out of date comment

[Stefan Hajnoczi]

From: Peter Maydell <peter.maydell@linaro.org>

The comment about the return address from get_page_addr_code() was
well out of date as phys_ram_base has not existed for some time.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 cputlb.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cputlb.c b/cputlb.c
index 0d1e252..d3e7b25 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -312,7 +312,9 @@ void tlb_set_page(CPUArchState *env, target_ulong vaddr,
 
 /* NOTE: this function can trigger an exception */
 /* NOTE2: the returned address is not exactly the physical address: it
-   is the offset relative to phys_ram_base */
+ * is actually a ram_addr_t (in system mode; the user mode emulation
+ * version of this function returns a guest virtual address).
+ */
 tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr)
 {
     int mmu_idx, page_index, pd;
-- 
1.7.10.4

[Qemu-devel] [PATCH 4/9] trace: Fix "Qemu" -> "QEMU"

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 scripts/simpletrace.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py
index 9b4419f..8bbcb42 100755
--- a/scripts/simpletrace.py
+++ b/scripts/simpletrace.py
@@ -71,7 +71,7 @@ def read_trace_file(edict, fobj):
 
     log_version = header[2]
     if log_version == 0:
-        raise ValueError('Older log format, not supported with this Qemu release!')
+        raise ValueError('Older log format, not supported with this QEMU release!')
 
     while True:
         rec = read_record(edict, fobj)
-- 
1.7.10.4

[Qemu-devel] [PATCH 5/9] docs: Fix spelling (propery -> property)

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 docs/bootindex.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/bootindex.txt b/docs/bootindex.txt
index 16083b3..803ebfc 100644
--- a/docs/bootindex.txt
+++ b/docs/bootindex.txt
@@ -1,4 +1,4 @@
-= Bootindex propery =
+= Bootindex property =
 
 Block and net devices have bootindex property. This property is used to
 determine the order in which firmware will consider devices for booting
-- 
1.7.10.4

[Qemu-devel] [PATCH 6/9] Spelling fix in comment (peripherans -> peripherals)

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/versatilepb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index 4fd5d9b..7a92034 100644
--- a/hw/versatilepb.c
+++ b/hw/versatilepb.c
@@ -162,7 +162,7 @@ static int vpb_sic_init(SysBusDevice *dev)
 /* Board init.  */
 
 /* The AB and PB boards both use the same core, just with different
-   peripherans and expansion busses.  For now we emulate a subset of the
+   peripherals and expansion busses.  For now we emulate a subset of the
    PB peripherals and just change the board ID.  */
 
 static struct arm_boot_info versatile_binfo;
-- 
1.7.10.4

[Qemu-devel] [PATCH 7/9] framebuffer: Fix spelling in comment (leight -> height)

[Stefan Hajnoczi]

From: Stefan Weil <sw@weilnetz.de>

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/framebuffer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/framebuffer.c b/hw/framebuffer.c
index f4747cd..85a00a5 100644
--- a/hw/framebuffer.c
+++ b/hw/framebuffer.c
@@ -28,7 +28,7 @@ void framebuffer_update_display(
     MemoryRegion *address_space,
     target_phys_addr_t base,
     int cols, /* Width in pixels.  */
-    int rows, /* Leight in pixels.  */
+    int rows, /* Height in pixels.  */
     int src_width, /* Length of source line, in bytes.  */
     int dest_row_pitch, /* Bytes between adjacent horizontal output pixels.  */
     int dest_col_pitch, /* Bytes between adjacent vertical output pixels.  */
-- 
1.7.10.4

[Qemu-devel] [PATCH 8/9] iov_send_recv(): Handle zero bytes case even if OS does not

[Stefan Hajnoczi]

From: Peter Maydell <peter.maydell@linaro.org>

POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero
msg.msg_iovlen (in particular the MacOS X implementation will do this).
Handle the case where iov_send_recv() is passed a zero byte count
explicitly, to avoid accidentally depending on the OS to treat zero
msg_iovlen as a no-op.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 iov.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/iov.c b/iov.c
index b333061..60705c7 100644
--- a/iov.c
+++ b/iov.c
@@ -146,6 +146,13 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
 {
     ssize_t ret;
     unsigned si, ei;            /* start and end indexes */
+    if (bytes == 0) {
+        /* Catch the do-nothing case early, as otherwise we will pass an
+         * empty iovec to sendmsg/recvmsg(), and not all implementations
+         * accept this.
+         */
+        return 0;
+    }
 
     /* Find the start position, skipping `offset' bytes:
      * first, skip all full-sized vector elements, */
-- 
1.7.10.4

[Qemu-devel] [PATCH 9/9] ivshmem, qdev-monitor: fix order of qerror parameters

[Stefan Hajnoczi]

From: Alberto Garcia <agarcia@igalia.com>

Now that the QERR_ macros no longer contain a json dictionary,
the order of some parameters needs to be fixed for them to appear
correctly.

Signed-off-by: Alberto Garcia <agarcia@igalia.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/ivshmem.c      |    3 ++-
 hw/qdev-monitor.c |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index 0c58161..b4d65a6 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -677,7 +677,8 @@ static int pci_ivshmem_init(PCIDevice *dev)
     }
 
     if (s->role_val == IVSHMEM_PEER) {
-        error_set(&s->migration_blocker, QERR_DEVICE_FEATURE_BLOCKS_MIGRATION, "ivshmem", "peer mode");
+        error_set(&s->migration_blocker, QERR_DEVICE_FEATURE_BLOCKS_MIGRATION,
+                  "peer mode", "ivshmem");
         migrate_add_blocker(s->migration_blocker);
     }
 
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index b22a37a..018b386 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -443,7 +443,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
         bus = qbus_find_recursive(sysbus_get_default(), NULL, k->bus_type);
         if (!bus) {
             qerror_report(QERR_NO_BUS_FOR_DEVICE,
-                          driver, k->bus_type);
+                          k->bus_type, driver);
             return NULL;
         }
     }
-- 
1.7.10.4

Re: [Qemu-devel] [PULL 0/9 for-1.2] Trivial patches for 11 to 15 August 2012

[Anthony Liguori]

Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> writes:

> The last pull request for QEMU 1.2!
>
> The following changes since commit 03834e22abafbc8dc4052d46a5ccd6dd135a54a3:
>
>   Merge remote-tracking branch 'origin/master' into staging (2012-08-14 15:19:50 -0500)
>

Pulled. Thanks.

Regards,

Anthony Liguori

> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git trivial-patches
>
> for you to fetch changes up to c3594ed73e0a7e7feae309be79f0eb6bafcc02ab:
>
>   ivshmem, qdev-monitor: fix order of qerror parameters (2012-08-15 15:37:08 +0100)
>
> ----------------------------------------------------------------
> Alberto Garcia (1):
>       ivshmem, qdev-monitor: fix order of qerror parameters
>
> Alejandro Martinez Ruiz (1):
>       ehci: fix assertion typo
>
> Peter Maydell (3):
>       Makefile: Avoid explicit list of directories in clean target
>       cputlb.c: Fix out of date comment
>       iov_send_recv(): Handle zero bytes case even if OS does not
>
> Stefan Weil (4):
>       trace: Fix "Qemu" -> "QEMU"
>       docs: Fix spelling (propery -> property)
>       Spelling fix in comment (peripherans -> peripherals)
>       framebuffer: Fix spelling in comment (leight -> height)
>
>  Makefile               |    7 ++-----
>  cputlb.c               |    4 +++-
>  docs/bootindex.txt     |    2 +-
>  hw/framebuffer.c       |    2 +-
>  hw/ivshmem.c           |    3 ++-
>  hw/qdev-monitor.c      |    2 +-
>  hw/usb/hcd-ehci.c      |    2 +-
>  hw/versatilepb.c       |    2 +-
>  iov.c                  |    7 +++++++
>  scripts/simpletrace.py |    2 +-
>  10 files changed, 20 insertions(+), 13 deletions(-)
>
> -- 
> 1.7.10.4