From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com,
dhillf@gmail.com, rientjes@google.com, mhocko@suse.cz,
akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH -V8 02/16] hugetlb: don't use ERR_PTR with VM_FAULT* values
Date: Sat, 09 Jun 2012 18:47:14 +0530 [thread overview]
Message-ID: <87mx4clj51.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20120609111010.GA16034@localhost.localdomain>
Konrad Rzeszutek Wilk <konrad@darnok.org> writes:
> On Sat, Jun 09, 2012 at 02:29:47PM +0530, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>
>> The current use of VM_FAULT_* codes with ERR_PTR requires us to ensure
>> VM_FAULT_* values will not exceed MAX_ERRNO value. Decouple the
>> VM_FAULT_* values from MAX_ERRNO.
>
> I see you using the -ENOMEM|-ENOSPC, but I don't see any reference in the
> code to MAX_ERRNO? Can you provide a comment explaining in a tad little
> bit about the interaction of MAX_ERRNO and VM_FAULT?
That comes from this
#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com,
dhillf@gmail.com, rientjes@google.com, mhocko@suse.cz,
akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH -V8 02/16] hugetlb: don't use ERR_PTR with VM_FAULT* values
Date: Sat, 09 Jun 2012 18:47:14 +0530 [thread overview]
Message-ID: <87mx4clj51.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20120609111010.GA16034@localhost.localdomain>
Konrad Rzeszutek Wilk <konrad@darnok.org> writes:
> On Sat, Jun 09, 2012 at 02:29:47PM +0530, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>
>> The current use of VM_FAULT_* codes with ERR_PTR requires us to ensure
>> VM_FAULT_* values will not exceed MAX_ERRNO value. Decouple the
>> VM_FAULT_* values from MAX_ERRNO.
>
> I see you using the -ENOMEM|-ENOSPC, but I don't see any reference in the
> code to MAX_ERRNO? Can you provide a comment explaining in a tad little
> bit about the interaction of MAX_ERRNO and VM_FAULT?
That comes from this
#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
-aneesh
next prev parent reply other threads:[~2012-06-09 13:17 UTC|newest]
Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 8:59 [PATCH -V8 00/16] hugetlb: Add HugeTLB controller to control HugeTLB allocation Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 01/16] hugetlb: rename max_hstate to hugetlb_max_hstate Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 02/16] hugetlb: don't use ERR_PTR with VM_FAULT* values Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 11:10 ` Konrad Rzeszutek Wilk
2012-06-09 11:10 ` Konrad Rzeszutek Wilk
2012-06-09 13:17 ` Aneesh Kumar K.V [this message]
2012-06-09 13:17 ` Aneesh Kumar K.V
2012-06-09 19:28 ` KOSAKI Motohiro
2012-06-09 19:28 ` KOSAKI Motohiro
[not found] ` <1339232401-14392-3-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-10 1:59 ` Hillf Danton
2012-06-10 1:59 ` Hillf Danton
2012-06-10 1:59 ` Hillf Danton
2012-06-09 8:59 ` [PATCH -V8 03/16] hugetlb: add an inline helper for finding hstate index Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 04/16] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 05/16] hugetlb: avoid taking i_mmap_mutex in unmap_single_vma() for hugetlb Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 9:44 ` Johannes Weiner
2012-06-09 9:44 ` Johannes Weiner
2012-06-09 13:03 ` Aneesh Kumar K.V
2012-06-09 13:03 ` Aneesh Kumar K.V
2012-06-09 14:49 ` Johannes Weiner
2012-06-09 14:49 ` Johannes Weiner
2012-06-09 8:59 ` [PATCH -V8 06/16] hugetlb: simplify migrate_huge_page() Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-7-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-12 7:31 ` Kamezawa Hiroyuki
2012-06-12 7:31 ` Kamezawa Hiroyuki
2012-06-12 7:31 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 07/16] hugetlb: add a list for tracking in-use HugeTLB pages Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 08/16] hugetlb: Make some static variables global Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-9-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-12 7:35 ` Kamezawa Hiroyuki
2012-06-12 7:35 ` Kamezawa Hiroyuki
2012-06-12 7:35 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 09/16] mm/hugetlb: Add new HugeTLB cgroup Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-10-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-12 7:46 ` Kamezawa Hiroyuki
2012-06-12 7:46 ` Kamezawa Hiroyuki
2012-06-12 7:46 ` Kamezawa Hiroyuki
2012-06-12 9:37 ` Aneesh Kumar K.V
2012-06-12 9:37 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 10/16] hugetlb/cgroup: Add the cgroup pointer to page lru Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-11-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-09 11:14 ` Konrad Rzeszutek Wilk
2012-06-09 11:14 ` Konrad Rzeszutek Wilk
2012-06-09 11:14 ` Konrad Rzeszutek Wilk
2012-06-11 8:16 ` Michal Hocko
2012-06-11 8:16 ` Michal Hocko
2012-06-11 8:16 ` Michal Hocko
2012-06-11 9:03 ` Aneesh Kumar K.V
2012-06-11 9:03 ` Aneesh Kumar K.V
[not found] ` <87oboq5ifb.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-06-11 9:16 ` Michal Hocko
2012-06-11 9:16 ` Michal Hocko
2012-06-11 9:16 ` Michal Hocko
2012-06-11 9:33 ` Aneesh Kumar K.V
2012-06-11 9:33 ` Aneesh Kumar K.V
2012-06-11 8:41 ` Kamezawa Hiroyuki
2012-06-11 8:41 ` Kamezawa Hiroyuki
2012-06-11 8:41 ` Kamezawa Hiroyuki
2012-06-09 17:04 ` Aneesh Kumar K.V
2012-06-09 17:04 ` Aneesh Kumar K.V
2012-06-12 7:52 ` Kamezawa Hiroyuki
2012-06-12 7:52 ` Kamezawa Hiroyuki
[not found] ` <4FD6F530.6050603-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-12 9:40 ` Aneesh Kumar K.V
2012-06-12 9:40 ` Aneesh Kumar K.V
2012-06-12 9:40 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 11/16] hugetlb/cgroup: Add charge/uncharge routines for hugetlb cgroup Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-12-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-11 8:38 ` Michal Hocko
2012-06-11 8:38 ` Michal Hocko
2012-06-11 8:38 ` Michal Hocko
2012-06-11 9:10 ` Michal Hocko
2012-06-11 9:10 ` Michal Hocko
2012-06-11 9:28 ` Aneesh Kumar K.V
2012-06-11 9:28 ` Aneesh Kumar K.V
[not found] ` <87liju5h9u.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-06-11 12:59 ` Michal Hocko
2012-06-11 12:59 ` Michal Hocko
2012-06-11 12:59 ` Michal Hocko
2012-06-11 15:35 ` Aneesh Kumar K.V
2012-06-11 15:35 ` Aneesh Kumar K.V
2012-06-12 8:08 ` Kamezawa Hiroyuki
2012-06-12 8:08 ` Kamezawa Hiroyuki
2012-06-12 8:08 ` Kamezawa Hiroyuki
2012-06-12 10:50 ` Aneesh Kumar K.V
2012-06-12 10:50 ` Aneesh Kumar K.V
2012-06-13 11:02 ` Kamezawa Hiroyuki
2012-06-13 11:02 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 12/16] hugetlb/cgroup: Add support for cgroup removal Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-11 8:52 ` Michal Hocko
2012-06-11 8:52 ` Michal Hocko
[not found] ` <20120611085258.GD12402-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-06-11 9:40 ` Aneesh Kumar K.V
2012-06-11 9:40 ` Aneesh Kumar K.V
2012-06-11 9:40 ` Aneesh Kumar K.V
[not found] ` <87fwa25gqj.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-06-11 13:14 ` Michal Hocko
2012-06-11 13:14 ` Michal Hocko
2012-06-11 13:14 ` Michal Hocko
2012-06-11 15:34 ` Aneesh Kumar K.V
2012-06-11 15:34 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-13-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-12 8:23 ` Kamezawa Hiroyuki
2012-06-12 8:23 ` Kamezawa Hiroyuki
2012-06-12 8:23 ` Kamezawa Hiroyuki
2012-06-12 10:52 ` Aneesh Kumar K.V
2012-06-12 10:52 ` Aneesh Kumar K.V
2012-06-09 8:59 ` [PATCH -V8 13/16] hugetlb/cgroup: add hugetlb cgroup control files Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-14-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-09 11:19 ` Konrad Rzeszutek Wilk
2012-06-09 11:19 ` Konrad Rzeszutek Wilk
2012-06-09 11:19 ` Konrad Rzeszutek Wilk
2012-06-11 9:02 ` Michal Hocko
2012-06-11 9:02 ` Michal Hocko
[not found] ` <20120611090234.GE12402-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-06-11 9:43 ` Aneesh Kumar K.V
2012-06-11 9:43 ` Aneesh Kumar K.V
2012-06-11 9:43 ` Aneesh Kumar K.V
2012-06-11 13:15 ` Michal Hocko
2012-06-11 13:15 ` Michal Hocko
2012-06-12 8:35 ` Kamezawa Hiroyuki
2012-06-12 8:35 ` Kamezawa Hiroyuki
[not found] ` <4FD6FF47.8080200-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-12 10:58 ` Aneesh Kumar K.V
2012-06-12 10:58 ` Aneesh Kumar K.V
2012-06-12 10:58 ` Aneesh Kumar K.V
2012-06-13 0:16 ` Kamezawa Hiroyuki
2012-06-13 0:16 ` Kamezawa Hiroyuki
2012-06-09 8:59 ` [PATCH -V8 14/16] hugetlb/cgroup: add charge/uncharge calls for HugeTLB alloc/free Aneesh Kumar K.V
2012-06-09 8:59 ` Aneesh Kumar K.V
2012-06-09 9:23 ` Johannes Weiner
2012-06-09 9:23 ` Johannes Weiner
2012-06-09 13:09 ` Aneesh Kumar K.V
2012-06-09 13:09 ` Aneesh Kumar K.V
2012-06-09 14:30 ` Johannes Weiner
2012-06-09 14:30 ` Johannes Weiner
2012-06-09 15:55 ` Aneesh Kumar K.V
2012-06-09 15:55 ` Aneesh Kumar K.V
2012-06-11 9:19 ` Michal Hocko
2012-06-11 9:19 ` Michal Hocko
[not found] ` <1339232401-14392-15-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-11 9:21 ` Michal Hocko
2012-06-11 9:21 ` Michal Hocko
2012-06-11 9:21 ` Michal Hocko
2012-06-11 10:29 ` Aneesh Kumar K.V
2012-06-11 10:29 ` Aneesh Kumar K.V
2012-06-09 9:00 ` [PATCH -V8 15/16] hugetlb/cgroup: migrate hugetlb cgroup info from oldpage to new page during migration Aneesh Kumar K.V
2012-06-09 9:00 ` Aneesh Kumar K.V
[not found] ` <1339232401-14392-16-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-06-11 9:24 ` Michal Hocko
2012-06-11 9:24 ` Michal Hocko
2012-06-11 9:24 ` Michal Hocko
[not found] ` <20120611092424.GJ12402-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-06-11 10:17 ` Aneesh Kumar K.V
2012-06-11 10:17 ` Aneesh Kumar K.V
2012-06-11 10:17 ` Aneesh Kumar K.V
2012-06-12 8:51 ` Kamezawa Hiroyuki
2012-06-12 8:51 ` Kamezawa Hiroyuki
2012-06-12 11:00 ` Aneesh Kumar K.V
2012-06-12 11:00 ` Aneesh Kumar K.V
[not found] ` <87aa08okvz.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-06-13 11:15 ` Kamezawa Hiroyuki
2012-06-13 11:15 ` Kamezawa Hiroyuki
2012-06-13 11:15 ` Kamezawa Hiroyuki
2012-06-09 9:00 ` [PATCH -V8 16/16] hugetlb/cgroup: add HugeTLB controller documentation Aneesh Kumar K.V
2012-06-09 9:00 ` Aneesh Kumar K.V
2012-06-12 8:57 ` Kamezawa Hiroyuki
2012-06-12 8:57 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx4clj51.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.