Why was the gptimer_wakup from suspend removed?

Why was the gptimer_wakup from suspend removed?

[Tasslehoff Kjappfot]

It was removed in:
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=commit;h=98e182a26bbbf5575457622337684ef61493e864

The commit message says a bit about what was done, but not why.

I'm trying to get suspend somewhat working on my board. The board is based on the beagleboard and uses the 1.8V to charge some external equipment. My thought was to suspend, wake occasionally to check if the charging is done, and shutdown if it is. In 2.6.39 which I'm currently using, it's still there, but since it is gone in 3.0 and later I'm wondering if I should not rely on it.

Tasslehoff

Re: Why was the gptimer_wakup from suspend removed?

[Kevin Hilman]

Hello,

Tasslehoff Kjappfot <tasskjapp@gmail.com> writes:

> It was removed in:
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=commit;h=98e182a26bbbf5575457622337684ef61493e864
>
> The commit message says a bit about what was done, but not why.

The reason why was because the way it was implemented was a hack and was
causing problems for some other cleanups, so we removed it.

> I'm trying to get suspend somewhat working on my board. The board is
> based on the beagleboard and uses the 1.8V to charge some external
> equipment. My thought was to suspend, wake occasionally to check if
> the charging is done, and shutdown if it is. 

The kernel now has a way to implement exactly this.  Please have a look
at Documentation/power/charger-manager.txt.

> In 2.6.39 which I'm currently using, it's still there, but since it is
> gone in 3.0 and later I'm wondering if I should not rely on it.

No, you should not rely on it.  For your specific case, there is much
better infrastructure to do exactly what you need.

Kevin