From: Peter Korsgaard <jacmet@sunsite.dk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes
Date: Mon, 09 Jan 2012 12:20:13 +0000 [thread overview]
Message-ID: <87mx9xdq4i.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20120109121322.GM21765@n2100.arm.linux.org.uk> (Russell King's message of "Mon, 9 Jan 2012 12:13:22 +0000")
>>>>> "Russell" = Russell King <- ARM Linux <linux@arm.linux.org.uk>> writes:
Hi,
Russell> You describe the RGB555 vs RGB565 via the bitfield values in
Russell> var->red, var-> green and var->blue. So, RGB(or BGR)565 has
Russell> var->green.length with 6, and RGB(or BGR)555 has this as 5.
Russell> In both cases, bits_per_pixel is 16 as that's the width of a
Russell> pixel in the frame buffer.
Russell> If the bitfield can't be interpreted by the driver as
Russell> identifying one of these combinations, then you're supposed to
Russell> chose one (and in the case where it's fixed by hardware, you
Russell> set the bitfields according to what the hardware supports.)
Indeed, and as the hardware can only interprete 1/2/4/8 paletted and
16/24 RGB, we shouldn't claim to support 15bit.
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes
Date: Mon, 09 Jan 2012 13:20:13 +0100 [thread overview]
Message-ID: <87mx9xdq4i.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20120109121322.GM21765@n2100.arm.linux.org.uk> (Russell King's message of "Mon, 9 Jan 2012 12:13:22 +0000")
>>>>> "Russell" == Russell King <- ARM Linux <linux@arm.linux.org.uk>> writes:
Hi,
Russell> You describe the RGB555 vs RGB565 via the bitfield values in
Russell> var->red, var-> green and var->blue. So, RGB(or BGR)565 has
Russell> var->green.length with 6, and RGB(or BGR)555 has this as 5.
Russell> In both cases, bits_per_pixel is 16 as that's the width of a
Russell> pixel in the frame buffer.
Russell> If the bitfield can't be interpreted by the driver as
Russell> identifying one of these combinations, then you're supposed to
Russell> chose one (and in the case where it's fixed by hardware, you
Russell> set the bitfields according to what the hardware supports.)
Indeed, and as the hardware can only interprete 1/2/4/8 paletted and
16/24 RGB, we shouldn't claim to support 15bit.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-01-09 12:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 14:52 [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Peter Korsgaard
2011-10-13 14:52 ` Peter Korsgaard
2012-01-05 11:26 ` Peter Korsgaard
2012-01-05 11:26 ` Peter Korsgaard
2012-01-09 2:49 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported Florian Tobias Schandinat
2012-01-09 2:49 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Florian Tobias Schandinat
2012-01-09 6:15 ` Peter Korsgaard
2012-01-09 6:15 ` Peter Korsgaard
2012-01-09 13:36 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported Nicolas Ferre
2012-01-09 13:36 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Nicolas Ferre
2012-01-09 10:34 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported Nicolas Ferre
2012-01-09 10:34 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Nicolas Ferre
2012-01-09 11:13 ` Peter Korsgaard
2012-01-09 11:13 ` Peter Korsgaard
2012-01-09 13:32 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported Nicolas Ferre
2012-01-09 13:32 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Nicolas Ferre
2012-01-10 13:01 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove Christian Glindkamp
2012-01-10 13:01 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Christian Glindkamp
2012-01-10 13:17 ` Peter Korsgaard
2012-01-10 13:17 ` Peter Korsgaard
2012-01-10 16:42 ` Peter Korsgaard
2012-01-10 16:42 ` Peter Korsgaard
2012-01-10 14:02 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove Jamie Lokier
2012-01-10 14:02 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Jamie Lokier
2012-01-10 14:19 ` Peter Korsgaard
2012-01-10 14:19 ` Peter Korsgaard
2012-01-10 21:06 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove Russell King - ARM Linux
2012-01-10 21:06 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Russell King - ARM Linux
2012-01-09 12:13 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove Russell King - ARM Linux
2012-01-09 12:13 ` [PATCH] atmel_lcdfb: support 16bit BGR:565 mode, remove unsupported 15bit modes Russell King - ARM Linux
2012-01-09 12:20 ` Peter Korsgaard [this message]
2012-01-09 12:20 ` Peter Korsgaard
2012-01-30 5:12 ` Florian Tobias Schandinat
2012-01-30 5:12 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx9xdq4i.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.