From: Kevin Hilman <khilman@ti.com>
To: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@ti.com, gadiyar@ti.com,
sameo@linux.intel.com, parthab@india.ti.com, tony@atomide.com,
b-cousson@ti.com, paul@pwsan.com, johnstul@us.ibm.com,
vishwanath.bs@ti.com, Kishon Vijay Abraham <kishon@ti.com>
Subject: Re: [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap4
Date: Fri, 09 Sep 2011 11:27:37 -0700 [thread overview]
Message-ID: <87mxedwoyu.fsf@ti.com> (raw)
In-Reply-To: <1315579967-24945-2-git-send-email-keshava_mgowda@ti.com> (Keshava Munegowda's message of "Fri, 9 Sep 2011 20:22:46 +0530")
Keshava Munegowda <keshava_mgowda@ti.com> writes:
> From: Kishon Vijay Abraham <kishon@ti.com>
>
> For ehci and ohci hwmods, the omap4 I/O wakeup capablity is enabled.
> for ehci in phy mode,
> - the DAT0 and DIR I/O pad is set as wakeup capable
> for ohci in serial mode
> - usbb*_mm_rxdp is set as I/O wakeup for 6 pin serial mode
> - usbb*_mm_rxrcv is set as I/O wakeup for 4 pin serial mode
> - usbb*_mm_txen is set as I/O wakeup for 3 pin serial mode
> - usbb*_mm_txdat is set as I/O wakeup for 2 pin serial mode
>
> Signed-off-by: Kishon Vijay Abraham <kishon@ti.com>
> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
What if the end user doesn't want this device to be a wakeup source?
Currently, the IO pad wakeup for these pins is enabled unconditionally.
While having it enabled as a wakeup source by default is fine, it should
not generate wakeups if the user has disable them by doing:
$ echo disabled > /sys/devices/.../power/wakeup
IOW, whether wakeups are enabled or not should depend on the driver
checking device_may_wakeup()
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@ti.com>
To: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: <linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <balbi@ti.com>, <gadiyar@ti.com>,
<sameo@linux.intel.com>, <parthab@india.ti.com>,
<tony@atomide.com>, <b-cousson@ti.com>, <paul@pwsan.com>,
<johnstul@us.ibm.com>, <vishwanath.bs@ti.com>,
Kishon Vijay Abraham <kishon@ti.com>
Subject: Re: [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap4
Date: Fri, 09 Sep 2011 11:27:37 -0700 [thread overview]
Message-ID: <87mxedwoyu.fsf@ti.com> (raw)
In-Reply-To: <1315579967-24945-2-git-send-email-keshava_mgowda@ti.com> (Keshava Munegowda's message of "Fri, 9 Sep 2011 20:22:46 +0530")
Keshava Munegowda <keshava_mgowda@ti.com> writes:
> From: Kishon Vijay Abraham <kishon@ti.com>
>
> For ehci and ohci hwmods, the omap4 I/O wakeup capablity is enabled.
> for ehci in phy mode,
> - the DAT0 and DIR I/O pad is set as wakeup capable
> for ohci in serial mode
> - usbb*_mm_rxdp is set as I/O wakeup for 6 pin serial mode
> - usbb*_mm_rxrcv is set as I/O wakeup for 4 pin serial mode
> - usbb*_mm_txen is set as I/O wakeup for 3 pin serial mode
> - usbb*_mm_txdat is set as I/O wakeup for 2 pin serial mode
>
> Signed-off-by: Kishon Vijay Abraham <kishon@ti.com>
> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
What if the end user doesn't want this device to be a wakeup source?
Currently, the IO pad wakeup for these pins is enabled unconditionally.
While having it enabled as a wakeup source by default is fine, it should
not generate wakeups if the user has disable them by doing:
$ echo disabled > /sys/devices/.../power/wakeup
IOW, whether wakeups are enabled or not should depend on the driver
checking device_may_wakeup()
Kevin
next prev parent reply other threads:[~2011-09-09 18:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 14:52 [PATCH 0/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods Keshava Munegowda
2011-09-09 14:52 ` Keshava Munegowda
2011-09-09 14:52 ` [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap4 Keshava Munegowda
2011-09-09 14:52 ` Keshava Munegowda
2011-09-09 14:52 ` [PATCH 2/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap3 Keshava Munegowda
2011-09-09 14:52 ` Keshava Munegowda
2011-09-09 18:27 ` Kevin Hilman [this message]
2011-09-09 18:27 ` [PATCH 1/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods of omap4 Kevin Hilman
[not found] ` <87mxedwoyu.fsf-l0cyMroinI0@public.gmane.org>
2011-09-12 6:36 ` Munegowda, Keshava
2011-09-12 6:36 ` Munegowda, Keshava
2011-09-22 23:38 ` [PATCH 0/2] arm: omap: usb: enable I/O wakeups of ehci and ohci hwmods Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxedwoyu.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=johnstul@us.ibm.com \
--cc=keshava_mgowda@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
--cc=paul@pwsan.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.