[Buildroot] PATH

[Buildroot] PATH

[Heiko Zuerker]

Hey,

I'm almost done with the MySQL 5.5 script, but it requires ./ in the path.
It may not be a bad idea to add this to Makefile.in (TARGET_PATH,  
HOST_PATH), in case other packages have a similar behavior.

Thoughts?
(Worst case I'll just keep it in the mysql.mk)

-- 

Regards
   Heiko Zuerker
   http://www.devil-linux.org


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

[Buildroot] PATH

[Yann E. MORIN]

Heiko, All,

On Sunday 08 May 2011 15:14:40 Heiko Zuerker wrote:
> I'm almost done with the MySQL 5.5 script, but it requires ./ in the path.
> It may not be a bad idea to add this to Makefile.in (TARGET_PATH,  
> HOST_PATH), in case other packages have a similar behavior.
> Thoughts?
> (Worst case I'll just keep it in the mysql.mk)

In my opinion, . in the path is a Really Bad Idea (TM), and should not
only be avoided, but entirely banned.

Best would be to fix the MySQL build to not require . in the PATH.
And push the fix upstream.

If it's too complex, then keep it specific to MySQL. Don't make it generic
in buildroot, we want to catch the breakage in other packages so they can
get fixed instead.

My 2c.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] PATH

[Heiko Zuerker]

Quoting "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>:
> Heiko, All,
>
> On Sunday 08 May 2011 15:14:40 Heiko Zuerker wrote:
>> I'm almost done with the MySQL 5.5 script, but it requires ./ in the path.
>> It may not be a bad idea to add this to Makefile.in (TARGET_PATH,
>> HOST_PATH), in case other packages have a similar behavior.
>> Thoughts?
>> (Worst case I'll just keep it in the mysql.mk)
>
> In my opinion, . in the path is a Really Bad Idea (TM), and should not
> only be avoided, but entirely banned.

Just curious, why are you against having . in the path?

-- 

Regards
   Heiko Zuerker
   http://www.devil-linux.org


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

[Buildroot] PATH

[Yann E. MORIN]

Heiko, All,

On Sunday 08 May 2011 15:35:41 Heiko Zuerker wrote:
> Quoting "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>:
> > In my opinion, . in the path is a Really Bad Idea (TM), and should not
> > only be avoided, but entirely banned.
> Just curious, why are you against having . in the path?

Security hole. For example, see:
  http://fixunix.com/unix/88657-whats-wrong-having-my-$path.html

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] PATH

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> Heiko, All,
 Yann> On Sunday 08 May 2011 15:14:40 Heiko Zuerker wrote:
 >> I'm almost done with the MySQL 5.5 script, but it requires ./ in the path.
 >> It may not be a bad idea to add this to Makefile.in (TARGET_PATH,  
 >> HOST_PATH), in case other packages have a similar behavior.
 >> Thoughts?
 >> (Worst case I'll just keep it in the mysql.mk)

 Yann> In my opinion, . in the path is a Really Bad Idea (TM), and should not
 Yann> only be avoided, but entirely banned.

I agree. I'm surprised to hear that mysql needs it.

-- 
Bye, Peter Korsgaard

[Buildroot] PATH

[Heiko Zuerker]

Quoting Peter Korsgaard <jacmet@uclibc.org>:

>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:
>
>  Yann> Heiko, All,
>  Yann> On Sunday 08 May 2011 15:14:40 Heiko Zuerker wrote:
>  >> I'm almost done with the MySQL 5.5 script, but it requires ./ in  
> the path.
>  >> It may not be a bad idea to add this to Makefile.in (TARGET_PATH,
>  >> HOST_PATH), in case other packages have a similar behavior.
>  >> Thoughts?
>  >> (Worst case I'll just keep it in the mysql.mk)
>
>  Yann> In my opinion, . in the path is a Really Bad Idea (TM), and should not
>  Yann> only be avoided, but entirely banned.
>
> I agree. I'm surprised to hear that mysql needs it.

5.1 is fine, it's 5.5 which needs it.
I'll look into writing a patch, but it could be a little while until I  
get to it.

-- 

Regards
   Heiko Zuerker
   http://www.devil-linux.org