All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [patch] fs: improved handling of page and buffer IO errors
Date: Tue, 21 Oct 2008 18:16:24 +0200	[thread overview]
Message-ID: <87mygxexev.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081021112137.GB12329@wotan.suse.de> (Nick Piggin's message of "Tue, 21 Oct 2008 13:21:37 +0200")

Nick Piggin <npiggin@suse.de> writes:

> IO error handling in the core mm/fs still doesn't seem perfect, but with
> the recent round of patches and this one, it should be getting on the
> right track.
>
> I kind of get the feeling some people would rather forget about all this
> and brush it under the carpet. Hopefully I'm mistaken, but if anybody
> disagrees with my assertion that error handling, and data integrity
> semantics are first-class correctness issues, and therefore are more
> important than all other non-correctness problems... speak now and let's
> discuss that, please.
>
> Otherwise, unless anybody sees obvious problems with this, hopefully it
> can go into -mm for some wider testing (I've tested it with a few filesystems
> so far and no immediate problems)

I think the first step to get these more robust in the future would be to
have a standard regression test testing these paths.  Otherwise it'll
bit-rot sooner or later again.

-Andi

-- 
ak@linux.intel.com

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [patch] fs: improved handling of page and buffer IO errors
Date: Tue, 21 Oct 2008 18:16:24 +0200	[thread overview]
Message-ID: <87mygxexev.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081021112137.GB12329@wotan.suse.de> (Nick Piggin's message of "Tue, 21 Oct 2008 13:21:37 +0200")

Nick Piggin <npiggin@suse.de> writes:

> IO error handling in the core mm/fs still doesn't seem perfect, but with
> the recent round of patches and this one, it should be getting on the
> right track.
>
> I kind of get the feeling some people would rather forget about all this
> and brush it under the carpet. Hopefully I'm mistaken, but if anybody
> disagrees with my assertion that error handling, and data integrity
> semantics are first-class correctness issues, and therefore are more
> important than all other non-correctness problems... speak now and let's
> discuss that, please.
>
> Otherwise, unless anybody sees obvious problems with this, hopefully it
> can go into -mm for some wider testing (I've tested it with a few filesystems
> so far and no immediate problems)

I think the first step to get these more robust in the future would be to
have a standard regression test testing these paths.  Otherwise it'll
bit-rot sooner or later again.

-Andi

-- 
ak@linux.intel.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-10-21 16:16 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 11:21 [patch] fs: improved handling of page and buffer IO errors Nick Piggin
2008-10-21 11:21 ` Nick Piggin
2008-10-21 12:52 ` Miklos Szeredi
2008-10-21 12:52   ` Miklos Szeredi
2008-10-21 12:59   ` steve
2008-10-21 12:59     ` steve
2008-10-21 13:14     ` Miklos Szeredi
2008-10-21 13:14       ` Miklos Szeredi
2008-10-21 13:38       ` steve
2008-10-21 13:38         ` steve
2008-10-21 14:32         ` Miklos Szeredi
2008-10-21 14:32           ` Miklos Szeredi
2008-10-21 15:09           ` steve
2008-10-21 15:09             ` steve
2008-10-21 16:13             ` Miklos Szeredi
2008-10-21 16:13               ` Miklos Szeredi
2008-10-22 12:51               ` Jamie Lokier
2008-10-22 12:51                 ` Jamie Lokier
2008-10-22 14:08                 ` Miklos Szeredi
2008-10-22 14:08                   ` Miklos Szeredi
2008-10-21 14:35         ` Evgeniy Polyakov
2008-10-21 14:35           ` Evgeniy Polyakov
2008-10-21 14:59           ` steve
2008-10-21 14:59             ` steve
2008-10-21 16:20             ` Miklos Szeredi
2008-10-21 16:20               ` Miklos Szeredi
2008-10-21 16:25               ` steve
2008-10-21 16:25                 ` steve
2008-10-21 16:28               ` Miklos Szeredi
2008-10-21 16:28                 ` Miklos Szeredi
2008-10-21 16:29                 ` Matthew Wilcox
2008-10-21 16:29                   ` Matthew Wilcox
2008-10-22 12:48                   ` Jamie Lokier
2008-10-22 12:48                     ` Jamie Lokier
2008-10-22 13:45                     ` Matthew Wilcox
2008-10-22 13:45                       ` Matthew Wilcox
2008-10-22 14:02                       ` Miklos Szeredi
2008-10-22 14:02                         ` Miklos Szeredi
2008-10-22 14:35                         ` Matthew Wilcox
2008-10-22 14:45                           ` Miklos Szeredi
2008-10-22 14:45                             ` Miklos Szeredi
2008-10-23 13:48                             ` Matthew Wilcox
2008-10-23 13:48                               ` Matthew Wilcox
2008-10-22 22:23     ` Mark Fasheh
2008-10-22 22:23       ` Mark Fasheh
2008-10-23  9:59       ` steve
2008-10-23  9:59         ` steve
2008-10-23 10:21         ` Nick Piggin
2008-10-23 10:21           ` Nick Piggin
2008-10-23 10:52           ` steve
2008-10-23 10:52             ` steve
2008-10-23 11:07             ` Nick Piggin
2008-10-23 11:07               ` Nick Piggin
2008-10-22 13:16   ` Nick Piggin
2008-10-22 13:16     ` Nick Piggin
2008-10-22 20:09     ` Miklos Szeredi
2008-10-22 20:09       ` Miklos Szeredi
2008-10-21 16:16 ` Andi Kleen [this message]
2008-10-21 16:16   ` Andi Kleen
2008-10-21 16:30   ` steve
2008-10-21 16:30     ` steve
2008-10-22 10:31   ` Nick Piggin
2008-10-22 10:31     ` Nick Piggin
2008-10-22 18:46     ` Brad Boyer
2008-10-22 18:46       ` Brad Boyer
2008-10-22 20:19       ` Andi Kleen
2008-10-22 20:19         ` Andi Kleen
2008-10-23  7:08       ` Nick Piggin
2008-10-23  7:08         ` Nick Piggin
2008-10-22 23:07     ` Dave Chinner
2008-10-22 23:07       ` Dave Chinner
2008-10-23  7:07       ` Nick Piggin
2008-10-23  7:07         ` Nick Piggin
2008-10-23  9:44         ` steve
2008-10-23  9:44           ` steve
2008-10-23 11:15           ` Nick Piggin
2008-10-23 11:15             ` Nick Piggin
2008-10-23 22:48             ` Dave Chinner
2008-10-23 22:48               ` Dave Chinner
2008-10-24  1:05               ` Nick Piggin
2008-10-24  1:05                 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mygxexev.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.