From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: fs/fat.c assumes that 0UL is the same for 32bit and 64bit archs
Date: Wed, 02 Mar 2005 22:20:58 +0100 [thread overview]
Message-ID: <87mztloibp.fsf@student.han.nl> (raw)
In-Reply-To: <200503022201.24046.okuji@enbug.org> (Yoshinori K. Okuji's message of "Wed, 2 Mar 2005 22:01:23 +0100")
"Yoshinori K. Okuji" <okuji@enbug.org> writes:
> On Wednesday 16 February 2005 09:56, Omniflux wrote:
>> fs/fat.c assumes that 0UL is the same for 32bit and 64bit archs, but
>> it is not.
>>
>> There are four locations in fs/fat.c where a 32bit unsigned int is
>> set equal to 0UL. This causes warnings when compiling on 64bit
>> architectures as 0UL is 0xffffffffffffffff (64bits) there.
>
> Marco, did you look at this patch?
Yes. Sorry, I forgot to reply after I got back. :)
The patch looked fine to me. I have encountered this problem as well
on 64 bits archs but I ddi not test the patch yet myself, I can't at
the moment.
Because this seems to be the only way to fix this problem, I don't
think there are copyright issues and the patch can be applied. Right?
Thanks,
Marco
next prev parent reply other threads:[~2005-03-02 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-16 8:56 fs/fat.c assumes that 0UL is the same for 32bit and 64bit archs Omniflux
2005-03-02 21:01 ` Yoshinori K. Okuji
2005-03-02 21:20 ` Marco Gerards [this message]
2005-03-02 21:40 ` Yoshinori K. Okuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mztloibp.fsf@student.han.nl \
--to=metgerards@student.han.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.