Re: [RFC PATCH 0/6] qapi: Preliminary work for better QOM introspection

[Markus Armbruster <armbru@redhat.com>]

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Hi
>
> On Tue, Oct 13, 2026 at 5:57 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>>
>> > Hi Markus
>> >
>> > On Fri, Oct 9, 2026 at 6:05 PM Markus Armbruster <armbru@redhat.com> wrote:
>> >>
>> >> Marc-André Lureau has patches to improve QOM introspection.  Latest
>> >> version is
>> >>
>> >>     Subject: [PATCH v5 00/62] qom/qdev: associate properties with QAPI schema types
>> >>     Date: Fri, 11 Sep 2026 20:34:34 +0400
>> >>     Message-Id: <20260911-qom-qapi-v5-0-7732a55b7760@redhat.com>
>> >>     https://lore.kernel.org/qemu-devel/20260911-qom-qapi-v5-0-7732a55b7760@redhat.com/
>> >>
>> >> The first few patches make the QAPI code generator emit type
>> >> information for use by QOM introspection commands.  They refactor code
>> >> to gain access to masked type names, and to make query-qmp-schema not
>> >> elide types QOM introspection might want to refer to.
>> >>
>> >> My series does this in a different way I find simpler.  It is RFC
>> >> because merging it only makes sense if Marc-André finds it useful.
>> >> Marc-André, please have a look.
>> >
>> > This is essentially doing the same introspection changes but at a
>> > different level. If you ask me, since it's essentially code cleanup at
>> > this point, I would rather merge my changes first and iterate on top.
>> > But you are the gate keeper, so I wouldn't hold it, we need to move
>> > on... I can rebase on top of your refactoring if you prefer.
>>
>> A rebase gives me a cleaner git history, which I like.  Asking you to do
>> it feels a bit unfair, so I did it:
>>
>>     https://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/qom-props-qapi-types-v5-rebased
>
> Awesome, I am happy with that! If you want to resubmit on ML or send
> PR, up to you

Great!

I'd like to have a closer look at a few more patches.  They look
harmless at a glance.

> I think the only local change I had (with the collected review
> trailers), was BootCertificatesList conversion. But that can be a
> follow up.

Happy to squash it in, feel free to send me a delta, a revised patch, or
something to git-fetch.

There's also a temporary test breakage in PATCH 15.  Could you have a
look?

[...]