Re: [PATCH v13 11/11] scsi: ibmvfc: handle extended FPIN events

[Dave Marquardt <davemarq@linux.ibm.com>]

sashiko-bot@kernel.org writes:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] scsi: ibmvscsi: unused list head variable `evt_doneq` in test
> --
>
> commit 7276d45825dded3ce9d906eb91c3d06e314dc430
> Author: Dave Marquardt <davemarq@linux.ibm.com>
>
>     scsi: ibmvfc: handle extended FPIN events
>
> This commit implements support for extended FPIN messages via the
> asynchronous sub-queue. It introduces new capabilities and unit tests for
> extended FPIN event handling.
>
>> diff --git a/drivers/scsi/ibmvscsi/ibmvfc_kunit.c b/drivers/scsi/ibmvscsi/ibmvfc_kunit.c
>> index d2ef35e928eae..cc6e6d0b5f963 100644
>> --- a/drivers/scsi/ibmvscsi/ibmvfc_kunit.c
>> +++ b/drivers/scsi/ibmvscsi/ibmvfc_kunit.c
>
> [ ... ]
>
>> +/**
>> + * ibmvfc_extended_fpin_test - unit test for extended FPIN events
>> + * @test: pointer to kunit structure
>> + *
>> + * Return: void
>> + */
>> +static void ibmvfc_extended_fpin_test(struct kunit *test)
>> +{
>> +	enum ibmvfc_ae_fpin_status fs;
>> +	struct ibmvfc_async_subq_fpin crq;
>> +	struct ibmvfc_target *tgt;
>> +	struct ibmvfc_host *vhost;
>> +	struct fc_host_attrs *fc_host;
>> +	struct fc_rport *rport;
>> +	LIST_HEAD(evt_doneq);
>
> [Severity: Low]
> Is the evt_doneq list head needed? The variable is declared and initialized
> at the beginning of ibmvfc_extended_fpin_test(), but it doesn't appear to be
> used anywhere else in the test function body.

I agree, evt_doneq is not needed. I will fix in a v14 series or we can
let this in and I'll fix it separately afterwards.

-Dave