All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY
Date: Mon, 31 Aug 2026 11:45:04 +0200	[thread overview]
Message-ID: <87o6eimxnj.fsf@kernel.org> (raw)
In-Reply-To: <f9320dae-6436-45e1-b99e-f49115b6279b@kernel.org>

Hi Krzysztof,

Thank you for the review.

On Tue, Aug 04, 2026 at 10:08, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 22/07/2026 15:45, Mattijs Korpershoek wrote:
>> +  power-domains:
>> +    maxItems: 2
>> +
>> +  power-domain-names:
>> +    items:
>> +      - const: transfer
>> +      - const: core
>> +
>
> Same comments, why isn't this following established naming practice for
> sa8xxx bindings?

I've replied in the other phy driver review at:
https://lore.kernel.org/all/877blx2bga.fsf@kernel.org/

I've also send a new version for those bindings which hopefully better
document the power-domain-names and their usage:
https://lore.kernel.org/all/20260831-phy-qcom-snps-femto-v2-8255-v2-1-dc6197ffde1b@kernel.org/

I'll focus on sa8255p-usb-hs-phy.yaml. Once we have something that's
acceptable for usb-hs, I'll respin this series as well.

Thanks
Mattijs

>
> Best regards,
> Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY
Date: Mon, 31 Aug 2026 11:45:04 +0200	[thread overview]
Message-ID: <87o6eimxnj.fsf@kernel.org> (raw)
In-Reply-To: <f9320dae-6436-45e1-b99e-f49115b6279b@kernel.org>

Hi Krzysztof,

Thank you for the review.

On Tue, Aug 04, 2026 at 10:08, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 22/07/2026 15:45, Mattijs Korpershoek wrote:
>> +  power-domains:
>> +    maxItems: 2
>> +
>> +  power-domain-names:
>> +    items:
>> +      - const: transfer
>> +      - const: core
>> +
>
> Same comments, why isn't this following established naming practice for
> sa8xxx bindings?

I've replied in the other phy driver review at:
https://lore.kernel.org/all/877blx2bga.fsf@kernel.org/

I've also send a new version for those bindings which hopefully better
document the power-domain-names and their usage:
https://lore.kernel.org/all/20260831-phy-qcom-snps-femto-v2-8255-v2-1-dc6197ffde1b@kernel.org/

I'll focus on sa8255p-usb-hs-phy.yaml. Once we have something that's
acceptable for usb-hs, I'll respin this series as well.

Thanks
Mattijs

>
> Best regards,
> Krzysztof

  reply	other threads:[~2026-08-31  9:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 13:45 [PATCH v3 0/2] Add support for SA8255P in the qcom-qmp-usb phy driver Mattijs Korpershoek
2026-07-22 13:45 ` Mattijs Korpershoek
2026-07-22 13:45 ` [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY Mattijs Korpershoek
2026-07-22 13:45   ` Mattijs Korpershoek
2026-07-22 13:54   ` sashiko-bot
2026-07-22 13:54     ` sashiko-bot
2026-07-24  6:08   ` Krzysztof Kozlowski
2026-07-24  6:08     ` Krzysztof Kozlowski
2026-07-24 13:56     ` Mattijs Korpershoek
2026-07-24 13:56       ` Mattijs Korpershoek
2026-08-04  8:08   ` Krzysztof Kozlowski
2026-08-04  8:08     ` Krzysztof Kozlowski
2026-08-31  9:45     ` Mattijs Korpershoek [this message]
2026-08-31  9:45       ` Mattijs Korpershoek
2026-07-22 13:45 ` [PATCH v3 2/2] phy: qcom: qmp-usb: Add support for SA8255P Mattijs Korpershoek
2026-07-22 13:45   ` Mattijs Korpershoek
2026-07-22 14:01   ` sashiko-bot
2026-07-22 14:01     ` sashiko-bot
2026-07-22 14:32     ` Mattijs Korpershoek
2026-07-22 14:32       ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6eimxnj.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.