All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "J. Neuschäfer" <j.neuschaefer@9elements.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	qemu-trivial@nongnu.org
Subject: Re: [PATCH] docs/devel/qom: Fix some editing errors
Date: Wed, 20 May 2026 14:20:10 +0200	[thread overview]
Message-ID: <87o6iaz30l.fsf@pond.sub.org> (raw)
In-Reply-To: <20260520-qom-v1-1-baad87fefe4f@9elements.com> ("J. Neuschäfer"'s message of "Wed, 20 May 2026 13:15:20 +0200")

J. Neuschäfer <j.neuschaefer@9elements.com> writes:

> "devices have an two additional [...]" -> "devices have two additional",
> and also a case of "were" vs. "where".
>
> Signed-off-by: J. Neuschäfer <j.neuschaefer@9elements.com>
> ---
>  docs/devel/qom.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index 5870745ba27b108726da0756aa2b90109d5e0bd6..935bb1004a7839c8e963985e765c866d5b980c53 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -435,14 +435,14 @@ OBJECT_DEFINE_ABSTRACT_TYPE() macro can be used instead:
>  Device Life-cycle
>  =================
>  
> -As class initialisation cannot fail devices have an two additional
> +As class initialisation cannot fail, devices have two additional
>  methods to handle the creation of dynamic devices. The ``realize``
>  function is called with ``Error **`` pointer which should be set if
>  the device cannot complete its setup. Otherwise on successful
>  completion of the ``realize`` method the device object is added to the
>  QOM tree and made visible to the guest.
>  
> -The reverse function is ``unrealize`` and should be were clean-up
> +The reverse function is ``unrealize`` and should be where clean-up
>  code lives to tidy up after the system is done with the device.
>  
>  All devices can be instantiated by C code, however only some can
>
> ---
> base-commit: e89049b3ba5f1f0468bc0d294173345597514a1b
> change-id: 20260520-qom-76537da673b6
>
> Best regards,

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Perhaps this could go via qemu-trivial (cc'ed).



  reply	other threads:[~2026-05-20 12:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 11:15 [PATCH] docs/devel/qom: Fix some editing errors J. Neuschäfer
2026-05-20 12:20 ` Markus Armbruster [this message]
2026-05-22 18:06 ` Pierrick Bouvier
2026-05-25 15:23 ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6iaz30l.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=j.neuschaefer@9elements.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.