[PATCH] docs/devel/qom: Fix some editing errors

[PATCH] docs/devel/qom: Fix some editing errors

[J. Neuschäfer]

"devices have an two additional [...]" -> "devices have two additional",
and also a case of "were" vs. "where".

Signed-off-by: J. Neuschäfer <j.neuschaefer@9elements.com>
---
 docs/devel/qom.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
index 5870745ba27b108726da0756aa2b90109d5e0bd6..935bb1004a7839c8e963985e765c866d5b980c53 100644
--- a/docs/devel/qom.rst
+++ b/docs/devel/qom.rst
@@ -435,14 +435,14 @@ OBJECT_DEFINE_ABSTRACT_TYPE() macro can be used instead:
 Device Life-cycle
 =================
 
-As class initialisation cannot fail devices have an two additional
+As class initialisation cannot fail, devices have two additional
 methods to handle the creation of dynamic devices. The ``realize``
 function is called with ``Error **`` pointer which should be set if
 the device cannot complete its setup. Otherwise on successful
 completion of the ``realize`` method the device object is added to the
 QOM tree and made visible to the guest.
 
-The reverse function is ``unrealize`` and should be were clean-up
+The reverse function is ``unrealize`` and should be where clean-up
 code lives to tidy up after the system is done with the device.
 
 All devices can be instantiated by C code, however only some can

---
base-commit: e89049b3ba5f1f0468bc0d294173345597514a1b
change-id: 20260520-qom-76537da673b6

Best regards,
-- 
J. Neuschäfer <j.neuschaefer@9elements.com>

Re: [PATCH] docs/devel/qom: Fix some editing errors

[Markus Armbruster]

J. Neuschäfer <j.neuschaefer@9elements.com> writes:

> "devices have an two additional [...]" -> "devices have two additional",
> and also a case of "were" vs. "where".
>
> Signed-off-by: J. Neuschäfer <j.neuschaefer@9elements.com>
> ---
>  docs/devel/qom.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index 5870745ba27b108726da0756aa2b90109d5e0bd6..935bb1004a7839c8e963985e765c866d5b980c53 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -435,14 +435,14 @@ OBJECT_DEFINE_ABSTRACT_TYPE() macro can be used instead:
>  Device Life-cycle
>  =================
>  
> -As class initialisation cannot fail devices have an two additional
> +As class initialisation cannot fail, devices have two additional
>  methods to handle the creation of dynamic devices. The ``realize``
>  function is called with ``Error **`` pointer which should be set if
>  the device cannot complete its setup. Otherwise on successful
>  completion of the ``realize`` method the device object is added to the
>  QOM tree and made visible to the guest.
>  
> -The reverse function is ``unrealize`` and should be were clean-up
> +The reverse function is ``unrealize`` and should be where clean-up
>  code lives to tidy up after the system is done with the device.
>  
>  All devices can be instantiated by C code, however only some can
>
> ---
> base-commit: e89049b3ba5f1f0468bc0d294173345597514a1b
> change-id: 20260520-qom-76537da673b6
>
> Best regards,

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Perhaps this could go via qemu-trivial (cc'ed).

Re: [PATCH] docs/devel/qom: Fix some editing errors

[Pierrick Bouvier]

On 5/20/2026 4:15 AM, J. Neuschäfer wrote:
> "devices have an two additional [...]" -> "devices have two additional",
> and also a case of "were" vs. "where".
> 
> Signed-off-by: J. Neuschäfer <j.neuschaefer@9elements.com>
> ---
>  docs/devel/qom.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index 5870745ba27b108726da0756aa2b90109d5e0bd6..935bb1004a7839c8e963985e765c866d5b980c53 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -435,14 +435,14 @@ OBJECT_DEFINE_ABSTRACT_TYPE() macro can be used instead:
>  Device Life-cycle
>  =================
>  
> -As class initialisation cannot fail devices have an two additional
> +As class initialisation cannot fail, devices have two additional
>  methods to handle the creation of dynamic devices. The ``realize``
>  function is called with ``Error **`` pointer which should be set if
>  the device cannot complete its setup. Otherwise on successful
>  completion of the ``realize`` method the device object is added to the
>  QOM tree and made visible to the guest.
>  
> -The reverse function is ``unrealize`` and should be were clean-up
> +The reverse function is ``unrealize`` and should be where clean-up
>  code lives to tidy up after the system is done with the device.
>  
>  All devices can be instantiated by C code, however only some can
> 
> ---
> base-commit: e89049b3ba5f1f0468bc0d294173345597514a1b
> change-id: 20260520-qom-76537da673b6
> 
> Best regards,

Thanks,
I'll pull this through docs subsystem.

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>

Regards,
Pierrick

Re: [PATCH] docs/devel/qom: Fix some editing errors

[Pierrick Bouvier]

On 5/20/2026 4:15 AM, J. Neuschäfer wrote:
> "devices have an two additional [...]" -> "devices have two additional",
> and also a case of "were" vs. "where".
> 
> Signed-off-by: J. Neuschäfer <j.neuschaefer@9elements.com>
> ---
>  docs/devel/qom.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index 5870745ba27b108726da0756aa2b90109d5e0bd6..935bb1004a7839c8e963985e765c866d5b980c53 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -435,14 +435,14 @@ OBJECT_DEFINE_ABSTRACT_TYPE() macro can be used instead:
>  Device Life-cycle
>  =================
>  
> -As class initialisation cannot fail devices have an two additional
> +As class initialisation cannot fail, devices have two additional
>  methods to handle the creation of dynamic devices. The ``realize``
>  function is called with ``Error **`` pointer which should be set if
>  the device cannot complete its setup. Otherwise on successful
>  completion of the ``realize`` method the device object is added to the
>  QOM tree and made visible to the guest.
>  
> -The reverse function is ``unrealize`` and should be were clean-up
> +The reverse function is ``unrealize`` and should be where clean-up
>  code lives to tidy up after the system is done with the device.
>  
>  All devices can be instantiated by C code, however only some can
> 
> ---
> base-commit: e89049b3ba5f1f0468bc0d294173345597514a1b
> change-id: 20260520-qom-76537da673b6
> 
> Best regards,

This was merged into master (cbf877d67a812be17a9ce404a589e1bdf722c1f6).
Thank you for your contribution!

Regards,
Pierrick