From: Thomas Gleixner <tglx@linutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Pan Chuang <panchuang@vivo.com>,
linux-kernel@vger.kernel.org
Cc: miquel.raynal@bootlin.com, Jonathan.Cameron@Huawei.com,
angeg.delregno@collabora.com, krzk@kernel.org, frank.li@vivo.com
Subject: Re: [PATCH v8 1/1] genirq/devres: Add dev_err_probe() in devm_request_threaded_irq() and devm_request_any_context_irq()
Date: Tue, 29 Jul 2025 11:15:14 +0200 [thread overview]
Message-ID: <87o6t3jr31.ffs@tglx> (raw)
In-Reply-To: <73a4fc1d-6852-4050-85c0-8c29b4165e4d@pengutronix.de>
On Tue, Jul 29 2025 at 10:20, Ahmad Fatoum wrote:
> On 29.07.25 10:14, Pan Chuang wrote:
>> + return dev_err_probe(dev, rc, "request_irq(%u) %pS %pS %s\n",
>
> Compared to %ps, %pS also prints offset and size relative to the symbol.
> This makes sense when you have an arbitrary program counter, but for
> merely printing a function symbol, I'd suggest %ps as it's less noisy.
Good point
next prev parent reply other threads:[~2025-07-29 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 8:14 [PATCH v8 0/1] genirq/devres: Add dev_err_probe() in devm_request_threaded_irq() and devm_request_any_context_irq() Pan Chuang
2025-07-29 8:14 ` [PATCH v8 1/1] " Pan Chuang
2025-07-29 8:20 ` Ahmad Fatoum
2025-07-29 9:15 ` Thomas Gleixner [this message]
2025-07-29 9:14 ` Thomas Gleixner
2025-07-29 11:48 ` Pan Chuang
2025-07-29 12:12 ` Thomas Gleixner
2025-07-29 18:35 ` [PATCH v8 0/1] " Markus Elfring
2025-07-30 6:11 ` Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6t3jr31.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Jonathan.Cameron@Huawei.com \
--cc=a.fatoum@pengutronix.de \
--cc=angeg.delregno@collabora.com \
--cc=frank.li@vivo.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=panchuang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.