From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
Maxime Ripard <mripard@kernel.org>
Cc: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>,
Anusha Srivatsa <asrivats@redhat.com>,
"Deak, Imre" <imre.deak@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Linus Walleij <linus.walleij@linaro.org>,
Joel Selvaraj <jo@jsfamily.in>,
Douglas Anderson <dianders@chromium.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 04/10] panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()
Date: Tue, 08 Apr 2025 16:51:25 +0300 [thread overview]
Message-ID: <87o6x6yd5u.fsf@intel.com> (raw)
In-Reply-To: <SJ1PR11MB61291B6DC29337864C59210FB9B52@SJ1PR11MB6129.namprd11.prod.outlook.com>
On Tue, 08 Apr 2025, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
>> > We will need more changes than fixing the variable names.
>> >
>> > I get this error
>> >
>> > ERROR: modpost: "__devm_drm_panel_alloc"
>> [drivers/gpu/drm/panel/panel-auo-a030jtn01.ko] undefined!
>> > make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
>> > make[1]: ***
>> > [/home/chaitanya/exodus/repos/drm-tip-sandbox/Makefile:1956:
>> modpost]
>> > Error 2
>> > make: *** [Makefile:248: __sub-make] Error 2
>> >
>> > after making the following change.
>>
>> I couldn't reproduce this one on current drm-misc-next with arm64 and
>> x86 allmodconfig. Could you share your configuration?
>>
>
> Here is the config that our CI uses
>
> https://gitlab.freedesktop.org/drm/xe/ci/-/raw/main/kernel/kconfig
There's
CONFIG_DRM_PANEL=y
# CONFIG_OF is not set
but __devm_drm_panel_alloc is inside #ifdef CONFIG_OF. I don't know that
it should be.
There are some stubs in drm_panel.h for !CONFIG_OF but not this one.
Finally, DRM_PANEL_AUO_A030JTN01 does not depend on OF.
That's the issue, but I don't know what the correct fix would be.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-04-08 13:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 16:03 [PATCH 00/10] drm/panel: Use refcounted allocation in place of devm_kzalloc() Anusha Srivatsa
2025-04-01 16:03 ` [PATCH 01/10] panel/abt-y030xx067a: Use the " Anusha Srivatsa
2025-04-01 16:03 ` [PATCH 02/10] panel/arm-versatile: " Anusha Srivatsa
2025-04-15 8:01 ` Linus Walleij
2025-04-01 16:03 ` [PATCH 03/10] panel/z00t-tm5p5-n35596: Use " Anusha Srivatsa
2025-04-01 16:03 ` [PATCH 04/10] panel/auo-a030jtn01: " Anusha Srivatsa
2025-04-07 15:49 ` Imre Deak
2025-04-07 23:22 ` Dixit, Ashutosh
2025-04-08 0:18 ` Dixit, Ashutosh
2025-04-08 1:40 ` Dixit, Ashutosh
2025-04-08 4:01 ` Dixit, Ashutosh
2025-04-08 6:47 ` Borah, Chaitanya Kumar
2025-04-08 12:50 ` Maxime Ripard
2025-04-08 13:03 ` Borah, Chaitanya Kumar
2025-04-08 13:51 ` Jani Nikula [this message]
2025-04-08 14:26 ` Dmitry Baryshkov
2025-04-08 14:38 ` Lucas De Marchi
2025-04-08 12:48 ` Maxime Ripard
2025-04-01 16:03 ` [PATCH 05/10] panel/bf060y8m-aj0: " Anusha Srivatsa
2025-04-01 16:03 ` [PATCH 06/10] panel/th101mb31ig002-28a: " Anusha Srivatsa
2025-04-08 8:24 ` Thomas Zimmermann
2025-04-01 16:03 ` [PATCH 07/10] panel/boe-tv101wum-ll2: " Anusha Srivatsa
2025-04-08 8:27 ` Thomas Zimmermann
2025-04-01 16:03 ` [PATCH 08/10] panel/dsi-cm: " Anusha Srivatsa
2025-04-01 16:03 ` [PATCH 09/10] panel/ebbg-ft8719: " Anusha Srivatsa
2025-04-01 16:03 ` [PATCH 10/10] panel/panel-edp: " Anusha Srivatsa
2025-04-02 14:24 ` [PATCH 00/10] drm/panel: " Neil Armstrong
2025-04-02 15:20 ` Anusha Srivatsa
2025-04-07 8:34 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6x6yd5u.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=ashutosh.dixit@intel.com \
--cc=asrivats@redhat.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=jo@jsfamily.in \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.