All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Ezra Buehler <ezra.buehler@husqvarnagroup.com>,
	Alexey Romanov <avromanov@salutedevices.com>,
	 Frieder Schrempf <frieder.schrempf@kontron.de>,
	 <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	 <kernel@salutedevices.com>
Subject: Re: [PATCH v3 4/7] mtd: spinand: add start_page to otp layout
Date: Mon, 30 Dec 2024 10:16:22 +0100	[thread overview]
Message-ID: <87o70t7cpl.fsf@bootlin.com> (raw)
In-Reply-To: <20241226135623.43098-5-mmkurbanov@salutedevices.com> (Martin Kurbanov's message of "Thu, 26 Dec 2024 16:55:49 +0300")

On 26/12/2024 at 16:55:49 +03, Martin Kurbanov <mmkurbanov@salutedevices.com> wrote:

> The OTP area is divided into two parts: the factory and the user.
> In SPI-NAND, it is usually this one OTP region: the first few pages
> are

(this sentence might be reworded, it is not very clear)

> allocated to the factory area. Therefore, enter the start_page field,
> which indicates from which page the custom OTP region starts.

TBH I don't like this shortcut and I would prefer having:
- two otp structures defining each parts (user/factory)
- both the user and factory otp hooks provided
- perhaps a top level macro which does both initializations based on
the (user_otp_)start_page parameter.

But I don't like much hiding the layout subtlety behind a
"start_page" member (although it should probably be named
"user_area_start_page" or something like that, otherwise it's
misleading).

This would also be more future proof, manufacturers are creative.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Ezra Buehler <ezra.buehler@husqvarnagroup.com>,
	Alexey Romanov <avromanov@salutedevices.com>,
	 Frieder Schrempf <frieder.schrempf@kontron.de>,
	 <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	 <kernel@salutedevices.com>
Subject: Re: [PATCH v3 4/7] mtd: spinand: add start_page to otp layout
Date: Mon, 30 Dec 2024 10:16:22 +0100	[thread overview]
Message-ID: <87o70t7cpl.fsf@bootlin.com> (raw)
In-Reply-To: <20241226135623.43098-5-mmkurbanov@salutedevices.com> (Martin Kurbanov's message of "Thu, 26 Dec 2024 16:55:49 +0300")

On 26/12/2024 at 16:55:49 +03, Martin Kurbanov <mmkurbanov@salutedevices.com> wrote:

> The OTP area is divided into two parts: the factory and the user.
> In SPI-NAND, it is usually this one OTP region: the first few pages
> are

(this sentence might be reworded, it is not very clear)

> allocated to the factory area. Therefore, enter the start_page field,
> which indicates from which page the custom OTP region starts.

TBH I don't like this shortcut and I would prefer having:
- two otp structures defining each parts (user/factory)
- both the user and factory otp hooks provided
- perhaps a top level macro which does both initializations based on
the (user_otp_)start_page parameter.

But I don't like much hiding the layout subtlety behind a
"start_page" member (although it should probably be named
"user_area_start_page" or something like that, otherwise it's
misleading).

This would also be more future proof, manufacturers are creative.

Thanks,
Miquèl

  reply	other threads:[~2024-12-30 10:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 13:55 [PATCH v3 0/7] mtd: spinand: add OTP support Martin Kurbanov
2024-12-26 13:55 ` Martin Kurbanov
2024-12-26 13:55 ` [PATCH v3 1/7] mtd: spinand: make spinand_{read,write}_page global Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov
2024-12-26 13:55 ` [PATCH v3 2/7] mtd: spinand: add OTP support Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov
2024-12-26 13:55 ` [PATCH v3 3/7] mtd: spinand: make spinand_{wait,otp_page_size} global Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov
2024-12-26 13:55 ` [PATCH v3 4/7] mtd: spinand: add start_page to otp layout Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov
2024-12-30  9:16   ` Miquel Raynal [this message]
2024-12-30  9:16     ` Miquel Raynal
2024-12-26 13:55 ` [PATCH v3 5/7] mtd: spinand: otp: add helpers functions Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov
2024-12-26 13:55 ` [PATCH v3 6/7] mtd: spinand: micron: OTP access for MT29F2G01ABAGD Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov
2024-12-26 13:55 ` [PATCH v3 7/7] mtd: spinand: esmt: OTP access for F50{L,D}1G41LB Martin Kurbanov
2024-12-26 13:55   ` Martin Kurbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o70t7cpl.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=avromanov@salutedevices.com \
    --cc=ezra.buehler@husqvarnagroup.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@salutedevices.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mmkurbanov@salutedevices.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.