[PATCH] mmc: Hide mmc speed command under mmc command

[PATCH] mmc: Hide mmc speed command under mmc command

[Marek Vasut]

The mmc speed command configuration option keeps showing up in
Kconfig even if CMD_MMC is not set. Move MMC_SPEED_MODE_SET under
CMD_MMC to show up the Kconfig option only if MMC command is enabled.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Michal Simek <michal.simek@amd.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
---
 cmd/Kconfig | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 978f44eda42..efe2357d044 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1399,6 +1399,15 @@ config CMD_MMC_SWRITE
 	  Enable support for the "mmc swrite" command to write Android sparse
 	  images to eMMC.
 
+config MMC_SPEED_MODE_SET
+	bool "set speed mode using mmc command"
+	help
+	  Enable setting speed mode using mmc rescan and mmc dev commands.
+	  The speed mode is provided as the last argument in these commands
+	  and is indicated using the index from enum bus_mode in
+	  include/mmc.h. A speed mode can be set only if it has already
+	  been enabled in the device tree.
+
 endif
 
 config CMD_CLONE
@@ -2963,16 +2972,6 @@ config CMD_UBIFS
 	help
 	  UBIFS is a file system for flash devices which works on top of UBI.
 
-config MMC_SPEED_MODE_SET
-	bool "set speed mode using mmc command"
-	depends on CMD_MMC
-	help
-	  Enable setting speed mode using mmc rescan and mmc dev commands.
-	  The speed mode is provided as the last argument in these commands
-	  and is indicated using the index from enum bus_mode in
-	  include/mmc.h. A speed mode can be set only if it has already
-	  been enabled in the device tree.
-
 config CMD_MESON
 	bool "Amlogic Meson commands"
 	depends on ARCH_MESON
-- 
2.45.2

Re: [PATCH] mmc: Hide mmc speed command under mmc command

[Mattijs Korpershoek]

Hi Marek,

Thank you for the patch.

On jeu., août 29, 2024 at 03:22, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> The mmc speed command configuration option keeps showing up in
> Kconfig even if CMD_MMC is not set. Move MMC_SPEED_MODE_SET under
> CMD_MMC to show up the Kconfig option only if MMC command is enabled.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
> Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Michal Simek <michal.simek@amd.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@lists.denx.de
> ---
>  cmd/Kconfig | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 978f44eda42..efe2357d044 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1399,6 +1399,15 @@ config CMD_MMC_SWRITE
>  	  Enable support for the "mmc swrite" command to write Android sparse
>  	  images to eMMC.
>  
> +config MMC_SPEED_MODE_SET
> +	bool "set speed mode using mmc command"
> +	help
> +	  Enable setting speed mode using mmc rescan and mmc dev commands.
> +	  The speed mode is provided as the last argument in these commands
> +	  and is indicated using the index from enum bus_mode in
> +	  include/mmc.h. A speed mode can be set only if it has already
> +	  been enabled in the device tree.
> +
>  endif
>  
>  config CMD_CLONE
> @@ -2963,16 +2972,6 @@ config CMD_UBIFS
>  	help
>  	  UBIFS is a file system for flash devices which works on top of UBI.
>  
> -config MMC_SPEED_MODE_SET
> -	bool "set speed mode using mmc command"
> -	depends on CMD_MMC
> -	help
> -	  Enable setting speed mode using mmc rescan and mmc dev commands.
> -	  The speed mode is provided as the last argument in these commands
> -	  and is indicated using the index from enum bus_mode in
> -	  include/mmc.h. A speed mode can be set only if it has already
> -	  been enabled in the device tree.
> -
>  config CMD_MESON
>  	bool "Amlogic Meson commands"
>  	depends on ARCH_MESON
> -- 
> 2.45.2

Re: [PATCH] mmc: Hide mmc speed command under mmc command

[Quentin Schulz]

Hi Marek,

On 8/29/24 3:22 AM, Marek Vasut wrote:
> The mmc speed command configuration option keeps showing up in
> Kconfig even if CMD_MMC is not set. Move MMC_SPEED_MODE_SET under

How is that even possible?

Shouldn't

depends on

be enough to NOT show the option?

I just tested now and it does NOT show up when CMD_MMC is disabled, so 
not sure what your issue is?

Cheers,
Quentin

Re: [PATCH] mmc: Hide mmc speed command under mmc command

[Marek Vasut]

On 9/2/24 10:48 AM, Quentin Schulz wrote:
> Hi Marek,

Hi,

> On 8/29/24 3:22 AM, Marek Vasut wrote:
>> The mmc speed command configuration option keeps showing up in
>> Kconfig even if CMD_MMC is not set. Move MMC_SPEED_MODE_SET under
> 
> How is that even possible?
> 
> Shouldn't
> 
> depends on
> 
> be enough to NOT show the option?
> 
> I just tested now and it does NOT show up when CMD_MMC is disabled, so 
> not sure what your issue is?

See V2, I totally messed up the commit message here because too much 
back and forth rebasing.