Re: [libevl][PATCH 2/4] evl-test: Measure worst case latencies

[Philippe Gerum <rpm@xenomai.org>]

Tobias Schaffner <tobias.schaffner@siemens.com> writes:

> Run latmus for 30 seconds after running the unittests to measure the
> worst case latencies.
>
> Allow to run with -u to solely run unittests.
>
> Drop getopt to simplify argument parsing in the process.

Reading the code, I'm not sure this simplifies anything. What is the
actual upside of dropping getopt?

>
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>  utils/evl-test | 55 ++++++++++++++++++++++++--------------------------
>  1 file changed, 26 insertions(+), 29 deletions(-)
>
> diff --git a/utils/evl-test b/utils/evl-test
> index bc7440f..5c1c3da 100644
> --- a/utils/evl-test
> +++ b/utils/evl-test
> @@ -7,44 +7,37 @@ if test \! -d $EVL_TESTDIR; then
>  fi
>  
>  usage() {
> -   echo >&2 "usage: $(basename $1) [-l][-L][-k][-h] [test-list]"
> +   echo >&2 "usage: $(basename $1) [-l][-L][-k][-h][-u] [test-list]"
>  }
>  
> -args=$(getopt -n $(basename $0) 'h@klL' "$@")
> -if [ $? -ne 0 ]; then
> -   usage $0
> -   exit 1
> -fi
> -
> -help=false
>  keep_going=false
>  do_list=false
>  full_path=false
> +unittests_only=false

Unit testing should be on by default, with a full-mode switch including
latmus, because this is the original way for running unattended
tests. Since latmus won't trigger any error on unacceptable latency,
there is no upside to have it on unless we really want to attend the
test, looking at its output.

>  
> -set -- $args
> -for opt
> -do
> -case "$opt" in
> -   -k) keep_going=true;
> -       shift;;
> -   -h) help=true;
> -       shift;;
> -   -l) do_list=true;
> -       shift;;
> -   -L) full_path=true;
> -       do_list=true;
> -       shift;;
> -   -@) echo "run the EVL tests"
> -       exit 0;;
> -   --) shift; break;;
> +while :; do
> +   case "$1" in
> +      -k) keep_going=true
> +          shift;;
> +      -l) do_list=true
> +          shift;;
> +      -L) full_path=true
> +          do_list=true
> +          shift;;
> +      -u) unittests_only=true
> +          shift;;
> +      -@) echo "run the EVL tests"
> +          exit 0;;
> +      --) shift
> +          break;;
> +      "") break;;
> +      -h) usage $0
> +          exit 0;;
> +      *)  usage $0
> +          exit 1;;
>     esac
>  done
>  
> -if test x$help = xtrue; then
> -   usage $0
> -   exit 0
> -fi
> -
>  test_list=
>  for t in "$@"; do
>      test_list="$test_list $(eval echo $EVL_TESTDIR/$t)"
> @@ -89,4 +82,8 @@ for t in $test_list; do
>      fi
>  done
>  
> +if test x$unittests_only = xfalse; then
> +    latmus -T 30
> +fi
> +
>  exit 0


-- 
Philippe.