Re: [libevl][PATCH 3/4] evl-test: Start evl-test with load by default

["Jorge Ramirez-Ortiz, Gmail" <jorge.ramirez.ortiz@gmail.com>]

On 13/06/24 17:30:51, Jan Kiszka wrote:
> On 13.06.24 16:16, Philippe Gerum wrote:
> > 
> > Tobias Schaffner <tobias.schaffner@siemens.com> writes:
> > 
> >> Stress evl with a load command while running the tests. The load command
> >> may be set to an empty string to run tests without stressing the system.
> >>
> >> To align with xeno-test the -l command line argument was used for the load
> >> command. Listing of the unittests can now be done with --list and --List.
> >>
> > 
> > Nak. Compat with xeno-test is definitely not a requirement if this means
> > breaking the existing evl command line usage. Besides, --List looks
> > strange as an option. Let's pick a different option for the load command
> > instead.
> > 
> >> The load command is moved to its own process group to allow a clean
> >> teardown of the load process with all its subprocesses.
> >>
> >> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> >> ---
> >>  utils/evl-test | 71 +++++++++++++++++++++++++++++++++++++++++++-------
> >>  1 file changed, 61 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/utils/evl-test b/utils/evl-test
> >> index 5c1c3da..fb85f69 100644
> >> --- a/utils/evl-test
> >> +++ b/utils/evl-test
> >> @@ -6,33 +6,79 @@ if test \! -d $EVL_TESTDIR; then
> >>     exit 2
> >>  fi
> >>  
> >> -usage() {
> >> -   echo >&2 "usage: $(basename $1) [-l][-L][-k][-h][-u] [test-list]"
> >> -}
> >> -
> >>  keep_going=false
> >>  do_list=false
> >>  full_path=false
> >>  unittests_only=false
> >> +load_cmd="dohell 900"
> >> +load_cmd_pgid_file="/tmp/evl_test_load_cmd_$$"
> >> +
> >> +usage() {
> >> +   cat >&2 <<EOF
> >> +evl test -h
> >> +
> >> +This help text.
> >> +
> >> +evl test [ -l "load command" ] [ -k ] [ -u ] [ --list ] [ --List ]
> >> +
> >> +Run a basic test/benchmark of evl on your platform, by first starting a
> >> +few unit tests, then running the latency test under the load generated by
> >> +"load-command".
> >> +
> >> +By default, the load command is "dohell 900", which will generate load during
> >> +15 minutes. To generate a more realistic load see dohell help.
> >> +
> >> +This script accepts the -k option to tell the unit test loop to keep
> >> +going upon a failing test. Otherwise evl test stops immediately.
> >> +
> > 
> > To be fixed wrt the comment on the previous patch.
> > 
> >> +Use -u if you want to skip the latency test and only run the unittests.
> >> +
> >> +Use --list to output all the tests available. --List will print all the tests
> >> +with their full path.
> >> +
> >> +Example:
> >> +evl test -l "dohell -s 192.168.0.5 -m /mnt -l /ltp"
> >> +
> >> +Will generate load including network load using the server at IP address
> >> +192.168.0.5, some I/O under the moint point /mnt, and the LTP testsuite
> >> +installed under the /ltp directory, and use the latency test by measuring the
> >> +timer irq latency.
> > 
> > We should use stress-ng or something alike, instead of the obsolete
> > dohell script.
> 
> Fact is that dohell does better than stress-ng, at least in the configs
> of the latter that I've seen before.

just "dohell -s 192.168.0.5 -m /mnt -l /ltp" ? do you know after how
long (ie, did it take a few hours or just minutes?)

> 
> Jan
> 
> -- 
> Siemens AG, Technology
> Linux Expert Center
> 
>