From: Michael Ellerman <mpe@ellerman.id.au>
To: Vignesh Balasubramanian <vigbalas@amd.com>,
linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org
Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com,
ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de,
binutils@sourceware.org, jhb@FreeBSD.org,
felix.willgerodt@intel.com,
Vignesh Balasubramanian <vigbalas@amd.com>
Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files
Date: Fri, 15 Mar 2024 09:13:10 +1100 [thread overview]
Message-ID: <87o7bg31jd.fsf@mail.lhotse> (raw)
In-Reply-To: <20240314112359.50713-2-vigbalas@amd.com>
Hi Vignesh,
Vignesh Balasubramanian <vigbalas@amd.com> writes:
> Add a new .note section containing type, size, offset and flags of
> every xfeature that is present.
>
> This information will be used by the debuggers to understand the XSAVE
> layout of the machine where the core file is dumped, and to read XSAVE
> registers, especially during cross-platform debugging.
>
> Co-developed-by: Jini Susan George <jinisusan.george@amd.com>
> Signed-off-by: Jini Susan George <jinisusan.george@amd.com>
> Signed-off-by: Vignesh Balasubramanian <vigbalas@amd.com>
> ---
> arch/Kconfig | 9 +++
> arch/powerpc/Kconfig | 1 +
> arch/powerpc/include/asm/elf.h | 2 -
> arch/x86/Kconfig | 1 +
> arch/x86/include/asm/elf.h | 7 +++
> arch/x86/kernel/fpu/xstate.c | 101 +++++++++++++++++++++++++++++++++
> include/linux/elf.h | 2 +-
> include/uapi/linux/elf.h | 1 +
> 8 files changed, 121 insertions(+), 3 deletions(-)
IMHO you should split the changes to replace ARCH_HAVE_EXTRA_ELF_NOTES
with CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES into a lead-up patch.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Vignesh Balasubramanian <vigbalas@amd.com>,
linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org
Cc: felix.willgerodt@intel.com, matz@suse.de, keescook@chromium.org,
jhb@FreeBSD.org, bpetkov@amd.com, binutils@sourceware.org,
x86@kernel.org, aneesh.kumar@kernel.org, linux-mm@kvack.org,
Vignesh Balasubramanian <vigbalas@amd.com>,
npiggin@gmail.com, naveen.n.rao@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, jinisusan.george@amd.com,
ebiederm@xmission.com
Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files
Date: Fri, 15 Mar 2024 09:13:10 +1100 [thread overview]
Message-ID: <87o7bg31jd.fsf@mail.lhotse> (raw)
In-Reply-To: <20240314112359.50713-2-vigbalas@amd.com>
Hi Vignesh,
Vignesh Balasubramanian <vigbalas@amd.com> writes:
> Add a new .note section containing type, size, offset and flags of
> every xfeature that is present.
>
> This information will be used by the debuggers to understand the XSAVE
> layout of the machine where the core file is dumped, and to read XSAVE
> registers, especially during cross-platform debugging.
>
> Co-developed-by: Jini Susan George <jinisusan.george@amd.com>
> Signed-off-by: Jini Susan George <jinisusan.george@amd.com>
> Signed-off-by: Vignesh Balasubramanian <vigbalas@amd.com>
> ---
> arch/Kconfig | 9 +++
> arch/powerpc/Kconfig | 1 +
> arch/powerpc/include/asm/elf.h | 2 -
> arch/x86/Kconfig | 1 +
> arch/x86/include/asm/elf.h | 7 +++
> arch/x86/kernel/fpu/xstate.c | 101 +++++++++++++++++++++++++++++++++
> include/linux/elf.h | 2 +-
> include/uapi/linux/elf.h | 1 +
> 8 files changed, 121 insertions(+), 3 deletions(-)
IMHO you should split the changes to replace ARCH_HAVE_EXTRA_ELF_NOTES
with CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES into a lead-up patch.
cheers
next prev parent reply other threads:[~2024-03-14 22:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 11:23 [PATCH 0/1] Add XSAVE layout description to Core files for debuggers to support varying XSAVE layouts Vignesh Balasubramanian
2024-03-14 11:23 ` Vignesh Balasubramanian
2024-03-14 11:23 ` [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Vignesh Balasubramanian
2024-03-14 11:23 ` Vignesh Balasubramanian
2024-03-14 15:37 ` Dave Hansen
2024-03-14 15:37 ` Dave Hansen
2024-03-14 16:08 ` Borislav Petkov
2024-03-14 16:08 ` Borislav Petkov
2024-03-14 16:19 ` Dave Hansen
2024-03-14 16:19 ` Dave Hansen
2024-03-14 16:29 ` Borislav Petkov
2024-03-14 16:29 ` Borislav Petkov
2024-03-14 16:39 ` Dave Hansen
2024-03-14 16:39 ` Dave Hansen
2024-03-26 9:59 ` Balasubrmanian, Vignesh
2024-03-26 9:59 ` Balasubrmanian, Vignesh
2024-03-15 23:51 ` Thomas Gleixner
2024-03-15 23:51 ` Thomas Gleixner
2024-03-16 10:29 ` Borislav Petkov
2024-03-16 10:29 ` Borislav Petkov
2024-03-14 16:45 ` John Baldwin
2024-03-14 16:45 ` John Baldwin
2024-03-14 17:10 ` Dave Hansen
2024-03-14 17:10 ` Dave Hansen
2024-03-14 17:36 ` John Baldwin
2024-03-14 17:36 ` John Baldwin
2024-03-14 17:05 ` John Baldwin
2024-03-14 17:05 ` John Baldwin
2024-03-14 16:13 ` Kees Cook
2024-03-14 16:13 ` Kees Cook
2024-03-26 10:06 ` Balasubrmanian, Vignesh
2024-03-26 10:06 ` Balasubrmanian, Vignesh
2024-03-14 22:13 ` Michael Ellerman [this message]
2024-03-14 22:13 ` Michael Ellerman
2024-03-26 10:09 ` Balasubrmanian, Vignesh
2024-03-26 10:09 ` Balasubrmanian, Vignesh
2024-03-15 9:59 ` kernel test robot
2024-03-15 9:59 ` kernel test robot
2024-03-15 12:59 ` kernel test robot
2024-03-15 12:59 ` kernel test robot
2024-03-14 16:25 ` [PATCH 0/1] Add XSAVE layout description to Core files for debuggers to support varying XSAVE layouts Willgerodt, Felix
2024-03-14 16:25 ` Willgerodt, Felix
2024-03-14 16:33 ` Borislav Petkov
2024-03-14 16:33 ` Borislav Petkov
2024-03-15 8:43 ` Willgerodt, Felix
2024-03-15 8:43 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7bg31jd.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@kernel.org \
--cc=binutils@sourceware.org \
--cc=bpetkov@amd.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ebiederm@xmission.com \
--cc=felix.willgerodt@intel.com \
--cc=jhb@FreeBSD.org \
--cc=jinisusan.george@amd.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matz@suse.de \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=vigbalas@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.