All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org,  peter.maydell@linaro.org,
	 pbonzini@redhat.com, mst@redhat.com,  gaosong@loongson.cn,
	 alistair.francis@wdc.com, palmer@dabbelt.com,
	 bin.meng@windriver.com,  liwei1518@gmail.com,
	dbarboza@ventanamicro.com,  zhiwei_liu@linux.alibaba.com,
	anisinha@redhat.com,  philmd@linaro.org,  wangyanan55@huawei.com,
	eblake@redhat.com,  qemu-arm@nongnu.org,  qemu-riscv@nongnu.org,
	f.ebner@proxmox.com
Subject: Re: [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value
Date: Tue, 27 Feb 2024 18:00:32 +0100	[thread overview]
Message-ID: <87o7c1970v.fsf@pond.sub.org> (raw)
In-Reply-To: <20240227154749.1818189-14-imammedo@redhat.com> (Igor Mammedov's message of "Tue, 27 Feb 2024 16:47:43 +0100")

Igor Mammedov <imammedo@redhat.com> writes:

> later patches will use it to pick SMBIOS version at runtime
> depending on configuration.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  qapi/machine.json | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 93b4677286..4c68528507 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1802,10 +1802,13 @@
>  #
>  # @64: SMBIOS version 3.0 (64-bit) Entry Point
>  #
> +# @auto: Either 2.x or 3.x SMBIOS version, 2.x if configuration can be described
> +#        by it and 3.x otherwise (since: 9.0)

Please format like

   # @auto: Either 2.x or 3.x SMBIOS version, 2.x if configuration can be
   #     described by it and 3.x otherwise (since: 9.0)

> +#
>  # Since: 7.0
>  ##
>  { 'enum': 'SmbiosEntryPointType',
> -  'data': [ '32', '64' ] }
> +  'data': [ '32', '64', 'auto' ] }
>  
>  ##
>  # @MemorySizeConfiguration:

With that
Acked-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2024-02-27 17:01 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 15:47 [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS Igor Mammedov
2024-02-27 15:47 ` [PATCH 01/19] tests: smbios: make it possible to write SMBIOS only test Igor Mammedov
2024-02-28  9:35   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 02/19] tests: smbios: add test for -smbios type=11 option Igor Mammedov
2024-02-28  9:55   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 03/19] tests: smbios: add test for legacy mode CLI options Igor Mammedov
2024-02-28 11:11   ` Ani Sinha
2024-02-28 13:59     ` Igor Mammedov
2024-02-28 14:18   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 04/19] smbios: cleanup smbios_get_tables() from legacy handling Igor Mammedov
2024-02-28 11:27   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 05/19] smbios: get rid of smbios_smp_sockets global Igor Mammedov
2024-02-29  7:51   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 06/19] smbios: get rid of smbios_legacy global Igor Mammedov
2024-02-29 10:53   ` Ani Sinha
2024-02-29 14:29     ` Igor Mammedov
2024-03-01  8:33       ` Ani Sinha
2024-03-04 17:38   ` Daniel Henrique Barboza
2024-02-27 15:47 ` [PATCH 07/19] smbios: avoid mangling user provided tables Igor Mammedov
2024-03-04  9:55   ` Ani Sinha
2024-03-04 14:17     ` Igor Mammedov
2024-02-27 15:47 ` [PATCH 08/19] smbios: don't check type4 structures in legacy mode Igor Mammedov
2024-03-04  7:16   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 09/19] smbios: build legacy mode code only for 'pc' machine Igor Mammedov
2024-03-04 10:55   ` Ani Sinha
2024-03-04 14:23     ` Igor Mammedov
2024-03-04 16:43       ` Igor Mammedov
2024-02-27 15:47 ` [PATCH 10/19] smbios: handle errors consistently Igor Mammedov
2024-03-04 11:14   ` Ani Sinha
2024-03-04 13:39     ` Igor Mammedov
2024-03-04 13:53       ` Ani Sinha
2024-02-27 15:47 ` [PATCH 11/19] smbios: clear smbios_tables pointer after freeing Igor Mammedov
2024-03-04 13:54   ` Ani Sinha
2024-03-04 14:25     ` Igor Mammedov
2024-02-27 15:47 ` [PATCH 12/19] get rid of global smbios_ep_type Igor Mammedov
2024-03-04 17:38   ` Daniel Henrique Barboza
2024-03-05  8:39   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value Igor Mammedov
2024-02-27 17:00   ` Markus Armbruster [this message]
2024-03-05  9:15   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 14/19] smbios: in case of entry point is 'auto' try to build v2 tables 1st Igor Mammedov
2024-03-05  6:00   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 15/19] smbios: error out when building type 4 table is not possible Igor Mammedov
2024-03-05 11:36   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 16/19] smbios: clear smbios_type4_count before building tables Igor Mammedov
2024-02-27 15:47 ` [PATCH 17/19] tests: acpi/smbios: whitelist expected blobs Igor Mammedov
2024-02-27 15:47 ` [PATCH 18/19] pc/q35: set SMBIOS entry point type to 'auto' by default Igor Mammedov
2024-03-05 12:21   ` Ani Sinha
2024-02-27 15:47 ` [PATCH 19/19] tests: acpi: update expected SSDT.dimmpxm blob Igor Mammedov
2024-02-27 15:49 ` [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS Michael S. Tsirkin
2024-02-29 13:18 ` Fiona Ebner
2024-03-01 13:55   ` Fiona Ebner
2024-03-05 10:08 ` Michael S. Tsirkin
2024-03-05 10:32   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7c1970v.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=anisinha@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=eblake@redhat.com \
    --cc=f.ebner@proxmox.com \
    --cc=gaosong@loongson.cn \
    --cc=imammedo@redhat.com \
    --cc=liwei1518@gmail.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.