[bug?] 85d2a31fe4d9 ("media: rkisp1: Drop IRQF_SHARED") breaks ISP1 on RK3399

[bug?] 85d2a31fe4d9 ("media: rkisp1: Drop IRQF_SHARED") breaks ISP1 on RK3399

[Mikhail Rudenko]

Hi!

Rockchip ISP1 is broken for me on a custom rk3399-based board in the
latest media_stage. Relevant dmesg fragment:

    rkisp1 ff910000.isp0: Adding to iommu group 2
    genirq: Flags mismatch irq 42. 00000004 (rkisp1) vs. 00000084 (ff914000.iommu)
    rkisp1 ff910000.isp0: request irq failed: -16
    rkisp1: probe of ff910000.isp0 failed with error -16
    rkisp1 ff920000.isp1: Adding to iommu group 3
    genirq: Flags mismatch irq 43. 00000004 (rkisp1) vs. 00000084 (ff924000.iommu)
    rkisp1 ff920000.isp1: request irq failed: -16
    rkisp1: probe of ff920000.isp1 failed with error -16

According to rk3399.dtsi, isp interrupts are shared with correponding
mmu interrupts (isp0 with isp0_mmu, isp1 with isp1_mmu), so the subject
commit breaks devm_request_irq. Reverting it fixes the issue for me.

If I'm just missing something, sorry for the noise.

--
Best regards,
Mikhail Rudenko

Re: [bug?] 85d2a31fe4d9 ("media: rkisp1: Drop IRQF_SHARED") breaks ISP1 on RK3399

[Laurent Pinchart]

Hi Mikhail,

On Sun, Dec 17, 2023 at 10:14:34PM +0300, Mikhail Rudenko wrote:
> Hi!
> 
> Rockchip ISP1 is broken for me on a custom rk3399-based board in the
> latest media_stage. Relevant dmesg fragment:
> 
>     rkisp1 ff910000.isp0: Adding to iommu group 2
>     genirq: Flags mismatch irq 42. 00000004 (rkisp1) vs. 00000084 (ff914000.iommu)
>     rkisp1 ff910000.isp0: request irq failed: -16
>     rkisp1: probe of ff910000.isp0 failed with error -16
>     rkisp1 ff920000.isp1: Adding to iommu group 3
>     genirq: Flags mismatch irq 43. 00000004 (rkisp1) vs. 00000084 (ff924000.iommu)
>     rkisp1 ff920000.isp1: request irq failed: -16
>     rkisp1: probe of ff920000.isp1 failed with error -16
> 
> According to rk3399.dtsi, isp interrupts are shared with correponding
> mmu interrupts (isp0 with isp0_mmu, isp1 with isp1_mmu), so the subject
> commit breaks devm_request_irq. Reverting it fixes the issue for me.
> 
> If I'm just missing something, sorry for the noise.

You seem to be right. I don't know how I managed to miss that.

Tomi, would a revert of the offending commit be enough, or are there
other issues introduced by the other changes in the rkisp1 driver on top
of the shared IRQ drop that will need to be handled too ?

-- 
Regards,

Laurent Pinchart

Re: [bug?] 85d2a31fe4d9 ("media: rkisp1: Drop IRQF_SHARED") breaks ISP1 on RK3399

[Tomi Valkeinen]

Hi Mikhail,

On 18/12/2023 03:53, Laurent Pinchart wrote:
> Hi Mikhail,
> 
> On Sun, Dec 17, 2023 at 10:14:34PM +0300, Mikhail Rudenko wrote:
>> Hi!
>>
>> Rockchip ISP1 is broken for me on a custom rk3399-based board in the
>> latest media_stage. Relevant dmesg fragment:
>>
>>      rkisp1 ff910000.isp0: Adding to iommu group 2
>>      genirq: Flags mismatch irq 42. 00000004 (rkisp1) vs. 00000084 (ff914000.iommu)
>>      rkisp1 ff910000.isp0: request irq failed: -16
>>      rkisp1: probe of ff910000.isp0 failed with error -16
>>      rkisp1 ff920000.isp1: Adding to iommu group 3
>>      genirq: Flags mismatch irq 43. 00000004 (rkisp1) vs. 00000084 (ff924000.iommu)
>>      rkisp1 ff920000.isp1: request irq failed: -16
>>      rkisp1: probe of ff920000.isp1 failed with error -16
>>
>> According to rk3399.dtsi, isp interrupts are shared with correponding
>> mmu interrupts (isp0 with isp0_mmu, isp1 with isp1_mmu), so the subject
>> commit breaks devm_request_irq. Reverting it fixes the issue for me.
>>
>> If I'm just missing something, sorry for the noise.
> 
> You seem to be right. I don't know how I managed to miss that.
> 
> Tomi, would a revert of the offending commit be enough, or are there
> other issues introduced by the other changes in the rkisp1 driver on top
> of the shared IRQ drop that will need to be handled too ?

Thanks for reporting this. I have sent a revert, and a fix for the 
shared irq handling.

  Tomi