* [PATCH] drm/print: Handle NULL drm device in __drm_printk()
@ 2023-11-17 3:54 Luben Tuikov
2023-11-17 10:44 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Luben Tuikov @ 2023-11-17 3:54 UTC (permalink / raw)
To: Jani Nikula; +Cc: Direct Rendering Infrastructure - Development, Luben Tuikov
drm_{err,warn,...}() use __drm_printk() which takes a drm device pointer and
uses the embedded device pointer to print the device. This facility handles
NULL device pointer, but not NULL drm device pointer. This patch makes
__drm_printk() also handle a NULL drm device pointer. The printed output is
identical to if drm->dev had been NULL.
Signed-off-by: Luben Tuikov <ltuikov89@gmail.com>
---
include/drm/drm_print.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index a93a387f8a1a15..dd4883df876a6d 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -453,7 +453,7 @@ void __drm_dev_dbg(struct _ddebug *desc, const struct device *dev,
/* Helper for struct drm_device based logging. */
#define __drm_printk(drm, level, type, fmt, ...) \
- dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
+ dev_##level##type((drm) ? (drm)->dev : NULL, "[drm] " fmt, ##__VA_ARGS__)
#define drm_info(drm, fmt, ...) \
base-commit: 3b434a3445fff3149128db0169da864d67057325
--
2.42.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/print: Handle NULL drm device in __drm_printk()
2023-11-17 3:54 [PATCH] drm/print: Handle NULL drm device in __drm_printk() Luben Tuikov
@ 2023-11-17 10:44 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2023-11-17 10:44 UTC (permalink / raw)
To: Luben Tuikov; +Cc: Direct Rendering Infrastructure - Development, Luben Tuikov
On Thu, 16 Nov 2023, Luben Tuikov <ltuikov89@gmail.com> wrote:
> drm_{err,warn,...}() use __drm_printk() which takes a drm device pointer and
> uses the embedded device pointer to print the device. This facility handles
> NULL device pointer, but not NULL drm device pointer. This patch makes
> __drm_printk() also handle a NULL drm device pointer. The printed output is
> identical to if drm->dev had been NULL.
>
> Signed-off-by: Luben Tuikov <ltuikov89@gmail.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_print.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index a93a387f8a1a15..dd4883df876a6d 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -453,7 +453,7 @@ void __drm_dev_dbg(struct _ddebug *desc, const struct device *dev,
>
> /* Helper for struct drm_device based logging. */
> #define __drm_printk(drm, level, type, fmt, ...) \
> - dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
> + dev_##level##type((drm) ? (drm)->dev : NULL, "[drm] " fmt, ##__VA_ARGS__)
>
>
> #define drm_info(drm, fmt, ...) \
>
> base-commit: 3b434a3445fff3149128db0169da864d67057325
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-17 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-17 3:54 [PATCH] drm/print: Handle NULL drm device in __drm_printk() Luben Tuikov
2023-11-17 10:44 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.