From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Brian Norris <briannorris@chromium.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] wifi: mwifiex: fix SDIO firmware dump wait
Date: Thu, 21 Sep 2023 15:12:23 +0300 [thread overview]
Message-ID: <87o7hvafo8.fsf@kernel.org> (raw)
In-Reply-To: <cc57fb2f-1eca-f366-bec3-d4cdbb2c39ec@yandex.ru> (Dmitry Antipov's message of "Thu, 21 Sep 2023 12:22:59 +0300")
Dmitry Antipov <dmantipov@yandex.ru> writes:
> On 9/21/23 02:15, Brian Norris wrote:
>
>> Have you tested this patch? You've certainly caught a logic bug, but
>> that doesn't mean the seemingly obvious solution actually works.
>
> Unfortunately by eyes only :-(. IIUC there should be a weird hardware
> stall to trigger an execution of the branch in subject, so I'm not sure
> how to actually test it even if I would have an access to the hardware.
I don't know about Brian but for me testing for regressions is the most
important part. If the patch is only compile tested it could break the
whole driver without anyone noticing. And then it's in a release and too
late.
That's why I have been asking you to add "Compile tested only" to the
commit log so that it's obvious to everyone that your patches have
received zero testing but you don't seem to care.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-09-21 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 11:22 [PATCH] wifi: mwifiex: fix SDIO firmware dump wait Dmitry Antipov
2023-09-20 23:15 ` Brian Norris
2023-09-21 9:22 ` Dmitry Antipov
2023-09-21 12:12 ` Kalle Valo [this message]
2023-09-23 1:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7hvafo8.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=briannorris@chromium.org \
--cc=dmantipov@yandex.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.