All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
	 Bjorn Andersson <quic_bjorande@quicinc.com>,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	 ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI""
Date: Tue, 22 Aug 2023 15:56:24 +0300	[thread overview]
Message-ID: <87o7izi6br.fsf@kernel.org> (raw)
In-Reply-To: <ZONpkVU1ORHj-zFH@hovoldconsulting.com> (Johan Hovold's message of "Mon, 21 Aug 2023 15:41:37 +0200")

Johan Hovold <johan@kernel.org> writes:

> Hi Kalle,
>
> On Wed, Aug 09, 2023 at 09:34:32AM +0200, Johan Hovold wrote:
>
>> Disabling threaded NAPI caused a severe regression in 6.5-rc5 by making
>> the X13s completely unusable (e.g. no keyboard input, I've seen an RCU
>> splat once).
>> 
>> I'm supposed to be on holiday this week, but thanks to the rain I gave
>> rc5 a try and ran into this.
>> 
>> I've added Bjorn, Mani and Konrad on CC who may be able to help with
>> debugging this further if needed while I'm out-of-office.
>
> Back from my holiday now, and this regression is still there with
> 6.5-rc7.

I was also away but back now.

> Any chance we can get the offending commit reverted before 6.5 is
> released? 

The problem here is that would break QCN9074 again so there is no good
solution. I suspect we have a fundamental issue in ath11k which we just
haven't discovered yet. I would prefer to get to the bottom of this
before reverting anything.

> I'll take a closer look at this meanwhile.

Thanks, much appreciated. Did you try enabling all kernel debug
features, maybe they would give some hints?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
	Bjorn Andersson <quic_bjorande@quicinc.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI""
Date: Tue, 22 Aug 2023 15:56:24 +0300	[thread overview]
Message-ID: <87o7izi6br.fsf@kernel.org> (raw)
In-Reply-To: <ZONpkVU1ORHj-zFH@hovoldconsulting.com> (Johan Hovold's message of "Mon, 21 Aug 2023 15:41:37 +0200")

Johan Hovold <johan@kernel.org> writes:

> Hi Kalle,
>
> On Wed, Aug 09, 2023 at 09:34:32AM +0200, Johan Hovold wrote:
>
>> Disabling threaded NAPI caused a severe regression in 6.5-rc5 by making
>> the X13s completely unusable (e.g. no keyboard input, I've seen an RCU
>> splat once).
>> 
>> I'm supposed to be on holiday this week, but thanks to the rain I gave
>> rc5 a try and ran into this.
>> 
>> I've added Bjorn, Mani and Konrad on CC who may be able to help with
>> debugging this further if needed while I'm out-of-office.
>
> Back from my holiday now, and this regression is still there with
> 6.5-rc7.

I was also away but back now.

> Any chance we can get the offending commit reverted before 6.5 is
> released? 

The problem here is that would break QCN9074 again so there is no good
solution. I suspect we have a fundamental issue in ath11k which we just
haven't discovered yet. I would prefer to get to the bottom of this
before reverting anything.

> I'll take a closer look at this meanwhile.

Thanks, much appreciated. Did you try enabling all kernel debug
features, maybe they would give some hints?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-08-22 12:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  7:34 [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI"" Johan Hovold
2023-08-09  7:34 ` Johan Hovold
2023-08-09  9:02 ` Manikanta Pubbisetty
2023-08-09  9:02   ` Manikanta Pubbisetty
2023-08-09  9:16   ` Johan Hovold
2023-08-09  9:16     ` Johan Hovold
2023-08-10  4:33     ` Manikanta Pubbisetty
2023-08-10  4:33       ` Manikanta Pubbisetty
2023-08-21 13:27       ` Johan Hovold
2023-08-21 13:27         ` Johan Hovold
2023-08-10  4:46     ` Manikanta Pubbisetty
2023-08-10  4:46       ` Manikanta Pubbisetty
2023-08-21 13:29       ` Johan Hovold
2023-08-21 13:29         ` Johan Hovold
2023-08-21 13:41 ` Johan Hovold
2023-08-21 13:41   ` Johan Hovold
2023-08-22 12:56   ` Kalle Valo [this message]
2023-08-22 12:56     ` Kalle Valo
2023-08-22 13:44     ` Johan Hovold
2023-08-22 13:44       ` Johan Hovold
2023-08-26 15:53       ` Johan Hovold
2023-08-26 15:53         ` Johan Hovold
2023-08-29 11:47         ` Kalle Valo
2023-08-29 11:47           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7izi6br.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johan@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_mpubbise@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.