From: Petr Machata <petrm@nvidia.com>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: Petr Machata <petrm@nvidia.com>, Ido Schimmel <idosch@idosch.org>,
<razor@blackwall.org>, Ido Schimmel <idosch@nvidia.com>,
<netdev@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout
Date: Wed, 2 Aug 2023 12:33:37 +0200 [thread overview]
Message-ID: <87o7jpenpd.fsf@nvidia.com> (raw)
In-Reply-To: <304ba960-0214-82d4-05be-e5956baa64c7@alu.unizg.hr>
Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr> writes:
> On 8/1/23 13:08, Petr Machata wrote:
>> diff --git a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>> b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>> index aff88f78e339..5ea9d63915f7 100755
>> --- a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>> +++ b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>> @@ -72,7 +72,8 @@ test_span_gre_ttl()
>> RET=0
>> - mirror_install $swp1 ingress $tundev "matchall $tcflags"
>> + mirror_install $swp1 ingress $tundev \
>> + "prot ip flower $tcflags ip_prot icmp"
>> tc filter add dev $h3 ingress pref 77 prot $prot \
>> flower skip_hw ip_ttl 50 action pass
>>
>
> The problem seems to be fixed in the test run:
>
> root@defiant:tools/testing/selftests/net/forwarding# ./mirror_gre_changes.sh
> TEST: mirror to gretap: TTL change (skip_hw) [ OK ]
> TEST: mirror to ip6gretap: TTL change (skip_hw) [ OK ]
> TEST: mirror to gretap: tunnel down/up (skip_hw) [ OK ]
> TEST: mirror to ip6gretap: tunnel down/up (skip_hw) [ OK ]
> TEST: mirror to gretap: egress down/up (skip_hw) [ OK ]
> TEST: mirror to ip6gretap: egress down/up (skip_hw) [ OK ]
> TEST: mirror to gretap: remote address change (skip_hw) [ OK ]
> TEST: mirror to ip6gretap: remote address change (skip_hw) [ OK ]
> TEST: mirror to gretap: tunnel deleted (skip_hw) [ OK ]
> TEST: mirror to ip6gretap: tunnel deleted (skip_hw) [ OK ]
> TEST: mirror to gretap: underlay route removal (skip_hw) [ OK ]
> TEST: mirror to ip6gretap: underlay route removal (skip_hw) [ OK ]
> WARN: Could not test offloaded functionality
> root@defiant:tools/testing/selftests/net/forwarding#
OK, I'll add your Tested-by, let it pass through our regression and send
upstream.
next prev parent reply other threads:[~2023-08-02 10:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 0:36 [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 02/11] selftests: forwarding: gre_custom_multipath_hash.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 03/11] selftests: forwarding: gre_inner_v4_multipath.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 04/11] selftests: forwarding: gre_multipath_nh_res.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 05/11] selftests: forwarding: gre_multipath_nh.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 06/11] selftests: forwarding: ip6gre_custom_multipath_hash.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 07/11] selftests: forwarding: ip6gre_inner_v4_multipath.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 08/11] selftests: forwarding: no_forwarding.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 09/11] selftests: forwarding: router_mpath_nh_res.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 10/11] selftests: forwarding: router_mpath_nh.sh: " Mirsad Todorovac
2023-07-22 0:36 ` [PATCH v1 11/11] selftests: forwarding: router_multipath.sh: " Mirsad Todorovac
2023-07-23 8:25 ` [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: " Ido Schimmel
2023-07-23 17:27 ` Ido Schimmel
2023-07-23 18:50 ` Mirsad Todorovac
2023-07-23 18:54 ` Mirsad Todorovac
2023-07-23 21:37 ` Mirsad Todorovac
2023-07-24 14:45 ` Ido Schimmel
2023-07-24 20:46 ` Mirsad Todorovac
2023-07-26 12:22 ` Ido Schimmel
2023-07-26 16:57 ` Ido Schimmel
2023-07-27 3:48 ` Mirsad Todorovac
2023-07-27 19:26 ` Mirsad Todorovac
2023-07-30 7:53 ` Ido Schimmel
2023-07-30 16:48 ` Mirsad Todorovac
2023-07-31 7:54 ` Ido Schimmel
2023-07-31 9:24 ` Mirsad Todorovac
2023-07-31 12:02 ` Ido Schimmel
2023-07-31 15:13 ` Mirsad Todorovac
2023-07-31 15:48 ` Ido Schimmel
2023-08-01 20:41 ` Mirsad Todorovac
2023-07-31 15:23 ` Mirsad Todorovac
2023-08-01 11:08 ` Petr Machata
2023-08-01 16:54 ` Mirsad Todorovac
2023-08-02 10:33 ` Petr Machata [this message]
2023-08-02 11:06 ` Mirsad Todorovac
2023-07-25 8:44 ` Petr Machata
2023-07-25 16:23 ` Mirsad Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7jpenpd.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.