All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: Ido Schimmel <idosch@nvidia.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout
Date: Mon, 24 Jul 2023 17:45:42 +0300	[thread overview]
Message-ID: <ZL6OljQubhVtQjcD@shredder> (raw)
In-Reply-To: <adc5e40d-d040-a65e-eb26-edf47dac5b02@alu.unizg.hr>

On Sun, Jul 23, 2023 at 11:37:46PM +0200, Mirsad Todorovac wrote:
> Some tests however exited with error:
> 
> marvin@defiant:~/linux/kernel/linux_torvalds$ grep "not ok" ../kselftest-6.5-rc2-net-forwarding-11.log
> not ok 3 selftests: net/forwarding: bridge_mdb.sh # exit=1
> not ok 5 selftests: net/forwarding: bridge_mdb_max.sh # exit=1
> not ok 11 selftests: net/forwarding: bridge_vlan_mcast.sh # exit=1

I can't reproduce these three.

Do you have systemd-networkd running? If so, by default it tries to
take over interfaces unless you tell it not to. For example, on my
system I have:

$ cat /etc/systemd/network/10-ignore.link 
[Match]
OriginalName=*

[Link]
MACAddressPolicy=none

This tells systemd not to assign a persistent MAC address on virtual
interfaces.

And (redacted):

$ cat /etc/systemd/network/80-dhcp.network 
[Match]
...

This tells systemd to only manage the interfaces matching the match
criteria and ignore the rest.

> not ok 15 selftests: net/forwarding: ethtool_extended_state.sh # exit=1
> not ok 17 selftests: net/forwarding: ethtool.sh # exit=1
> not ok 25 selftests: net/forwarding: hw_stats_l3_gre.sh # exit=1

Fixed these three.

> not ok 26 selftests: net/forwarding: ip6_forward_instats_vrf.sh # exit=1

Fixed.

> not ok 80 selftests: net/forwarding: tc_actions.sh # exit=1
> not ok 83 selftests: net/forwarding: tc_flower.sh # exit=1
> not ok 84 selftests: net/forwarding: tc_flower_l2_miss.sh # exit=1
> not ok 89 selftests: net/forwarding: tc_tunnel_key.sh # exit=1

Can't reproduce these.

Pushed the fixes on top of the fixes from yesterday:

https://github.com/idosch/linux/commits/submit/sefltests_fix_v1

  reply	other threads:[~2023-07-24 14:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22  0:36 [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 02/11] selftests: forwarding: gre_custom_multipath_hash.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 03/11] selftests: forwarding: gre_inner_v4_multipath.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 04/11] selftests: forwarding: gre_multipath_nh_res.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 05/11] selftests: forwarding: gre_multipath_nh.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 06/11] selftests: forwarding: ip6gre_custom_multipath_hash.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 07/11] selftests: forwarding: ip6gre_inner_v4_multipath.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 08/11] selftests: forwarding: no_forwarding.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 09/11] selftests: forwarding: router_mpath_nh_res.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 10/11] selftests: forwarding: router_mpath_nh.sh: " Mirsad Todorovac
2023-07-22  0:36 ` [PATCH v1 11/11] selftests: forwarding: router_multipath.sh: " Mirsad Todorovac
2023-07-23  8:25 ` [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: " Ido Schimmel
2023-07-23 17:27   ` Ido Schimmel
2023-07-23 18:50     ` Mirsad Todorovac
2023-07-23 18:54   ` Mirsad Todorovac
2023-07-23 21:37     ` Mirsad Todorovac
2023-07-24 14:45       ` Ido Schimmel [this message]
2023-07-24 20:46         ` Mirsad Todorovac
2023-07-26 12:22           ` Ido Schimmel
2023-07-26 16:57             ` Ido Schimmel
2023-07-27  3:48               ` Mirsad Todorovac
2023-07-27 19:26             ` Mirsad Todorovac
2023-07-30  7:53               ` Ido Schimmel
2023-07-30 16:48                 ` Mirsad Todorovac
2023-07-31  7:54                   ` Ido Schimmel
2023-07-31  9:24                     ` Mirsad Todorovac
2023-07-31 12:02                       ` Ido Schimmel
2023-07-31 15:13                         ` Mirsad Todorovac
2023-07-31 15:48                           ` Ido Schimmel
2023-08-01 20:41                             ` Mirsad Todorovac
2023-07-31 15:23                         ` Mirsad Todorovac
2023-08-01 11:08                 ` Petr Machata
2023-08-01 16:54                   ` Mirsad Todorovac
2023-08-02 10:33                     ` Petr Machata
2023-08-02 11:06                       ` Mirsad Todorovac
2023-07-25  8:44 ` Petr Machata
2023-07-25 16:23   ` Mirsad Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZL6OljQubhVtQjcD@shredder \
    --to=idosch@idosch.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.