From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Chensheng Dong" <chdong@redhat.com>,
"Zhiyi Guo" <zhguo@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>
Subject: Re: [PATCH] migration: Allow user to specify migration available bandwidth
Date: Wed, 26 Jul 2023 08:21:35 +0200 [thread overview]
Message-ID: <87o7jz8a6o.fsf@pond.sub.org> (raw)
In-Reply-To: <ZL/7XtiEFWEprQhD@x1n> (Peter Xu's message of "Tue, 25 Jul 2023 12:42:06 -0400")
Peter Xu <peterx@redhat.com> writes:
> Hi, Markus,
>
> On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote:
[...]
>> For better or worse, we duplicate full documentation between
>> MigrationParameter, MigrateSetParameters, and MigrationParameters. This
>> would be the first instance where we reference instead. I'm not opposed
>> to use references, but if we do, I want them used consistently.
>
> We discussed this over the other "switchover" parameter, but that patchset
> just stranded..
>
> Perhaps I just provide a pre-requisite patch to remove all the comments in
> MigrateSetParameters and MigrationParameters, letting them all point to
> MigrationParameter?
Simplifies maintaining the doc commments. But how does it affect the
documentation generated from it? Better, neutral, or worse?
> One thing I should have mentioned much earlier is that this patch is for
> 8.2 material.
Understood.
[...]
next prev parent reply other threads:[~2023-07-26 6:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 17:07 [PATCH] migration: Allow user to specify migration available bandwidth Peter Xu
2023-07-24 18:04 ` Daniel P. Berrangé
2023-07-24 18:12 ` Peter Maydell
2023-07-24 19:47 ` Peter Xu
2023-07-25 9:16 ` Daniel P. Berrangé
2023-07-25 15:54 ` Peter Xu
2023-07-25 16:09 ` Daniel P. Berrangé
2023-07-25 16:38 ` Peter Xu
2023-07-25 17:10 ` Daniel P. Berrangé
2023-07-26 15:19 ` Peter Xu
2023-07-25 11:10 ` Markus Armbruster
2023-07-25 16:42 ` Peter Xu
2023-07-26 6:21 ` Markus Armbruster [this message]
2023-07-26 15:12 ` Peter Xu
2023-08-04 12:06 ` Markus Armbruster
2023-08-04 13:28 ` Peter Xu
2023-08-05 8:13 ` Markus Armbruster
2023-08-04 13:39 ` Daniel P. Berrangé
2023-08-04 14:02 ` Peter Xu
2023-08-05 8:05 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7jz8a6o.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=chdong@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhguo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.