All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	 linux-arm-msm@vger.kernel.org,  andersson@kernel.org,
	 agross@kernel.org,  marijn.suijten@somainline.org,
	 "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 ath10k@lists.infradead.org,  linux-wireless@vger.kernel.org,
	 netdev@vger.kernel.org,  devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply
Date: Fri, 03 Mar 2023 14:56:36 +0200	[thread overview]
Message-ID: <87o7payovv.fsf@kernel.org> (raw)
In-Reply-To: <41665c73-1647-2cb2-bd33-8dc281a97ee5@linaro.org> (Konrad Dybcio's message of "Fri, 3 Mar 2023 12:28:21 +0100")

Konrad Dybcio <konrad.dybcio@linaro.org> writes:

> On 3.03.2023 08:12, Krzysztof Kozlowski wrote:
>> On 03/03/2023 03:42, Konrad Dybcio wrote:
>>> Mention the newly added vdd-smps supply.
>> 
>> There is no explanation here, but looking at your driver change it
>> suggests name is not correct. You named it based on regulator (so the
>> provider), not the consumer.

Yeah, it would be nice to have more than just one sentence in the commit
log.

> Right, I admit this could have been posted with an RFC tag.
> Maybe Kalle knows more.

Unfortunately not, but maybe Bjorn knows?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-arm-msm@vger.kernel.org, andersson@kernel.org,
	agross@kernel.org, marijn.suijten@somainline.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply
Date: Fri, 03 Mar 2023 14:56:36 +0200	[thread overview]
Message-ID: <87o7payovv.fsf@kernel.org> (raw)
In-Reply-To: <41665c73-1647-2cb2-bd33-8dc281a97ee5@linaro.org> (Konrad Dybcio's message of "Fri, 3 Mar 2023 12:28:21 +0100")

Konrad Dybcio <konrad.dybcio@linaro.org> writes:

> On 3.03.2023 08:12, Krzysztof Kozlowski wrote:
>> On 03/03/2023 03:42, Konrad Dybcio wrote:
>>> Mention the newly added vdd-smps supply.
>> 
>> There is no explanation here, but looking at your driver change it
>> suggests name is not correct. You named it based on regulator (so the
>> provider), not the consumer.

Yeah, it would be nice to have more than just one sentence in the commit
log.

> Right, I admit this could have been posted with an RFC tag.
> Maybe Kalle knows more.

Unfortunately not, but maybe Bjorn knows?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-03-03 12:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03  2:42 [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply Konrad Dybcio
2023-03-03  2:42 ` Konrad Dybcio
2023-03-03  2:42 ` [PATCH 2/2] wifi: ath10k: snoc: Add VDD_SMPS regulator Konrad Dybcio
2023-03-03  2:42   ` Konrad Dybcio
2023-03-03  7:12 ` [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply Krzysztof Kozlowski
2023-03-03  7:12   ` Krzysztof Kozlowski
2023-03-03 11:28   ` Konrad Dybcio
2023-03-03 11:28     ` Konrad Dybcio
2023-03-03 12:56     ` Kalle Valo [this message]
2023-03-03 12:56       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7payovv.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.