All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Zhenyu Zhang <zhenyzha@redhat.com>
Cc: qemu-devel@nongnu.org,  gshan@redhat.com,  imammedo@redhat.com
Subject: Re: [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix
Date: Mon, 14 Nov 2022 08:42:20 +0100	[thread overview]
Message-ID: <87o7ta3rtv.fsf@pond.sub.org> (raw)
In-Reply-To: <20221114032431.195098-1-zhenyzha@redhat.com> (Zhenyu Zhang's message of "Sun, 13 Nov 2022 22:24:31 -0500")

Zhenyu Zhang <zhenyzha@redhat.com> writes:

> Commit ffac16fab3 "hostmem: introduce "prealloc-threads" property"
> (v5.0.0) changed the default number of threads from number of CPUs
> to 1.  This was deemed a regression, and fixed in commit f8d426a685
> "hostmem: default the amount of prealloc-threads to smp-cpus".
> Except the documentation remained unchanged.
>
> Update 'qapi/qom.json' to reflect the change in commit f8d426a6852c.
>
> Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
> ---
>
> v4: Fix the line exceeding 80 characters limitation issue  (Gavin)
> v3: Covers historical descriptions                         (Markus)
> v2: The property is changed to smp-cpus since 5.0          (Phild)
>
> ---
>  qapi/qom.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 30e76653ad..f4a7917f3d 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -576,7 +576,8 @@
>  #
>  # @prealloc: if true, preallocate memory (default: false)
>  #
> -# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
> +# @prealloc-threads: number of CPU threads to use for prealloc 

Could drop "CPU" while there.  Not worth a respin by itself, but perhaps
the maintainer can drop it for you.

> +#                    (default: number of CPUs) (since 5.0)
>  #
>  # @prealloc-context: thread context to use for creation of preallocation threads
>  #                    (default: none) (since 7.2)

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  parent reply	other threads:[~2022-11-15  0:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  3:24 [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix Zhenyu Zhang
2022-11-14  5:19 ` Gavin Shan
2022-11-14  7:42 ` Markus Armbruster [this message]
2022-11-14  8:33 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7ta3rtv.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=gshan@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhenyzha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.